From: Sakari Ailus <sakari.ailus@iki.fi>
To: Luca Weiss <luca@z3ntu.xyz>
Cc: Rob Herring <robh@kernel.org>,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-media@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Shunqian Zheng <zhengsq@rock-chips.com>,
phone-devel@vger.kernel.org,
Helen Koike <helen.koike@collabora.com>
Subject: Re: [PATCH] media: dt-bindings: ov2685: convert to dtschema
Date: Tue, 14 Mar 2023 14:00:52 +0200 [thread overview]
Message-ID: <ZBBh9Euor7R24euV@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <2665862.mvXUDI8C0e@z3ntu.xyz>
Hi Luca,
On Thu, Feb 09, 2023 at 05:46:48PM +0100, Luca Weiss wrote:
> +CC Helen Koike
>
> On Montag, 6. Februar 2023 22:50:08 CET Rob Herring wrote:
> > On Mon, 06 Feb 2023 21:23:16 +0100, Luca Weiss wrote:
> > > Convert the text-based dt-bindings to yaml.
> > >
> > > Changes from original txt:
> > > * Take wording for various properties from other yaml bindings, this
> > >
> > > removes e.g. volt amount from schema since it isn't really relevant
> > > and the datasheet is a better source.
> > >
> > > * Don't make reset-gpios a required property since it can be tied to
> > >
> > > DOVDD instead.
> > >
> > > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > > ---
> > >
> > > .../devicetree/bindings/media/i2c/ov2685.txt | 41 ---------
> > > .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101
> > > +++++++++++++++++++++ MAINTAINERS
> > > | 1 +
> > > 3 files changed, 102 insertions(+), 41 deletions(-)
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/medi
> > a/rockchip-isp1.example.dtb: camera@3c: 'clocks' is a required property From
> > schema:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/i2c/ovti,ov2685.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/rockchip-isp1.example.dtb: camera@3c: 'clock-names' is a required
> > property From schema:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/i2c/ovti,ov2685.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/rockchip-isp1.example.dtb: camera@3c: 'dvdd-supply' is a required
> > property From schema:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/i2c/ovti,ov2685.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/rockchip-isp1.example.dtb: camera@3c: 'avdd-supply' is a required
> > property From schema:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/i2c/ovti,ov2685.yaml
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/rockchip-isp1.example.dtb: camera@3c: 'dovdd-supply' is a required
> > property From schema:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> > ia/i2c/ovti,ov2685.yaml
>
> Looks like rockchip-isp1.yaml uses very incomplete sensor examples in their
> binding example, which sort of makes sense since those bindings are showing
> the rockchip isp bindings and contain the bare minimum to show how a sensor is
> connected in dt.
>
> Not sure how to solve this - ov2685 is also one of three sensors that are used
> very abbreviated there.
Could these regulators be simply made optional?
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2023-03-14 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 20:23 [PATCH] media: dt-bindings: ov2685: convert to dtschema Luca Weiss
2023-02-06 21:50 ` Rob Herring
2023-02-09 16:46 ` Luca Weiss
2023-03-14 12:00 ` Sakari Ailus [this message]
2023-03-14 18:33 ` Luca Weiss
2023-03-14 18:36 ` Krzysztof Kozlowski
2023-03-14 19:53 ` Sakari Ailus
2023-03-14 18:37 ` Krzysztof Kozlowski
2023-03-14 18:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBBh9Euor7R24euV@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=devicetree@vger.kernel.org \
--cc=helen.koike@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=zhengsq@rock-chips.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).