phone-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>,
	cros-qcom-dts-watchers@chromium.org,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 10/11] dt-bindings: arm: qcom: Add QCM6490 Fairphone 5
Date: Wed, 30 Aug 2023 12:13:48 +0200	[thread overview]
Message-ID: <b1c1b06c-7d7a-e4a9-0fb9-9ba1d0cf8346@linaro.org> (raw)
In-Reply-To: <20230830-fp5-initial-v1-10-5a954519bbad@fairphone.com>

On 30/08/2023 11:58, Luca Weiss wrote:
> Fairphone 5 is a smartphone based on the QCM6490 SoC.
> 
> Also allow qcom,board-id and qcom,msm-id for QCM6490 since it's required
> by the bootloader.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index adbfaea32343..b09a41812cf0 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -391,6 +391,11 @@ properties:
>            - const: qcom,qrb2210
>            - const: qcom,qcm2290
>  
> +      - items:
> +          - enum:
> +              - fairphone,fp5
> +          - const: qcom,qcm6490

You miss update to first list of SoCs for bootloader.

> +
>        - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform
>          items:
>            - enum:
> @@ -1074,6 +1079,7 @@ allOf:
>                - qcom,msm8994
>                - qcom,msm8996
>                - qcom,msm8998
> +              - qcom,qcm6490

This is not a legacy SoC (released in 2022). Not allowed.

Best regards,
Krzysztof


  reply	other threads:[~2023-08-30 18:52 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  9:58 [PATCH 00/11] Initial support for the Fairphone 5 smartphone Luca Weiss
2023-08-30  9:58 ` [PATCH 01/11] arm64: dts: qcom: sc7280: Mark some nodes as 'reserved' Luca Weiss
2023-08-30 10:08   ` Konrad Dybcio
2023-08-30 10:35     ` Luca Weiss
2023-08-30 10:45       ` Konrad Dybcio
2023-08-30  9:58 ` [PATCH 02/11] nvmem: qfprom: Mark core clk as optional Luca Weiss
2023-08-30 10:03   ` Krzysztof Kozlowski
2023-08-30 14:30   ` Doug Anderson
2023-08-30 14:43     ` Luca Weiss
2023-08-30 14:57       ` Doug Anderson
2023-09-01 14:54         ` Luca Weiss
2023-09-01 15:08           ` Doug Anderson
2023-09-02 11:28             ` Konrad Dybcio
2023-09-04  8:14             ` Luca Weiss
2023-09-01 20:29       ` Trilok Soni
2023-08-30  9:58 ` [PATCH 03/11] arm64: dts: qcom: sc7280: Move qfprom clock to chrome-common Luca Weiss
2023-08-30 10:09   ` Konrad Dybcio
2023-08-31 11:28     ` Luca Weiss
2023-08-30  9:58 ` [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable Luca Weiss
2023-08-30 10:06   ` Krzysztof Kozlowski
2023-08-31 10:12     ` Luca Weiss
2023-08-31 11:33       ` Dmitry Baryshkov
2023-08-31 11:54         ` Krzysztof Kozlowski
2023-08-31 12:27           ` Dmitry Baryshkov
2023-09-05  8:30             ` Luca Weiss
2023-09-11  8:34               ` Luca Weiss
2023-09-11  9:44                 ` Krzysztof Kozlowski
2023-09-11  9:59                   ` Luca Weiss
2023-09-11 11:15                     ` Krzysztof Kozlowski
2023-09-11 11:22                       ` Konrad Dybcio
2023-08-31 12:32           ` Luca Weiss
2023-08-30  9:58 ` [PATCH 05/11] arm64: dts: qcom: pm8350c: Add flash led node Luca Weiss
2023-08-30  9:58 ` [PATCH 06/11] dt-bindings: pinctrl: qcom,sc7280: Allow gpio-reserved-ranges Luca Weiss
2023-08-30 10:08   ` Krzysztof Kozlowski
2023-08-30 11:47   ` Linus Walleij
2023-08-30  9:58 ` [PATCH 07/11] dt-bindings: arm: qcom,ids: Add SoC ID for QCM6490 Luca Weiss
2023-08-30 10:08   ` Krzysztof Kozlowski
2023-08-30 10:16   ` Konrad Dybcio
2023-08-30  9:58 ` [PATCH 08/11] soc: qcom: socinfo: " Luca Weiss
2023-08-30 10:09   ` Krzysztof Kozlowski
2023-08-30  9:58 ` [PATCH 09/11] cpufreq: Add QCM6490 to cpufreq-dt-platdev blocklist Luca Weiss
2023-08-30 10:10   ` Krzysztof Kozlowski
2023-08-31  5:01   ` Viresh Kumar
2023-08-30  9:58 ` [PATCH 10/11] dt-bindings: arm: qcom: Add QCM6490 Fairphone 5 Luca Weiss
2023-08-30 10:13   ` Krzysztof Kozlowski [this message]
2023-08-30  9:58 ` [PATCH 11/11] arm64: dts: qcom: qcm6490: Add device-tree for " Luca Weiss
2023-08-30 10:17   ` Krzysztof Kozlowski
2023-08-30 10:45   ` Konrad Dybcio
2023-09-01 14:27     ` Luca Weiss
2023-09-02 11:45       ` Konrad Dybcio
2023-09-04  8:19         ` Luca Weiss
2023-09-14 16:04 ` (subset) [PATCH 00/11] Initial support for the Fairphone 5 smartphone Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1c1b06c-7d7a-e4a9-0fb9-9ba1d0cf8346@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).