From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B104C433DB for ; Tue, 2 Mar 2021 13:57:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3336360C41 for ; Tue, 2 Mar 2021 13:57:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376830AbhCBNvn (ORCPT ); Tue, 2 Mar 2021 08:51:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349134AbhCBCLy (ORCPT ); Mon, 1 Mar 2021 21:11:54 -0500 Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22A4FC061A31 for ; Mon, 1 Mar 2021 18:05:27 -0800 (PST) Received: by mail-il1-x131.google.com with SMTP id z9so6320958iln.1 for ; Mon, 01 Mar 2021 18:05:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OMAkFwrDaoBrADQrZLrO26UXj3cMyIb0sK7jmLzwxzo=; b=StnTdqRXXDf3QDvcgHZ4h/0Rxqz+nXZnXUArMIrKzWU/UPaIDjzUSwb3xpxDP+2j8Y TQBnuHu/XA1ybiR4Z+euIpM9TxwrPjz6KfVQZUIyM+8TjjHUXQIHYtQPS3s1dwlzO0DW iCpFxDt+al9abYIAZpmEj/fGnSNoNH66TVfsI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OMAkFwrDaoBrADQrZLrO26UXj3cMyIb0sK7jmLzwxzo=; b=dGFyxuYfuvjhBqU/kVzOyG9yyUyc6udlwZbv23KnHWJbQaotUs+YjGLevAjITEwKHL KSeFQT4ApKBvz9ITe5WvvPU1Wm537tvOWvLCE6KAxRWCxyGsak1V9sjqINPoOhfKUudE L00tTYfYx0ubR5A0eTfg5jvJbPGDYeQHarFLrTFrfcZ3zD9ZzDfe/RKwCBLHB7M5WI4P 3FnuCGmiDjCJrVYIkbpCyM0qEgwxUbwzLZrJrhbz+8/HLQWQVnaOOkFmRI2sv97Fqe2R 5Nga43pWuP2ocOkaqwFNQhzQea65JicoiwZ+vlR7irJ3ENv041Fu1laFoPux8k7mPgC/ TGWw== X-Gm-Message-State: AOAM531t5xumBexSZYN8jXzdOEsMFkLI0BCB48/mCoovQUUq2kBSGr94 cKf0daD8UePNG+/JzzWJr92C0wL0BNKRtjUR X-Google-Smtp-Source: ABdhPJxbVIMFCmzQHcFdmv/4+aM5pwIW9x/DqOvFiMFNODFWiLW3j/n6AhdBSgAyzQM1qbClkpu4cA== X-Received: by 2002:a05:6e02:1a0f:: with SMTP id s15mr16360469ild.244.1614650726395; Mon, 01 Mar 2021 18:05:26 -0800 (PST) Received: from [172.22.22.26] (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.googlemail.com with ESMTPSA id s8sm9331939ilv.76.2021.03.01.18.05.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Mar 2021 18:05:25 -0800 (PST) Subject: Re: [PATCH v1 6/7] dt-bindings: net: qcom-ipa: Document qcom,sc7180-ipa compatible To: AngeloGioacchino Del Regno , elder@kernel.org Cc: bjorn.andersson@linaro.org, agross@kernel.org, davem@davemloft.net, kuba@kernel.org, linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, phone-devel@vger.kernel.org References: <20210211175015.200772-1-angelogioacchino.delregno@somainline.org> <20210211175015.200772-7-angelogioacchino.delregno@somainline.org> From: Alex Elder Message-ID: Date: Mon, 1 Mar 2021 20:05:24 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210211175015.200772-7-angelogioacchino.delregno@somainline.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: phone-devel@vger.kernel.org On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote: > The driver supports SC7180, but the binding was not documented. > Just add it. I hadn't noticed that! I'm trying to get through reviewing your series today and this will take another hour or so to go validate to my satisfaction. Would you be willing to submit just this patch as a fix, and when you do I will give it a proper review? -Alex > Signed-off-by: AngeloGioacchino Del Regno > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index 8a2d12644675..b063c6c1077a 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -43,7 +43,11 @@ description: > > properties: > compatible: > - const: "qcom,sdm845-ipa" > + oneOf: > + - items: > + - enum: > + - "qcom,sdm845-ipa" > + - "qcom,sc7180-ipa" > > reg: > items: >