From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
To: Alex Elder <elder@ieee.org>, elder@kernel.org
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
davem@davemloft.net, kuba@kernel.org,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
konrad.dybcio@somainline.org, marijn.suijten@somainline.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v1 0/7] Add support for IPA v3.1, GSI v1.0, MSM8998 IPA
Date: Thu, 11 Feb 2021 22:51:07 +0100 [thread overview]
Message-ID: <f30c9f66-8284-0ada-3586-edf75fce12f7@somainline.org> (raw)
In-Reply-To: <3a596fce-9aa3-e2eb-7920-4ada65f8d2ee@ieee.org>
Il 11/02/21 21:27, Alex Elder ha scritto:
> On 2/11/21 11:50 AM, AngeloGioacchino Del Regno wrote:
>> Hey all!
>>
>> This time around I thought that it would be nice to get some modem
>> action going on. We have it, it's working (ish), so just.. why not.
>
> Thank you for the patches!
>
> I would like to review these carefully but I'm sorry
> I won't be able to get to it today, and possibly not
> for a few days. But I *will* review them.
>
Don't worry :))
> I just want you to know I'm paying attention, though
> I'm sort of buried in an important issue right now.
>
> I'm very impressed at how small the patches are though.
Actually, the driver is in a great shape. That's why the patches are
that small: thanks to you!
-- Angelo
>
> -Alex
>
>> This series adds support for IPA v3.1 (featuring GSI v1.0) and also
>> takes account for some bits that are shared with other unimplemented
>> IPA v3 variants and it is specifically targeting MSM8998, for which
>> support is added.
>>
>> Since the userspace isn't entirely ready (as far as I can see) for
>> data connection (3g/lte/whatever) through the modem, it was possible
>> to only partially test this series.
>> Specifically, loading the IPA firmware and setting up the interface
>> went just fine, along with a basic setup of the network interface
>> that got exposed by this driver.
>>
>> With this series, the benefits that I see are:
>> 1. The modem doesn't crash anymore when trying to setup a data
>> connection, as now the modem firmware seems to be happy with
>> having IPA initialized and ready;
>> 2. Other random modem crashes while picking up LTE home network
>> signal (even just for calling, nothing fancy) seem to be gone.
>>
>> These are the reasons why I think that this series is ready for
>> upstream action. It's *at least* stabilizing the platform when
>> the modem is up.
>>
>> This was tested on the F(x)Tec Pro 1 (MSM8998) smartphone.
>>
>> AngeloGioacchino Del Regno (7):
>> net: ipa: Add support for IPA v3.1 with GSI v1.0
>> net: ipa: endpoint: Don't read unexistant register on IPAv3.1
>> net: ipa: gsi: Avoid some writes during irq setup for older IPA
>> net: ipa: gsi: Use right masks for GSI v1.0 channels hw param
>> net: ipa: Add support for IPA on MSM8998
>> dt-bindings: net: qcom-ipa: Document qcom,sc7180-ipa compatible
>> dt-bindings: net: qcom-ipa: Document qcom,msm8998-ipa compatible
>>
>> .../devicetree/bindings/net/qcom,ipa.yaml | 7 +-
>> drivers/net/ipa/Makefile | 3 +-
>> drivers/net/ipa/gsi.c | 33 +-
>> drivers/net/ipa/gsi_reg.h | 5 +
>> drivers/net/ipa/ipa_data-msm8998.c | 407 ++++++++++++++++++
>> drivers/net/ipa/ipa_data.h | 5 +
>> drivers/net/ipa/ipa_endpoint.c | 26 +-
>> drivers/net/ipa/ipa_main.c | 12 +-
>> drivers/net/ipa/ipa_reg.h | 3 +
>> drivers/net/ipa/ipa_version.h | 1 +
>> 10 files changed, 480 insertions(+), 22 deletions(-)
>> create mode 100644 drivers/net/ipa/ipa_data-msm8998.c
>>
>
next prev parent reply other threads:[~2021-02-11 21:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 17:50 [PATCH v1 0/7] Add support for IPA v3.1, GSI v1.0, MSM8998 IPA AngeloGioacchino Del Regno
2021-02-11 17:50 ` [PATCH v1 1/7] net: ipa: Add support for IPA v3.1 with GSI v1.0 AngeloGioacchino Del Regno
2021-02-12 18:49 ` Jakub Kicinski
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 2/7] net: ipa: endpoint: Don't read unexistant register on IPAv3.1 AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 3/7] net: ipa: gsi: Avoid some writes during irq setup for older IPA AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 4/7] net: ipa: gsi: Use right masks for GSI v1.0 channels hw param AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 5/7] net: ipa: Add support for IPA on MSM8998 AngeloGioacchino Del Regno
2021-02-12 18:50 ` Jakub Kicinski
2021-03-02 2:05 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 6/7] dt-bindings: net: qcom-ipa: Document qcom,sc7180-ipa compatible AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-03-05 19:32 ` Rob Herring
2021-05-05 22:43 ` Alex Elder
2021-02-11 17:50 ` [PATCH v1 7/7] dt-bindings: net: qcom-ipa: Document qcom,msm8998-ipa compatible AngeloGioacchino Del Regno
2021-03-02 2:05 ` Alex Elder
2021-03-05 19:33 ` Rob Herring
2021-05-05 22:43 ` Alex Elder
2021-02-11 20:27 ` [PATCH v1 0/7] Add support for IPA v3.1, GSI v1.0, MSM8998 IPA Alex Elder
2021-02-11 21:51 ` AngeloGioacchino Del Regno [this message]
2021-03-02 2:04 ` Alex Elder
2021-05-05 22:42 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f30c9f66-8284-0ada-3586-edf75fce12f7@somainline.org \
--to=angelogioacchino.delregno@somainline.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=netdev@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).