From: Mark Pearson <markpearson@lenovo.com>
To: Hans de Goede <hdegoede@redhat.com>,
Nicolo' Piazzalunga <nicolopiazzalunga@gmail.com>,
<platform-driver-x86@vger.kernel.org>,
"Nitin Joshi1" <njoshi1@lenovo.com>,
Sebastian Reichel <sre@kernel.org>
Cc: <jwrdegoede@fedoraproject.org>, <smclt30p@gmail.com>,
<linrunner@gmx.net>
Subject: Re: [External] Re: [PATCH 1/3] thinkpad_acpi: add support for force_discharge
Date: Mon, 27 Sep 2021 09:59:55 -0400 [thread overview]
Message-ID: <2ea2d9b7-4a15-6aea-1aff-4e1cb80a026f@lenovo.com> (raw)
In-Reply-To: <06f65bb5-eca4-c1ba-a8c2-b44f8a94c699@redhat.com>
Hi Hans
On 2021-04-07 06:24, Hans de Goede wrote:
> Hi Nicola,
>
> Thank you for your patch series.
>
> I'm not sure what to do with these. I have a couple of concerns here:
>
> 1. These features are useful, but not super useful and as such I wonder
> how often they are used and this how well tested the firmware is wrt these.
> I have added Mark and Nitin from Lenovo to the Cc. Mark, Nitin, can you
> comment on if it is ok from a firmware pov to try and use the following
> battery related ACPI methods on all thinkpads? :
>
> #define GET_DISCHARGE "BDSG"
> #define SET_DISCHARGE "BDSS"
> #define GET_INHIBIT "PSSG"
> #define SET_INHIBIT "BICS"
>
I followed up with the firmware team on this - and was told these are
intended to be internal only methods. They are not something the FW team
expected to support or to be used by customers. From a Lenovo point of
view these are not recommended and not supported APIs. Not sure where
you got the API details from but they probably shouldn't have been
disclosed :)
Obviously not our call if they get included or not, however they should
come with a big flag that says "Don't use these unless you know what you
are doing". Our recommendation is not to include them.
Do let me know if there are some important use cases for these so I can
go back to the FW team and discuss supporting them properly.
Mark
next prev parent reply other threads:[~2021-09-27 14:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 14:01 [PATCH 1/3] thinkpad_acpi: add support for force_discharge Nicolo' Piazzalunga
2021-04-07 10:24 ` Hans de Goede
2021-04-07 10:33 ` Barnabás Pőcze
2021-04-08 13:51 ` Sebastian Reichel
2021-04-08 18:18 ` Thomas Koch
2021-04-09 18:33 ` Thomas Koch
2021-04-13 8:05 ` Hans de Goede
2021-04-17 11:49 ` Thomas Koch
2021-04-17 17:03 ` Hans de Goede
2021-05-19 14:45 ` Nicolo' Piazzalunga
2021-04-07 12:19 ` Thomas Koch
2021-04-07 17:48 ` [External] " Mark Pearson
[not found] ` <VI1PR09MB2302B7C3AD8014CC98D36AA595759@VI1PR09MB2302.eurprd09.prod.outlook.com>
2021-04-12 17:10 ` Mark Pearson
2021-09-27 13:59 ` Mark Pearson [this message]
2021-09-27 15:00 ` Nicolò Piazzalunga
2021-09-27 15:12 ` Hans de Goede
2021-09-27 16:50 ` [External] " Mark Pearson
2021-09-29 5:47 ` Thomas Koch
2021-09-29 9:55 ` Hans de Goede
2021-09-29 10:45 ` Thomas Koch
2021-09-29 10:56 ` Hans de Goede
2021-09-29 13:45 ` [External] " Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ea2d9b7-4a15-6aea-1aff-4e1cb80a026f@lenovo.com \
--to=markpearson@lenovo.com \
--cc=hdegoede@redhat.com \
--cc=jwrdegoede@fedoraproject.org \
--cc=linrunner@gmx.net \
--cc=nicolopiazzalunga@gmail.com \
--cc=njoshi1@lenovo.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=smclt30p@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).