From: Thomas Koch <linrunner@gmx.net>
To: "Thomas Weißschuh" <linux@weissschuh.net>,
linux-pm@vger.kernel.org, "Sebastian Reichel" <sre@kernel.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
"Mark Gross" <markgross@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>
Cc: linux-kernel@vger.kernel.org, bberg@redhat.com,
hadess@hadess.net, markpearson@lenovo.com,
nicolopiazzalunga@gmail.com, njoshi1@lenovo.com,
smclt30p@gmail.com
Subject: Re: [PATCH 0/4] power: supply: add charge_behaviour property (force-discharge, inhibit-charge)
Date: Tue, 16 Nov 2021 17:56:43 +0100 [thread overview]
Message-ID: <9cebba85-f399-a7aa-91f7-237852338dc5@gmx.net> (raw)
In-Reply-To: <20211113104225.141333-1-linux@weissschuh.net>
Hi Thomas,
thank you very much for working on this. It is high time that we leave
external kernel modules for ThinkPads behind us.
On 13.11.21 11:42, Thomas Weißschuh wrote:
> Hi,
>
> this series adds support for the charge_behaviour property to the power
> subsystem and thinkpad_acpi driver.
>
> As thinkpad_acpi has to use the 'struct power_supply' created by the generic
> ACPI driver it has to rely on custom sysfs attributes instead of proper
> power_supply properties to implement this property.
>
> Patch 1: Adds the power_supply documentation and basic public API
> Patch 2: Adds helpers to power_supply core to help drivers implement the
> charge_behaviour attribute
> Patch 3: Adds support for force-discharge to thinkpad_acpi.
> Patch 4: Adds support for inhibit-discharge to thinkpad_acpi.
>
> Patch 3 and 4 are largely taken from other patches and adapted to the new API.
> (Links are in the patch trailer)
>
> Ognjen Galic, Nicolo' Piazzalunga, Thomas Koch:
>
> Your S-o-b is on the original inhibit_charge and force_discharge patches.
> I would like to add you as Co-developed-by but to do that it will also require
> your S-o-b. Could you give your sign-offs for the new patches, so you can be
> properly attributed?
S-o-b/Co-developed-by/Tested-by is fine with me.
I tested your patches.
Hardware:
- ThinkPad X220, BAT0
- ThinkPad T450s, BAT0+BAT1
- ThinkPad X1C6, BAT0
Test Results:
1. force-discharge
Everythings works as expected
- Writing including disengaging w/ "auto" : OK
- Reading: OK
- Battery discharging: OK
- Disengaging with "auto": OK
2. inhibit-charge
Works as expected:
- Writing: OK
- Disengaging with "auto": OK
Discrepancies:
- Battery charge inhibited: BAT0 OK, BAT1 no effect e.g. continues charging
- Reading: always returns "auto"
Note: the reading discrepancy may be related to Hans' remarks [1].
[1]
https://lore.kernel.org/all/09a66da1-1a8b-a668-3179-81670303ea37@redhat.com/
>
> Sebastian Reichel:
>
> Currently the series does not actually support the property as a proper
> powersupply property handled fully by power_supply_sysfs.c because there would
> be no user for this property.
>
> Previous discussions about the API:
>
> https://lore.kernel.org/platform-driver-x86/20211108192852.357473-1-linux@weissschuh.net/
> https://lore.kernel.org/platform-driver-x86/21569a89-8303-8573-05fb-c2fec29983d1@gmail.com/
>
> Thomas Weißschuh (4):
> power: supply: add charge_behaviour attributes
> power: supply: add helpers for charge_behaviour sysfs
> platform/x86: thinkpad_acpi: support force-discharge
> platform/x86: thinkpad_acpi: support inhibit-charge
>
> Documentation/ABI/testing/sysfs-class-power | 14 ++
> drivers/platform/x86/thinkpad_acpi.c | 154 +++++++++++++++++++-
> drivers/power/supply/power_supply_sysfs.c | 51 +++++++
> include/linux/power_supply.h | 16 ++
> 4 files changed, 231 insertions(+), 4 deletions(-)
>
>
> base-commit: 66f4beaa6c1d28161f534471484b2daa2de1dce0
>
--
Freundliche Grüße / Kind regards,
Thomas Koch
Mail : linrunner@gmx.net
Web : https://linrunner.de/tlp
next prev parent reply other threads:[~2021-11-16 16:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 10:42 [PATCH 0/4] power: supply: add charge_behaviour property (force-discharge, inhibit-charge) Thomas Weißschuh
2021-11-13 10:42 ` [PATCH 1/4] power: supply: add charge_behaviour attributes Thomas Weißschuh
2021-11-13 10:42 ` [PATCH 2/4] power: supply: add helpers for charge_behaviour sysfs Thomas Weißschuh
2021-11-13 10:42 ` [PATCH 3/4] platform/x86: thinkpad_acpi: support force-discharge Thomas Weißschuh
2021-11-16 20:35 ` [External] " Mark Pearson
2021-11-13 10:42 ` [PATCH 4/4] platform/x86: thinkpad_acpi: support inhibit-charge Thomas Weißschuh
2021-11-16 10:58 ` Hans de Goede
2021-11-16 12:18 ` Thomas Weißschuh
2021-11-16 20:52 ` [External] " Mark Pearson
2021-11-16 23:44 ` Thomas Weißschuh
2021-11-17 15:09 ` Mark Pearson
2021-11-16 16:56 ` Thomas Koch [this message]
2021-11-17 17:57 ` [PATCH 0/4] power: supply: add charge_behaviour property (force-discharge, inhibit-charge) Thomas Weißschuh
2021-11-17 18:20 ` [External] " Mark Pearson
2021-11-17 18:36 ` Thomas Koch
2021-11-23 23:27 Thomas Weißschuh
2021-12-03 21:33 ` Sebastian Reichel
2021-12-04 13:56 ` Hans de Goede
2021-12-16 15:41 ` Hans de Goede
2021-12-21 16:06 ` Hans de Goede
2021-12-04 16:04 ` Thomas Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cebba85-f399-a7aa-91f7-237852338dc5@gmx.net \
--to=linrunner@gmx.net \
--cc=bberg@redhat.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=markgross@kernel.org \
--cc=markpearson@lenovo.com \
--cc=nicolopiazzalunga@gmail.com \
--cc=njoshi1@lenovo.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=smclt30p@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).