From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ed Wildgoose <lists@wildgooses.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Florian Eckert <fe@dev.tdt.de>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] gpio: gpio-amd-fch: Fix typo on define of AMD_FCH_GPIO_REG_GPIO55_DEVSLP0
Date: Mon, 21 Sep 2020 10:55:49 +0300 [thread overview]
Message-ID: <CAHp75Vd2uz-QrEFshUr=e719VBX2zYzvOhVC07BpHfvi0WDgOA@mail.gmail.com> (raw)
In-Reply-To: <20200920203207.25696-1-lists@wildgooses.com>
On Sun, Sep 20, 2020 at 11:33 PM Ed Wildgoose <lists@wildgooses.com> wrote:
>
> Schematics show that the GPIO number is 55 (not 59). Trivial typo.
Does it still DEVSLP0? Perhaps you need to drop that part as well.
...
> #define APU2_GPIO_REG_LED3 AMD_FCH_GPIO_REG_GPIO59_DEVSLP1
> #define APU2_GPIO_REG_MODESW AMD_FCH_GPIO_REG_GPIO32_GE1
> #define APU2_GPIO_REG_SIMSWAP AMD_FCH_GPIO_REG_GPIO33_GE2
> -#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO59_DEVSLP0
> +#define APU2_GPIO_REG_MPCIE2 AMD_FCH_GPIO_REG_GPIO55_DEVSLP0
> #define APU2_GPIO_REG_MPCIE3 AMD_FCH_GPIO_REG_GPIO51
>
> /* Order in which the GPIO lines are defined in the register list */
> diff --git a/include/linux/platform_data/gpio/gpio-amd-fch.h b/include/linux/platform_data/gpio/gpio-amd-fch.h
> index 9e46678ed..255d51c9d 100644
> --- a/include/linux/platform_data/gpio/gpio-amd-fch.h
> +++ b/include/linux/platform_data/gpio/gpio-amd-fch.h
> @@ -19,7 +19,7 @@
> #define AMD_FCH_GPIO_REG_GPIO49 0x40
> #define AMD_FCH_GPIO_REG_GPIO50 0x41
> #define AMD_FCH_GPIO_REG_GPIO51 0x42
> -#define AMD_FCH_GPIO_REG_GPIO59_DEVSLP0 0x43
> +#define AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 0x43
> #define AMD_FCH_GPIO_REG_GPIO57 0x44
> #define AMD_FCH_GPIO_REG_GPIO58 0x45
> #define AMD_FCH_GPIO_REG_GPIO59_DEVSLP1 0x46
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-21 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 20:32 [PATCH] gpio: gpio-amd-fch: Fix typo on define of AMD_FCH_GPIO_REG_GPIO55_DEVSLP0 Ed Wildgoose
2020-09-21 7:55 ` Andy Shevchenko [this message]
2020-09-21 8:40 ` Ed W
2020-09-28 10:33 ` Ed W
2020-09-28 11:45 ` Andy Shevchenko
2020-10-12 19:58 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vd2uz-QrEFshUr=e719VBX2zYzvOhVC07BpHfvi0WDgOA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=fe@dev.tdt.de \
--cc=hdegoede@redhat.com \
--cc=info@metux.net \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@wildgooses.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).