platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Julian Labus" <julian@labus-online.de>,
	platform-driver-x86@vger.kernel.org,
	"Thomas Weißschuh" <thomas@weissschuh.net>
Subject: Re: [PATCH] platform/x86: gigabyte-wmi: add X570 AORUS ELITE
Date: Thu, 15 Apr 2021 10:33:59 +0200	[thread overview]
Message-ID: <b32beea3-2856-3313-c6a1-37f19990e0e2@redhat.com> (raw)
In-Reply-To: <20210415074526.1782-1-julian@labus-online.de>

Hi Julian,

Thank you for your patch.

As indicated in the MAINTAINERS file the gigabyte-wmi driver
is maintained by Thomas Weißschuh (added to the Cc), so you should
have Cc-ed Thomas on this submission.

Thomas can you review/ack this please ?

(the patch looks fine to me but I want to give you a chance to comment
on it before merging it)

Regards,

Hans




On 4/15/21 9:45 AM, Julian Labus wrote:
> Add the X570 AORUS ELITE to gigabyte_wmi_known_working_platforms
> 
> Signed-off-by: Julian Labus <julian@labus-online.de>
> ---
> 
> I read on phoronix.com that a driver for Gigabyte WMI will be added.
> I gave it a try on my Gigabyte X570 AORUS ELITE with force_load=1 and
> it seem to work fine. lm_sensors shows 6 sensors with reasonable values.
> 
> gigabyte_wmi-virtual-0
> Adapter: Virtual device
> temp1:        +26.0°C  
> temp2:        +30.0°C  
> temp3:        +27.0°C  
> temp4:        +34.0°C  
> temp5:        +29.0°C  
> temp6:        +43.0°C  
> 
> The patch was created against the for-next branch of platform-drivers-x86.git
> 
>  drivers/platform/x86/gigabyte-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/gigabyte-wmi.c b/drivers/platform/x86/gigabyte-wmi.c
> index bb1b0b205fa7..e127a2077bbc 100644
> --- a/drivers/platform/x86/gigabyte-wmi.c
> +++ b/drivers/platform/x86/gigabyte-wmi.c
> @@ -146,6 +146,10 @@ static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
>  		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
>  		DMI_EXACT_MATCH(DMI_BOARD_NAME, "Z390 I AORUS PRO WIFI-CF"),
>  	}},
> +	{ .matches = {
> +		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
> +		DMI_EXACT_MATCH(DMI_BOARD_NAME, "X570 AORUS ELITE"),
> +	}},
>  	{ .matches = {
>  		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
>  		DMI_EXACT_MATCH(DMI_BOARD_NAME, "X570 I AORUS PRO WIFI"),
> 


  reply	other threads:[~2021-04-15  8:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15  7:45 [PATCH] platform/x86: gigabyte-wmi: add X570 AORUS ELITE Julian Labus
2021-04-15  8:33 ` Hans de Goede [this message]
2021-04-15  9:00   ` Thomas Weißschuh
2021-04-15  9:10 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b32beea3-2856-3313-c6a1-37f19990e0e2@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=julian@labus-online.de \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=thomas@weissschuh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).