platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: david.e.box@linux.intel.com, Kate Hsuan <hpa@redhat.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <mgross@linux.intel.com>,
	Alex Hung <alex.hung@canonical.com>,
	Sujith Thomas <sujith.thomas@intel.com>,
	Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	David E Box <david.e.box@intel.com>,
	Zha Qipeng <qipeng.zha@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	AceLan Kao <acelan.kao@canonical.com>,
	Jithu Joseph <jithu.joseph@intel.com>,
	Maurice Ma <maurice.ma@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Daniel Scally <djrscally@gmail.com>,
	linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 00/20] Move Intel platform drivers to intel directory to improve readability.
Date: Tue, 10 Aug 2021 10:28:29 -0700	[thread overview]
Message-ID: <c6a90704-5080-d479-0022-58e5d106c026@infradead.org> (raw)
In-Reply-To: <9a142d180bffa7524bb36ccdba1c866f8b084720.camel@linux.intel.com>

On 8/10/21 10:03 AM, David E. Box wrote:
> Hi,
> 
> On Tue, 2021-08-10 at 17:58 +0800, Kate Hsuan wrote:
>> All the intel platform specific drivers are moved to intel/.
>> It makes more clear file structure to improve the readability.
>>
> 
> A lot of subfolders for single files. Is this necessary? I'm submitting
> a single driver soon, unrelated to anything else. I was just going to
> drop it in /intel.
> 

Ugh, surely not necessary. Not even desirable IMO.

Thanks for bringing that up.

> 
>> Kate Hsuan (20):
>>    Move Intel hid of pdx86 to intel directory to improve readability.
>>    Move Intel WMI driver of pdx86 to intel/ directory to improve
>>      readability.
>>    Move Intel bxtwc driver of pdx86 to intel/ directory to improve
>>      readability.
>>    Move Intel chtdc_ti driver of pdx86 to improve readability.
>>    Move MRFLD power button driver of pdx86 to intel directory to
>> improve
>>      readability.
>>    Move Intel PMC core of pdx86 to intel/ directory to improve
>>      readability.
>>    Move Intel PMT driver of pdx86 to intel/ to improve readability.
>>    Move Intel P-Unit of pdx86 to intel/ directory to improve
>> readability.
>>    Move Intel SCU IPC of pdx86 to intel directory to increase
>>      readability.
>>    Move Intel SoC telemetry driver to intel directory to improve
>>      readability.
>>    Move Intel IPS driver of pdx86 to improve readability.
>>    Move Intel RST driver of pdx86 to intel directory to improve
>>      readability.
>>    Move Intel smartconnect driver of pdx86 to intel/ directory to
>> improve
>>      readability.
>>    Move Intel SST driver to intel/ directory to improve readability.
>>    Move Intel turbo max 3 driver to intel/ directory to improve
>>      readability.
>>    Move Intel uncore freq driver to intel/ directory to improve
>>      readability.
>>    Move Intel int0002 vgpio driver to intel/ directory to inprove
>>      readability.
>>    Move Intel thermal driver for menlow platform driver to intel/
>>      directory to improve readability.
>>    Move OakTrail driver to the intel/ directory to improve
>> readability.
>>    Move Intel virtual botton driver to intel/ directory to improve
>>      readability.
>>
>>   drivers/platform/x86/Kconfig                  | 297 ----------------
>> --
>>   drivers/platform/x86/Makefile                 |  34 +-
>>   drivers/platform/x86/intel/Kconfig            |  21 ++
>>   drivers/platform/x86/intel/Makefile           |  31 ++
>>   drivers/platform/x86/intel/bxtwc/Kconfig      |  15 +
>>   drivers/platform/x86/intel/bxtwc/Makefile     |   6 +
>>   .../x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c   |   0
>>   drivers/platform/x86/intel/chtdc_ti/Kconfig   |  16 +
>>   drivers/platform/x86/intel/chtdc_ti/Makefile  |   7 +
>>   .../chtdc_ti}/intel_chtdc_ti_pwrbtn.c         |   0
>>   drivers/platform/x86/intel/hid/Kconfig        |  17 +
>>   drivers/platform/x86/intel/hid/Makefile       |   7 +
>>   .../platform/x86/{ => intel/hid}/intel-hid.c  |   0
>>   drivers/platform/x86/intel/int0002/Kconfig    |  23 ++
>>   drivers/platform/x86/intel/int0002/Makefile   |   6 +
>>   .../{ => intel/int0002}/intel_int0002_vgpio.c |   0
>>   .../{ => intel}/intel_speed_select_if/Kconfig |   0
>>   .../intel_speed_select_if/Makefile            |   0
>>   .../intel_speed_select_if/isst_if_common.c    |   0
>>   .../intel_speed_select_if/isst_if_common.h    |   0
>>   .../intel_speed_select_if/isst_if_mbox_msr.c  |   0
>>   .../intel_speed_select_if/isst_if_mbox_pci.c  |   0
>>   .../intel_speed_select_if/isst_if_mmio.c      |   0
>>   drivers/platform/x86/intel/ips/Kconfig        |  14 +
>>   drivers/platform/x86/intel/ips/Makefile       |   6 +
>>   .../platform/x86/{ => intel/ips}/intel_ips.c  |   0
>>   .../platform/x86/{ => intel/ips}/intel_ips.h  |   0
>>   drivers/platform/x86/intel/menlow/Kconfig     |  14 +
>>   drivers/platform/x86/intel/menlow/Makefile    |   6 +
>>   .../x86/{ => intel/menlow}/intel_menlow.c     |   0
>>   drivers/platform/x86/intel/mrfld/Kconfig      |  17 +
>>   drivers/platform/x86/intel/mrfld/Makefile     |   6 +
>>   .../{ => intel/mrfld}/intel_mrfld_pwrbtn.c    |   0
>>   drivers/platform/x86/intel/oaktrail/Kconfig   |  15 +
>>   drivers/platform/x86/intel/oaktrail/Makefile  |   6 +
>>   .../x86/{ => intel/oaktrail}/intel_oaktrail.c |   0
>>   drivers/platform/x86/intel/pmc_core/Kconfig   |  26 ++
>>   drivers/platform/x86/intel/pmc_core/Makefile  |   6 +
>>   .../x86/{ => intel/pmc_core}/intel_pmc_core.c |   0
>>   .../x86/{ => intel/pmc_core}/intel_pmc_core.h |   0
>>   .../pmc_core}/intel_pmc_core_pltdrv.c         |   0
>>   drivers/platform/x86/intel/pmt/Kconfig        |  41 +++
>>   drivers/platform/x86/intel/pmt/Makefile       |   9 +
>>   .../x86/{ => intel/pmt}/intel_pmt_class.c     |   0
>>   .../x86/{ => intel/pmt}/intel_pmt_class.h     |   0
>>   .../x86/{ => intel/pmt}/intel_pmt_crashlog.c  |   0
>>   .../x86/{ => intel/pmt}/intel_pmt_telemetry.c |   0
>>   drivers/platform/x86/intel/punit/Kconfig      |  10 +
>>   drivers/platform/x86/intel/punit/Makefile     |   6 +
>>   .../x86/{ => intel/punit}/intel_punit_ipc.c   |   0
>>   drivers/platform/x86/intel/rst/Kconfig        |  16 +
>>   drivers/platform/x86/intel/rst/Makefile       |   6 +
>>   .../platform/x86/{ => intel/rst}/intel-rst.c  |   0
>>   drivers/platform/x86/intel/scu/Kconfig        |  52 +++
>>   drivers/platform/x86/intel/scu/Makefile       |  11 +
>>   .../x86/{ => intel/scu}/intel_scu_ipc.c       |   0
>>   .../x86/{ => intel/scu}/intel_scu_ipcutil.c   |   0
>>   .../x86/{ => intel/scu}/intel_scu_pcidrv.c    |   0
>>   .../x86/{ => intel/scu}/intel_scu_pltdrv.c    |   0
>>   .../x86/{ => intel/scu}/intel_scu_wdt.c       |   0
>>   .../platform/x86/intel/smartconnect/Kconfig   |  18 ++
>>   .../platform/x86/intel/smartconnect/Makefile  |   6 +
>>   .../smartconnect}/intel-smartconnect.c        |   0
>>   drivers/platform/x86/intel/telemetry/Kconfig  |  16 +
>>   drivers/platform/x86/intel/telemetry/Makefile |   9 +
>>   .../telemetry}/intel_telemetry_core.c         |   0
>>   .../telemetry}/intel_telemetry_debugfs.c      |   0
>>   .../telemetry}/intel_telemetry_pltdrv.c       |   0
>>   .../platform/x86/intel/turbo_max_3/Kconfig    |  14 +
>>   .../platform/x86/intel/turbo_max_3/Makefile   |   6 +
>>   .../turbo_max_3}/intel_turbo_max_3.c          |   0
>>   .../platform/x86/intel/uncore_freq/Kconfig    |  15 +
>>   .../platform/x86/intel/uncore_freq/Makefile   |   6 +
>>   .../uncore_freq}/intel-uncore-frequency.c     |   0
>>   drivers/platform/x86/intel/vbtn/Kconfig       |  16 +
>>   drivers/platform/x86/intel/vbtn/Makefile      |   6 +
>>   .../x86/{ => intel/vbtn}/intel-vbtn.c         |   0
>>   drivers/platform/x86/intel/wmi/Kconfig        |  26 ++
>>   drivers/platform/x86/intel/wmi/Makefile       |   7 +
>>   .../{ => intel/wmi}/intel-wmi-sbl-fw-update.c |   0
>>   .../{ => intel/wmi}/intel-wmi-thunderbolt.c   |   0
>>   81 files changed, 562 insertions(+), 330 deletions(-)
>>   create mode 100644 drivers/platform/x86/intel/bxtwc/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/bxtwc/Makefile
>>   rename drivers/platform/x86/{ => intel/bxtwc}/intel_bxtwc_tmu.c
>> (100%)
>>   create mode 100644 drivers/platform/x86/intel/chtdc_ti/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/chtdc_ti/Makefile
>>   rename drivers/platform/x86/{ =>
>> intel/chtdc_ti}/intel_chtdc_ti_pwrbtn.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/hid/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/hid/Makefile
>>   rename drivers/platform/x86/{ => intel/hid}/intel-hid.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/int0002/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/int0002/Makefile
>>   rename drivers/platform/x86/{ =>
>> intel/int0002}/intel_int0002_vgpio.c (100%)
>>   rename drivers/platform/x86/{ =>
>> intel}/intel_speed_select_if/Kconfig (100%)
>>   rename drivers/platform/x86/{ =>
>> intel}/intel_speed_select_if/Makefile (100%)
>>   rename drivers/platform/x86/{ =>
>> intel}/intel_speed_select_if/isst_if_common.c (100%)
>>   rename drivers/platform/x86/{ =>
>> intel}/intel_speed_select_if/isst_if_common.h (100%)
>>   rename drivers/platform/x86/{ =>
>> intel}/intel_speed_select_if/isst_if_mbox_msr.c (100%)
>>   rename drivers/platform/x86/{ =>
>> intel}/intel_speed_select_if/isst_if_mbox_pci.c (100%)
>>   rename drivers/platform/x86/{ =>
>> intel}/intel_speed_select_if/isst_if_mmio.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/ips/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/ips/Makefile
>>   rename drivers/platform/x86/{ => intel/ips}/intel_ips.c (100%)
>>   rename drivers/platform/x86/{ => intel/ips}/intel_ips.h (100%)
>>   create mode 100644 drivers/platform/x86/intel/menlow/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/menlow/Makefile
>>   rename drivers/platform/x86/{ => intel/menlow}/intel_menlow.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/mrfld/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/mrfld/Makefile
>>   rename drivers/platform/x86/{ => intel/mrfld}/intel_mrfld_pwrbtn.c
>> (100%)
>>   create mode 100644 drivers/platform/x86/intel/oaktrail/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/oaktrail/Makefile
>>   rename drivers/platform/x86/{ => intel/oaktrail}/intel_oaktrail.c
>> (100%)
>>   create mode 100644 drivers/platform/x86/intel/pmc_core/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/pmc_core/Makefile
>>   rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core.c
>> (100%)
>>   rename drivers/platform/x86/{ => intel/pmc_core}/intel_pmc_core.h
>> (100%)
>>   rename drivers/platform/x86/{ =>
>> intel/pmc_core}/intel_pmc_core_pltdrv.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/pmt/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/pmt/Makefile
>>   rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_class.c (100%)
>>   rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_class.h (100%)
>>   rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_crashlog.c
>> (100%)
>>   rename drivers/platform/x86/{ => intel/pmt}/intel_pmt_telemetry.c
>> (100%)
>>   create mode 100644 drivers/platform/x86/intel/punit/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/punit/Makefile
>>   rename drivers/platform/x86/{ => intel/punit}/intel_punit_ipc.c
>> (100%)
>>   create mode 100644 drivers/platform/x86/intel/rst/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/rst/Makefile
>>   rename drivers/platform/x86/{ => intel/rst}/intel-rst.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/scu/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/scu/Makefile
>>   rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipc.c (100%)
>>   rename drivers/platform/x86/{ => intel/scu}/intel_scu_ipcutil.c
>> (100%)
>>   rename drivers/platform/x86/{ => intel/scu}/intel_scu_pcidrv.c
>> (100%)
>>   rename drivers/platform/x86/{ => intel/scu}/intel_scu_pltdrv.c
>> (100%)
>>   rename drivers/platform/x86/{ => intel/scu}/intel_scu_wdt.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/smartconnect/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/smartconnect/Makefile
>>   rename drivers/platform/x86/{ => intel/smartconnect}/intel-
>> smartconnect.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/telemetry/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/telemetry/Makefile
>>   rename drivers/platform/x86/{ =>
>> intel/telemetry}/intel_telemetry_core.c (100%)
>>   rename drivers/platform/x86/{ =>
>> intel/telemetry}/intel_telemetry_debugfs.c (100%)
>>   rename drivers/platform/x86/{ =>
>> intel/telemetry}/intel_telemetry_pltdrv.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/turbo_max_3/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/turbo_max_3/Makefile
>>   rename drivers/platform/x86/{ =>
>> intel/turbo_max_3}/intel_turbo_max_3.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/uncore_freq/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/uncore_freq/Makefile
>>   rename drivers/platform/x86/{ => intel/uncore_freq}/intel-uncore-
>> frequency.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/vbtn/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/vbtn/Makefile
>>   rename drivers/platform/x86/{ => intel/vbtn}/intel-vbtn.c (100%)
>>   create mode 100644 drivers/platform/x86/intel/wmi/Kconfig
>>   create mode 100644 drivers/platform/x86/intel/wmi/Makefile
>>   rename drivers/platform/x86/{ => intel/wmi}/intel-wmi-sbl-fw-
>> update.c (100%)
>>   rename drivers/platform/x86/{ => intel/wmi}/intel-wmi-thunderbolt.c
>> (100%)
>>
> 
> 


-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
https://people.kernel.org/tglx/notes-about-netiquette

      reply	other threads:[~2021-08-10 17:28 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10  9:58 [PATCH 00/20] Move Intel platform drivers to intel directory to improve readability Kate Hsuan
2021-08-10  9:58 ` [PATCH 01/20] Move Intel hid of pdx86 " Kate Hsuan
2021-08-10  9:58 ` [PATCH 02/20] Move Intel WMI driver of pdx86 to intel/ " Kate Hsuan
2021-08-10  9:58 ` [PATCH 03/20] Move Intel bxtwc " Kate Hsuan
2021-08-10  9:58 ` [PATCH 04/20] Move Intel chtdc_ti driver of pdx86 " Kate Hsuan
2021-08-10  9:58 ` [PATCH 05/20] Move MRFLD power button driver of pdx86 to intel directory " Kate Hsuan
2021-08-10  9:58 ` [PATCH 06/20] Move Intel PMC core of pdx86 to intel/ " Kate Hsuan
2021-08-10  9:58 ` [PATCH 07/20] Move Intel PMT driver of pdx86 to intel/ " Kate Hsuan
2021-08-10 16:51   ` David E. Box
2021-08-10  9:58 ` [PATCH 08/20] Move Intel P-Unit of pdx86 to intel/ directory " Kate Hsuan
2021-08-10 16:55   ` David E. Box
2021-08-11  5:43     ` Kate Hsuan
2021-08-10  9:58 ` [PATCH 09/20] Move Intel SCU IPC of pdx86 to intel directory to increase readability Kate Hsuan
2021-08-10 10:05   ` Mika Westerberg
2021-08-10 11:43     ` Kate Hsuan
2021-08-10 13:27       ` Andy Shevchenko
2021-08-10  9:58 ` [PATCH 10/20] Move Intel SoC telemetry driver to intel directory to improve readability Kate Hsuan
2021-08-10  9:58 ` [PATCH 11/20] Move Intel IPS driver of pdx86 " Kate Hsuan
2021-08-10  9:58 ` [PATCH 12/20] Move Intel RST driver of pdx86 to intel directory " Kate Hsuan
2021-08-10  9:58 ` [PATCH 13/20] Move Intel smartconnect driver of pdx86 to intel/ " Kate Hsuan
2021-08-10  9:58 ` [PATCH 14/20] Move Intel SST driver " Kate Hsuan
2021-08-10  9:58 ` [PATCH 15/20] Move Intel turbo max 3 " Kate Hsuan
2021-08-10  9:58 ` [PATCH 16/20] Move Intel uncore freq " Kate Hsuan
2021-08-10  9:58 ` [PATCH 17/20] Move Intel int0002 vgpio driver to intel/ directory to inprove readability Kate Hsuan
2021-08-10  9:58 ` [PATCH 18/20] Move Intel thermal driver for menlow platform driver to intel/ directory to improve readability Kate Hsuan
2021-08-14 10:39   ` Daniel Lezcano
2021-08-15 14:08     ` Hans de Goede
2021-08-16  3:11       ` Pandruvada, Srinivas
2021-08-16  7:40         ` Hans de Goede
2021-08-16  7:43           ` Kate Hsuan
2021-08-10  9:58 ` [PATCH 19/20] Move OakTrail driver to the " Kate Hsuan
2021-08-10  9:58 ` [PATCH 20/20] Move Intel virtual botton driver to " Kate Hsuan
2021-08-10 13:23 ` [PATCH 00/20] Move Intel platform drivers to intel " Andy Shevchenko
2021-08-11 12:41   ` Andy Shevchenko
2021-08-10 14:05 ` Hans de Goede
2021-08-11  9:06   ` Kate Hsuan
2021-08-10 17:03 ` David E. Box
2021-08-10 17:28   ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6a90704-5080-d479-0022-58e5d106c026@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=acelan.kao@canonical.com \
    --cc=alex.hung@canonical.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=david.e.box@intel.com \
    --cc=david.e.box@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=hpa@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=jithu.joseph@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maurice.ma@intel.com \
    --cc=mgross@linux.intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=qipeng.zha@intel.com \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=sujith.thomas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).