From: Arvid Norlander <lkml@vorpal.se>
To: Hans de Goede <hdegoede@redhat.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Mark Gross <mgross@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drivers/platform: toshiba_acpi: Call HCI_PANEL_POWER_ON on resume on some models
Date: Fri, 9 Sep 2022 20:32:43 +0200 [thread overview]
Message-ID: <de8a1f37-414d-3a06-0b56-54b0daa4a250@vorpal.se> (raw)
In-Reply-To: <cc8ae460-9ebd-6c47-a938-eb515ce42104@redhat.com>
Hi,
On 2022-09-09 19:42, Hans de Goede wrote:
> Hi,
>
> On 9/9/22 19:29, Arvid Norlander wrote:
>> Hi,
>>
>> Given the changes, do you want me to test this again? If so, on what branch?
>
> I have just pushed this new version + all your pending toshiba_acpi patches
> to my review-hans branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans\
>
> If you can give this branch a quick test and let me know if everything works
> as expected that would be great.
My changes (battery charge threshold, fan HWMON support, ECO LED work as
expected.
Display does come on after resume. Unfortunately the computer also
completely locks up (I can't even switch from X to a VT). SSH is dead.
When I suspend with a VT active the cursor is no longer blinking on resume.
So something else is severly broken in this version and I cannot fully test
this.
I notice your tree is based on rc1. I was previously testing with 5.19 as
well as rc2 and newer. Is it possible this is a bug from mainline? Or is
it something introduced by your tree? I'm wondering it it would be easier
to first rebase your tree on the latest RC rather than trying to bisect it
as is.
Or the easiest test is perhaps: Does suspend and resume with this tree work
on your computer? I remember hearing that there were SATA issues in early
6.0-rcs (don't remember the details), the Toshiba uses mSATA.
>
> Thanks,
>
> Hans
>
<snip>
Best regards,
Arvid Norlander
next prev parent reply other threads:[~2022-09-09 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 15:32 [PATCH v2 1/2] drivers/platform: toshiba_acpi: Call HCI_PANEL_POWER_ON on resume on some models Hans de Goede
2022-09-09 15:32 ` [PATCH v2 2/2] ACPI: video: Change disable_backlight_sysfs_if quirks to acpi_backlight=native Hans de Goede
2022-09-09 17:29 ` [PATCH v2 1/2] drivers/platform: toshiba_acpi: Call HCI_PANEL_POWER_ON on resume on some models Arvid Norlander
2022-09-09 17:42 ` Hans de Goede
2022-09-09 18:32 ` Arvid Norlander [this message]
2022-09-09 19:20 ` Hans de Goede
2022-09-09 19:44 ` Arvid Norlander
2022-09-09 17:41 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de8a1f37-414d-3a06-0b56-54b0daa4a250@vorpal.se \
--to=lkml@vorpal.se \
--cc=andy@infradead.org \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).