qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Joel Stanley <joel@jms.id.au>,
	Peter Maydell <peter.maydell@linaro.org>,
	Andrew Jeffery <andrew@aj.id.au>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/4] watchdog/aspeed: Improve watchdog timeout message
Date: Tue, 12 Nov 2019 08:52:12 +0100	[thread overview]
Message-ID: <036a1f38-6258-fad0-bc45-0e3cfe0a93b7@kaod.org> (raw)
In-Reply-To: <20191112064058.13275-4-joel@jms.id.au>

On 12/11/2019 07:40, Joel Stanley wrote:
> Users benefit from knowing which watchdog timer has expired. The address
> of the watchdog's registers unambiguously indicates which has expired,
> so log that.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>


The format below should be using HWADDR_PRIx. No need to resend. 
I will fix it. 

Reviewed-by: Cédric Le Goater <clg@kaod.org>

C. 

> ---
>  hw/watchdog/wdt_aspeed.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c
> index 145be6f99ce2..5697ed83325a 100644
> --- a/hw/watchdog/wdt_aspeed.c
> +++ b/hw/watchdog/wdt_aspeed.c
> @@ -219,7 +219,8 @@ static void aspeed_wdt_timer_expired(void *dev)
>          return;
>      }
>  
> -    qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n");
> +    qemu_log_mask(CPU_LOG_RESET, "Watchdog timer %08lx expired.\n",
> +            s->iomem.addr);
>      watchdog_perform_action();
>      timer_del(s->timer);
>  }
> 



  reply	other threads:[~2019-11-12  7:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  6:40 [PATCH 0/4] arm/aspeed: Watchdog and SDRAM fixes Joel Stanley
2019-11-12  6:40 ` [PATCH 1/4] aspeed/sdmc: Make ast2600 default 1G Joel Stanley
2019-11-12  7:45   ` Cédric Le Goater
2019-11-12  6:40 ` [PATCH 2/4] aspeed/scu: Fix W1C behavior Joel Stanley
2019-11-12  7:45   ` Cédric Le Goater
2019-11-12  6:40 ` [PATCH 3/4] watchdog/aspeed: Improve watchdog timeout message Joel Stanley
2019-11-12  7:52   ` Cédric Le Goater [this message]
2019-11-12  6:40 ` [PATCH 4/4] watchdog/aspeed: Fix AST2600 frequency behaviour Joel Stanley
2019-11-12  7:56   ` Cédric Le Goater
2019-11-13  0:48     ` Joel Stanley
2019-11-12 15:05 ` [PATCH 0/4] arm/aspeed: Watchdog and SDRAM fixes no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=036a1f38-6258-fad0-bc45-0e3cfe0a93b7@kaod.org \
    --to=clg@kaod.org \
    --cc=andrew@aj.id.au \
    --cc=joel@jms.id.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).