From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@gmail.com>, qemu-devel@nongnu.org
Cc: dovgaluk@ispras.ru, pavel.dovgaluk@ispras.ru
Subject: Re: [PATCH] replay: synchronize on every virtual timer callback
Date: Thu, 21 May 2020 15:22:40 +0200 [thread overview]
Message-ID: <0a778b07-3d20-90f3-9b8e-69f035c6f11b@redhat.com> (raw)
In-Reply-To: <158875304273.3986.105601155554744438.stgit@pasha-ThinkPad-X280>
On 06/05/20 10:17, Pavel Dovgalyuk wrote:
> Sometimes virtual timer callbacks depend on order
> of virtual timer processing and warping of virtual clock.
> Therefore every callback should be logged to make replay deterministic.
> This patch creates a checkpoint before every virtual timer callback.
> With these checkpoints virtual timers processing and clock warping
> events order is completely deterministic.
>
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
> ---
> util/qemu-timer.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/util/qemu-timer.c b/util/qemu-timer.c
> index d548d3c1ad..47833f338f 100644
> --- a/util/qemu-timer.c
> +++ b/util/qemu-timer.c
> @@ -588,6 +588,11 @@ bool timerlist_run_timers(QEMUTimerList *timer_list)
> qemu_mutex_lock(&timer_list->active_timers_lock);
>
> progress = true;
> + /*
> + * Callback may insert new checkpoints, therefore add new checkpoint
> + * for the virtual timers.
> + */
> + need_replay_checkpoint = timer_list->clock->type == QEMU_CLOCK_VIRTUAL;
You need to check replay_mode != REPLAY_MODE_NONE, either here or in the
"if (need_replay_checkpoint)" above. If you choose the latter, you can
remove the other "if (replay_mode != REPLAY_MODE_NONE)".
Also, there is a comment that says that checkpointing "must only be done
once since the clock value stays the same". Is that actually a "can"
rather than a "must"? Should the central replay logic have something
like a checkpoint count, that prevents adding back-to-back equal
checkpoints?
Thanks,
Paolo
> }
> qemu_mutex_unlock(&timer_list->active_timers_lock);
>
>
next prev parent reply other threads:[~2020-05-21 13:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 8:17 [PATCH] replay: synchronize on every virtual timer callback Pavel Dovgalyuk
2020-05-18 10:58 ` Pavel Dovgalyuk
2020-05-18 11:24 ` Philippe Mathieu-Daudé
2020-05-18 15:56 ` Alex Bennée
2020-05-19 5:56 ` Pavel Dovgalyuk
2020-05-19 8:11 ` Alex Bennée
2020-05-19 10:21 ` Pavel Dovgalyuk
2020-05-19 10:32 ` Alex Bennée
2020-05-19 10:38 ` Pavel Dovgalyuk
2020-05-19 15:42 ` Philippe Mathieu-Daudé
2020-05-20 6:54 ` Pavel Dovgalyuk
2020-05-20 7:18 ` Philippe Mathieu-Daudé
2020-05-20 10:46 ` Pavel Dovgalyuk
2020-05-21 13:22 ` Paolo Bonzini [this message]
2020-05-22 6:39 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a778b07-3d20-90f3-9b8e-69f035c6f11b@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@gmail.com \
--cc=dovgaluk@ispras.ru \
--cc=pavel.dovgaluk@ispras.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).