From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH for-6.0 0/4] Don't treat all sysbus devices as hotpluggable
Date: Thu, 25 Mar 2021 20:51:21 +0000 [thread overview]
Message-ID: <0fe1a06d-1223-741d-17b3-f8a447935bd1@ilande.co.uk> (raw)
In-Reply-To: <20210325153310.9131-1-peter.maydell@linaro.org>
On 25/03/2021 15:33, Peter Maydell wrote:
> On the two machines which have the "platform bus" (ppc e500 and arm
> virt) we currently treat all TYPE_SYS_BUS_DEVICE devices as being
> hotpluggable in the device callbacks, and try to plug those devices
> into the platform bus. This is far too broad, because only a handful
> of devices are actually valid to plug into the platform bus.
> Moreover, if a device which is pluggable for some other reason (like
> a PCI device) happens to use a sysbus device internally as part of
> its implementation, the hotplug callback will incorrectly grab that
> sysbus device, probably resulting in an assertion failure.
>
> Mostly PCI devices don't use sysbus devices internally, so the only
> case we've encountered so far is the not-valid-anyway
> qemu-system-ppc64 -M ppce500 -device macio-oldworld
> but we might create more in future.
>
> This series restricts hotpluggability of sysbus devices on these
> platforms to those devices which are on the dynamic sysbus whitelist
> (which we were maintaining anyway). With it, the above ppc
> commandline stops asserting and instead fails cleanly with
> qemu-system-ppc64: Device heathrow is not supported by this machine yet.
>
> Patch 1 is an API doc improvement while I was in the header file
> anyway.
>
> thanks
> -- PMM
>
> Peter Maydell (4):
> include/hw/boards.h: Document machine_class_allow_dynamic_sysbus_dev()
> machine: Provide a function to check the dynamic sysbus whitelist
> hw/arm/virt: Only try to add valid dynamic sysbus devices to platform
> bus
> hw/ppc/e500plat: Only try to add valid dynamic sysbus devices to
> platform bus
>
> include/hw/boards.h | 38 ++++++++++++++++++++++++++++++++++++++
> hw/arm/virt.c | 8 ++++++--
> hw/core/machine.c | 21 ++++++++++++++++-----
> hw/ppc/e500plat.c | 8 ++++++--
> 4 files changed, 66 insertions(+), 9 deletions(-)
Looks good to me having been poking around the code earlier today so:
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
ATB,
Mark.
next prev parent reply other threads:[~2021-03-25 20:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 15:33 [PATCH for-6.0 0/4] Don't treat all sysbus devices as hotpluggable Peter Maydell
2021-03-25 15:33 ` [PATCH for-6.0 1/4] include/hw/boards.h: Document machine_class_allow_dynamic_sysbus_dev() Peter Maydell
2021-03-26 9:27 ` Auger Eric
2021-03-26 10:20 ` Peter Maydell
2021-03-26 10:26 ` Auger Eric
2021-03-25 15:33 ` [PATCH for-6.0 2/4] machine: Provide a function to check the dynamic sysbus whitelist Peter Maydell
2021-03-26 9:35 ` Auger Eric
2021-03-25 15:33 ` [PATCH for-6.0 3/4] hw/arm/virt: Only try to add valid dynamic sysbus devices to platform bus Peter Maydell
2021-03-26 9:38 ` Auger Eric
2021-03-25 15:33 ` [PATCH for-6.0 4/4] hw/ppc/e500plat: " Peter Maydell
2021-03-25 22:48 ` David Gibson
2021-03-26 9:39 ` Auger Eric
2021-03-25 17:23 ` [PATCH for-6.0 0/4] Don't treat all sysbus devices as hotpluggable Richard Henderson
2021-03-25 20:51 ` Mark Cave-Ayland [this message]
2021-04-04 16:20 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe1a06d-1223-741d-17b3-f8a447935bd1@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).