Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing

From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
	"Huang Rui" <ray.huang@amd.com>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Anthony PERARD" <anthony.perard@citrix.com>,
	"Antonio Caggiano" <quic_acaggian@quicinc.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	"Robert Beckett" <bob.beckett@collabora.com>,
	"Gert Wollny" <gert.wollny@collabora.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	ernunes@redhat.com, "Alyssa Ross" <hi@alyssa.is>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Stefano Stabellini" <stefano.stabellini@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Xenia Ragiadakou" <xenia.ragiadakou@amd.com>,
	"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
	"Honglei Huang" <honglei1.huang@amd.com>,
	"Julia Zhang" <julia.zhang@amd.com>,
	"Chen Jiqian" <Jiqian.Chen@amd.com>,
	"Yiwei Zhang" <zzyiwei@chromium.org>
Subject: Re: [PATCH v8 07/11] virtio-gpu: Support suspension of commands processing
Date: Sat, 27 Apr 2024 14:48:10 +0900	[thread overview]
Message-ID: <10337ba0-70ce-436c-9cac-398851ebdfc9@daynix.com> (raw)
In-Reply-To: <4c6b3ca0-4813-48f4-87f8-a94e911c02d3@collabora.com>

On 2024/04/24 18:43, Dmitry Osipenko wrote:
> On 4/19/24 11:53, Akihiko Odaki wrote:
>> On 2024/04/19 4:00, Dmitry Osipenko wrote:
>>> Add new "suspended" flag to virtio_gpu_ctrl_command telling cmd
>>> processor that it should stop processing commands and retry again
>>> next time until flag is unset.
>>>
>>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>
>> This flag shouldn't be added to virtio_gpu_ctrl_command. suspended is
>> just !finished in virtio-gpu.c. Only virtio_gpu_virgl_process_cmd()
>> needs the distinction of suspended and !finished so it is not
>> appropriate to add this flag the common structure.
> 
> The VIRTIO_GPU_FILL_CMD() macro returns void and this macro is used by
> every function processing commands. Changing process_cmd() to return
> bool will require to change all those functions. Not worthwhile to
> change it, IMO. >
> The flag reflects the exact command status. The !finished + !suspended
> means that command is fenced, i.e. these flags don't have exactly same
> meaning.

It is not necessary to change the signature of process_cmd(). You can 
just refer to !finished. No need to have the suspended flag.

> 
> I'd keep the flag if there are no better suggestions.
> 