qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: ysato@users.sourceforge.jp
Cc: peter.maydell@linaro.org, ysato@users.sourceforge.jp,
	richard.henderson@linaro.org, qemu-devel@nongnu.org,
	imammedo@redhat.com, philmd@redhat.com
Subject: Re: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support
Date: Wed, 11 Sep 2019 23:39:39 -0700 (PDT)	[thread overview]
Message-ID: <156827037800.21839.7329409440899723100@5dec9699b7de> (raw)
In-Reply-To: <20190912060701.4642-1-ysato@users.sourceforge.jp>

Patchew URL: https://patchew.org/QEMU/20190912060701.4642-1-ysato@users.sourceforge.jp/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support
Message-id: 20190912060701.4642-1-ysato@users.sourceforge.jp
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20190912060701.4642-1-ysato@users.sourceforge.jp -> patchew/20190912060701.4642-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
c7211ec qapi/machine.json: Add RX cpu.
0a60bc1 BootLinuxConsoleTest: Test the RX-Virt machine
21ccd2b Add rx-softmmu
53b5a3e hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
100e307 hw/rx: Honor -accel qtest
4737268 hw/rx: RX Target hardware definition
6d1d3f2 hw/char: RX62N serial communication interface (SCI)
96aa2bf hw/timer: RX62N internal timer modules
54ced3e hw/intc: RX62N interrupt controller (ICUa)
3200a28 target/rx: Dump bytes for each insn during disassembly
a254a82 target/rx: Collect all bytes during disassembly
5f7675e target/rx: Emit all disassembly in one prt()
04b3639 target/rx: Use prt_ldmi for XCHG_mr disassembly
b58c020 target/rx: Replace operand with prt_ldmi in disassembler
9217628 target/rx: Disassemble rx_index_addr into a string
e4f57d2 target/rx: RX disassembler
702f27d target/rx: CPU definition
8abda61 target/rx: TCG helper
ba2df21 target/rx: TCG translation
9201c38 hw/registerfields.h: Add 8bit and 16bit register macros
a1dbe53 qemu/bitops.h: Add extract8 and extract16
7b0a56f MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 7b0a56f73866 (MAINTAINERS: Add RX)
2/22 Checking commit a1dbe53d2434 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 9201c38b0287 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2484.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit ba2df2186230 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 8abda6115755 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 702f27d78dde (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 588 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit e4f57d2f27c6 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 9217628e8446 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit b58c020a513e (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit 04b36390113a (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 5f7675ee892f (target/rx: Emit all disassembly in one prt())
12/22 Checking commit a254a827a9c5 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 3200a284e4a4 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 54ced3e375a8 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 96aa2bf733b4 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 6d1d3f22147c (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 401 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 4737268c2023 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 480 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 100e307f42ee (hw/rx: Honor -accel qtest)
19/22 Checking commit 53b5a3ea7549 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 21ccd2b57887 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

total: 0 errors, 1 warnings, 59 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 0a60bc15b465 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit c7211ec79d66 (qapi/machine.json: Add RX cpu.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190912060701.4642-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2019-09-12  7:27 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12  6:06 [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 01/22] MAINTAINERS: Add RX Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 02/22] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 03/22] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 04/22] target/rx: TCG translation Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 05/22] target/rx: TCG helper Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 06/22] target/rx: CPU definition Yoshinori Sato
2019-09-23 15:49   ` Philippe Mathieu-Daudé
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 07/22] target/rx: RX disassembler Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 08/22] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 09/22] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 10/22] target/rx: Use prt_ldmi for XCHG_mr disassembly Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 11/22] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 12/22] target/rx: Collect all bytes during disassembly Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 13/22] target/rx: Dump bytes for each insn " Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 14/22] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 15/22] hw/timer: RX62N internal timer modules Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 16/22] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 17/22] hw/rx: RX Target hardware definition Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 18/22] hw/rx: Honor -accel qtest Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 19/22] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2019-09-12  6:06 ` [Qemu-devel] [PATCH v24 20/22] Add rx-softmmu Yoshinori Sato
2019-09-12  6:07 ` [Qemu-devel] [PATCH v24 21/22] BootLinuxConsoleTest: Test the RX-Virt machine Yoshinori Sato
2019-09-12  6:07 ` [Qemu-devel] [PATCH v24 22/22] qapi/machine.json: Add RX cpu Yoshinori Sato
2019-09-20 12:39   ` Eric Blake
2019-09-12  6:39 ` no-reply [this message]
2019-09-12  7:47 ` [Qemu-devel] [PATCH v24 00/22] Add RX archtecture support no-reply
2019-09-12  9:18 ` no-reply
2019-09-12  9:40 ` no-reply
2019-09-12 10:30 ` no-reply
2019-09-12 11:09 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=156827037800.21839.7329409440899723100@5dec9699b7de \
    --to=no-reply@patchew.org \
    --cc=imammedo@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).