qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: laurent@vivier.eu
Cc: riku.voipio@iki.fi, mark.cave-ayland@ilande.co.uk,
	qemu-devel@nongnu.org, laurent@vivier.eu, alex.bennee@linaro.org,
	atar4qemu@gmail.com
Subject: Re: [PULL v2 00/13] Linux user for 4.2 patches
Date: Wed, 6 Nov 2019 11:10:35 -0800 (PST)	[thread overview]
Message-ID: <157306743367.21358.12293983229221302772@37313f22b938> (raw)
In-Reply-To: <20191106130456.6176-1-laurent@vivier.eu>

Patchew URL: https://patchew.org/QEMU/20191106130456.6176-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL v2 00/13] Linux user for 4.2 patches
Type: series
Message-id: 20191106130456.6176-1-laurent@vivier.eu

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   2dd8fd6..4570c2e  master     -> master
 - [tag update]      patchew/20191018004850.9888-1-richardw.yang@linux.intel.com -> patchew/20191018004850.9888-1-richardw.yang@linux.intel.com
Switched to a new branch 'test'
66eeef8 linux-user/alpha: Set r20 secondary return value
752ee6e linux-user/sparc: Fix cpu_clone_regs_*
205ab4e linux-user: Introduce cpu_clone_regs_parent
e116815 linux-user: Rename cpu_clone_regs to cpu_clone_regs_child
e331e5c linux-user/sparc64: Fix target_signal_frame
0a9f44c linux-user/sparc: Fix WREG usage in setup_frame
39220db linux-user/sparc: Use WREG_SP constant in sparc/signal.c
54f43cd linux-user/sparc: Begin using WREG constants in sparc/signal.c
41f1345 linux-user/sparc: Use WREG constants in sparc/target_cpu.h
084e4ce target/sparc: Define an enumeration for accessing env->regwptr
8da1545 tests/tcg/multiarch/linux-test: Fix error check for shmat
29f529a scripts/qemu-binfmt-conf: Update for sparc64
ccdaa08 linux-user: Support for NETLINK socket options

=== OUTPUT BEGIN ===
1/13 Checking commit ccdaa088dec3 (linux-user: Support for NETLINK socket options)
2/13 Checking commit 29f529a599f1 (scripts/qemu-binfmt-conf: Update for sparc64)
WARNING: line over 80 characters
#36: FILE: scripts/qemu-binfmt-conf.sh:41:
+sparc64_magic='\x7fELF\x02\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x2b'

ERROR: line over 90 characters
#37: FILE: scripts/qemu-binfmt-conf.sh:42:
+sparc64_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 1 errors, 1 warnings, 20 lines checked

Patch 2/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/13 Checking commit 8da15455f6f6 (tests/tcg/multiarch/linux-test: Fix error check for shmat)
4/13 Checking commit 084e4ce785d7 (target/sparc: Define an enumeration for accessing env->regwptr)
5/13 Checking commit 41f1345f4116 (linux-user/sparc: Use WREG constants in sparc/target_cpu.h)
6/13 Checking commit 54f43cd1635a (linux-user/sparc: Begin using WREG constants in sparc/signal.c)
7/13 Checking commit 39220db616ca (linux-user/sparc: Use WREG_SP constant in sparc/signal.c)
8/13 Checking commit 0a9f44c7244a (linux-user/sparc: Fix WREG usage in setup_frame)
9/13 Checking commit e331e5c5689d (linux-user/sparc64: Fix target_signal_frame)
10/13 Checking commit e1168157fac4 (linux-user: Rename cpu_clone_regs to cpu_clone_regs_child)
11/13 Checking commit 205ab4e6001d (linux-user: Introduce cpu_clone_regs_parent)
12/13 Checking commit 752ee6ec2302 (linux-user/sparc: Fix cpu_clone_regs_*)
13/13 Checking commit 66eeef8f89f7 (linux-user/alpha: Set r20 secondary return value)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20191106130456.6176-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

  parent reply	other threads:[~2019-11-06 19:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 13:04 [PULL v2 00/13] Linux user for 4.2 patches Laurent Vivier
2019-11-06 13:04 ` [PULL v2 01/13] linux-user: Support for NETLINK socket options Laurent Vivier
2019-11-12 10:11   ` Peter Maydell
2019-11-12 10:30     ` Laurent Vivier
2019-11-06 13:04 ` [PULL v2 02/13] scripts/qemu-binfmt-conf: Update for sparc64 Laurent Vivier
2019-11-06 13:04 ` [PULL v2 03/13] tests/tcg/multiarch/linux-test: Fix error check for shmat Laurent Vivier
2019-11-06 13:04 ` [PULL v2 04/13] target/sparc: Define an enumeration for accessing env->regwptr Laurent Vivier
2019-11-06 13:04 ` [PULL v2 05/13] linux-user/sparc: Use WREG constants in sparc/target_cpu.h Laurent Vivier
2019-11-06 13:04 ` [PULL v2 06/13] linux-user/sparc: Begin using WREG constants in sparc/signal.c Laurent Vivier
2019-11-06 13:04 ` [PULL v2 07/13] linux-user/sparc: Use WREG_SP constant " Laurent Vivier
2019-11-06 13:04 ` [PULL v2 08/13] linux-user/sparc: Fix WREG usage in setup_frame Laurent Vivier
2019-11-06 13:04 ` [PULL v2 09/13] linux-user/sparc64: Fix target_signal_frame Laurent Vivier
2019-11-06 13:04 ` [PULL v2 10/13] linux-user: Rename cpu_clone_regs to cpu_clone_regs_child Laurent Vivier
2019-11-06 13:04 ` [PULL v2 11/13] linux-user: Introduce cpu_clone_regs_parent Laurent Vivier
2019-11-06 13:04 ` [PULL v2 12/13] linux-user/sparc: Fix cpu_clone_regs_* Laurent Vivier
2019-11-06 13:04 ` [PULL v2 13/13] linux-user/alpha: Set r20 secondary return value Laurent Vivier
2019-11-06 19:10 ` no-reply [this message]
2019-11-06 22:04 ` [PULL v2 00/13] Linux user for 4.2 patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=157306743367.21358.12293983229221302772@37313f22b938 \
    --to=no-reply@patchew.org \
    --cc=alex.bennee@linaro.org \
    --cc=atar4qemu@gmail.com \
    --cc=laurent@vivier.eu \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).