qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: thuth@redhat.com, armbru@redhat.com
Subject: [PATCH 01/16] memory: do not look at current_machine->accel
Date: Wed, 13 Nov 2019 15:38:50 +0100	[thread overview]
Message-ID: <1573655945-14912-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1573655945-14912-1-git-send-email-pbonzini@redhat.com>

"info mtree" prints the wrong accelerator name if used with for example
"-machine accel=kvm:tcg".  The right thing to do is to fetch the name
from the AccelClass, which will also work nicely once
current_machine->accel stops existing.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 memory.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/memory.c b/memory.c
index c952eab..1764af8 100644
--- a/memory.c
+++ b/memory.c
@@ -2986,7 +2986,6 @@ struct FlatViewInfo {
     bool dispatch_tree;
     bool owner;
     AccelClass *ac;
-    const char *ac_name;
 };
 
 static void mtree_print_flatview(gpointer key, gpointer value,
@@ -3056,7 +3055,7 @@ static void mtree_print_flatview(gpointer key, gpointer value,
                 if (fvi->ac->has_memory(current_machine, as,
                                         int128_get64(range->addr.start),
                                         MR_SIZE(range->addr.size) + 1)) {
-                    qemu_printf(" %s", fvi->ac_name);
+                    qemu_printf(" %s", fvi->ac->name);
                 }
             }
         }
@@ -3104,8 +3103,6 @@ void mtree_info(bool flatview, bool dispatch_tree, bool owner)
 
         if (ac->has_memory) {
             fvi.ac = ac;
-            fvi.ac_name = current_machine->accel ? current_machine->accel :
-                object_class_get_name(OBJECT_CLASS(ac));
         }
 
         /* Gather all FVs in one table */
-- 
1.8.3.1




  reply	other threads:[~2019-11-13 14:40 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 14:38 [PATCH for-5.0 00/16] Complete the implementation of -accel Paolo Bonzini
2019-11-13 14:38 ` Paolo Bonzini [this message]
2019-11-14  8:56   ` [PATCH 01/16] memory: do not look at current_machine->accel Marc-André Lureau
2019-11-14  9:27     ` Paolo Bonzini
2019-11-14  9:31       ` Marc-André Lureau
2019-11-14  9:10   ` Thomas Huth
2019-11-14  9:35     ` Paolo Bonzini
2019-11-14  9:46       ` Thomas Huth
2019-11-14 10:21       ` Peter Maydell
2019-11-14 10:32         ` Paolo Bonzini
2019-11-14 10:40           ` Peter Maydell
2019-11-14 10:47             ` Paolo Bonzini
2019-11-13 14:38 ` [PATCH 02/16] vl: extract accelerator option processing to a separate function Paolo Bonzini
2019-11-14  7:55   ` Marc-André Lureau
2019-11-14  9:29     ` Paolo Bonzini
2019-11-18 10:58   ` Thomas Huth
2019-11-18 11:39     ` Paolo Bonzini
2019-11-13 14:38 ` [PATCH 03/16] vl: merge -accel processing into configure_accelerators Paolo Bonzini
2019-11-14  8:13   ` Marc-André Lureau
2019-11-18 11:27   ` Thomas Huth
2019-11-18 11:39     ` Paolo Bonzini
2019-11-18 15:12   ` Wainer dos Santos Moschetta
2019-11-13 14:38 ` [PATCH 04/16] vl: move icount configuration earlier Paolo Bonzini
2019-11-14  8:24   ` Marc-André Lureau
2019-11-18 11:53   ` Thomas Huth
2019-11-13 14:38 ` [PATCH 05/16] vl: introduce object_parse_property_opt Paolo Bonzini
2019-11-14  8:23   ` Marc-André Lureau
2019-11-14  9:46     ` Paolo Bonzini
2019-11-13 14:38 ` [PATCH 06/16] vl: configure accelerators from -accel options Paolo Bonzini
2019-11-18 17:59   ` Wainer dos Santos Moschetta
2019-11-13 14:38 ` [PATCH 07/16] vl: warn for unavailable accelerators, clarify messages Paolo Bonzini
2019-11-14  9:28   ` Marc-André Lureau
2019-11-13 14:38 ` [PATCH 08/16] qom: introduce object_register_sugar_prop Paolo Bonzini
2019-11-14  9:53   ` Marc-André Lureau
2019-11-14 10:03     ` Paolo Bonzini
2019-11-13 14:38 ` [PATCH 09/16] qom: add object_new_with_class Paolo Bonzini
2019-11-14  9:56   ` Marc-André Lureau
2019-11-13 14:38 ` [PATCH 10/16] accel: pass object to accel_init_machine Paolo Bonzini
2019-11-14 10:48   ` Marc-André Lureau
2019-11-13 14:39 ` [PATCH 11/16] tcg: convert "-accel threads" to a QOM property Paolo Bonzini
2019-11-14 11:08   ` Marc-André Lureau
2019-11-13 14:39 ` [PATCH 12/16] tcg: add "-accel tcg,tb-size" and deprecate "-tb-size" Paolo Bonzini
2019-11-19 10:44   ` Thomas Huth
2019-11-13 14:39 ` [PATCH 13/16] xen: convert "-machine igd-passthru" to an accelerator property Paolo Bonzini
2019-11-14  9:39   ` Paul Durrant
2019-11-14  9:47     ` Paolo Bonzini
2019-11-14  9:52       ` Paul Durrant
2019-11-19 11:02   ` Thomas Huth
2019-11-13 14:39 ` [PATCH 14/16] kvm: convert "-machine kvm_shadow_mem" " Paolo Bonzini
2019-11-19 11:33   ` Thomas Huth
2019-11-13 14:39 ` [PATCH 15/16] kvm: introduce kvm_kernel_irqchip_* functions Paolo Bonzini
2019-11-19 11:56   ` Thomas Huth
2019-11-19 12:13     ` Paolo Bonzini
2019-11-19 12:22       ` Thomas Huth
2019-11-13 14:39 ` [PATCH 16/16] kvm: convert "-machine kernel_irqchip" to an accelerator property Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573655945-14912-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).