From: no-reply@patchew.org
To: mhartmay@linux.ibm.com
Cc: berrange@redhat.com, mst@redhat.com, cohuck@redhat.com,
qemu-devel@nongnu.org, dgilbert@redhat.com, pasic@linux.ibm.com,
stefanha@redhat.com, marcandre.lureau@redhat.com
Subject: Re: [RFC v2 0/3] Enable virtio-fs on s390x
Date: Fri, 17 Jul 2020 03:26:45 -0700 (PDT) [thread overview]
Message-ID: <159498160510.17162.14939030906063593858@07a7f0d89f7d> (raw)
In-Reply-To: <20200717092929.19453-1-mhartmay@linux.ibm.com>
Patchew URL: https://patchew.org/QEMU/20200717092929.19453-1-mhartmay@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200717092929.19453-1-mhartmay@linux.ibm.com
Subject: [RFC v2 0/3] Enable virtio-fs on s390x
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
a6d1b6d libvhost-user: fence legacy virtio devices
968857c libvhost-user: handle endianness as mandated by the spec
2c7bd4b virtio: add vhost-user-fs-ccw device
=== OUTPUT BEGIN ===
1/3 Checking commit 2c7bd4bc5216 (virtio: add vhost-user-fs-ccw device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#25:
new file mode 100644
ERROR: space required after that ',' (ctx:VxV)
#85: FILE: hw/s390x/vhost-user-fs-ccw.c:56:
+ device_class_set_props(dc,vhost_user_fs_ccw_properties);
^
total: 1 errors, 1 warnings, 80 lines checked
Patch 1/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit 968857cfd9be (libvhost-user: handle endianness as mandated by the spec)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29:
new file mode 100644
ERROR: braces {} are necessary for all arms of this statement
#75: FILE: contrib/libvhost-user/libvhost-access.h:42:
+ if (vu_access_is_big_endian(vdev))
[...]
ERROR: braces {} are necessary for all arms of this statement
#82: FILE: contrib/libvhost-user/libvhost-access.h:49:
+ if (vu_access_is_big_endian(vdev))
[...]
ERROR: braces {} are necessary for all arms of this statement
#89: FILE: contrib/libvhost-user/libvhost-access.h:56:
+ if (vu_access_is_big_endian(vdev))
[...]
WARNING: line over 80 characters
#347: FILE: contrib/libvhost-user/libvhost-user.c:2512:
+ vu_ldq_p(dev, &desc[i].addr), vu_ldl_p(dev, &desc[i].len));
WARNING: line over 80 characters
#356: FILE: contrib/libvhost-user/libvhost-user.c:2520:
+ vu_ldq_p(dev, &desc[i].addr), vu_ldl_p(dev, &desc[i].len));
total: 3 errors, 3 warnings, 362 lines checked
Patch 2/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/3 Checking commit a6d1b6dacac8 (libvhost-user: fence legacy virtio devices)
WARNING: Block comments use a leading /* on a separate line
#48: FILE: contrib/libvhost-user/libvhost-user.c:544:
+ /* We only support devices conforming to VIRTIO 1.0 or
WARNING: Block comments use a trailing */ on a separate line
#49: FILE: contrib/libvhost-user/libvhost-user.c:545:
+ * later */
WARNING: line over 80 characters
#50: FILE: contrib/libvhost-user/libvhost-user.c:546:
+ vu_panic(dev, "virtio legacy devices aren't supported by libvhost-user");
total: 0 errors, 3 warnings, 33 lines checked
Patch 3/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200717092929.19453-1-mhartmay@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2020-07-17 10:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 9:29 [RFC v2 0/3] Enable virtio-fs on s390x Marc Hartmayer
2020-07-17 9:29 ` [RFC v2 1/3] virtio: add vhost-user-fs-ccw device Marc Hartmayer
2020-07-21 13:47 ` Stefan Hajnoczi
2020-07-28 10:31 ` Cornelia Huck
2020-07-28 11:25 ` Halil Pasic
2020-07-28 11:33 ` Cornelia Huck
2020-07-17 9:29 ` [RFC v2 2/3] libvhost-user: handle endianness as mandated by the spec Marc Hartmayer
2020-07-21 12:48 ` Stefan Hajnoczi
2020-07-30 13:15 ` Marc Hartmayer
2020-07-21 13:40 ` Michael S. Tsirkin
2020-07-21 16:44 ` Halil Pasic
2020-07-28 10:48 ` Cornelia Huck
2020-07-28 11:31 ` Halil Pasic
2020-07-28 10:52 ` Marc Hartmayer
2020-07-29 14:13 ` Michael S. Tsirkin
2020-07-29 16:11 ` Marc Hartmayer
2020-07-17 9:29 ` [RFC v2 3/3] libvhost-user: fence legacy virtio devices Marc Hartmayer
2020-07-21 13:47 ` Stefan Hajnoczi
2020-07-17 10:26 ` no-reply [this message]
2020-07-17 10:31 ` [RFC v2 0/3] Enable virtio-fs on s390x no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159498160510.17162.14939030906063593858@07a7f0d89f7d \
--to=no-reply@patchew.org \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mhartmay@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).