Re: [PULL 00/30] Audio 20210115 patches

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210115132146.1443592-1-kraxel@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210115132146.1443592-1-kraxel@redhat.com
Subject: [PULL 00/30] Audio 20210115 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210115132146.1443592-1-kraxel@redhat.com -> patchew/20210115132146.1443592-1-kraxel@redhat.com
 - [tag update]      patchew/cover.1610638428.git.jag.raman@oracle.com -> patchew/cover.1610638428.git.jag.raman@oracle.com
Switched to a new branch 'test'
1494b2f audio: space prohibited between function name and parenthesis'('
f6e4a58 audio: Suspect code indent for conditional statements
53a6160 audio: Don't use '%#' in format strings
fad4fe1 audio: Fix lines over 90 characters
f66b15a audio: foo* bar" should be "foo *bar".
a90865a audio: Add spaces around operator/delete redundant spaces
01dd516 audio: Add braces for statements/fix braces' position
7c87251 dsoundaudio: fix log message
4df2f7a dsoundaudio: enable f32 audio sample format
0ab413d dsoundaudio: rename dsound_open()
62c5cae dsoundaudio: replace GetForegroundWindow()
5c6d84c paaudio: send recorded data in smaller chunks
4799266 paaudio: limit minreq to 75% of audio timer_rate
7ad5624 paaudio: comment bugs in functions qpa_init_*
fc82ae0 paaudio: remove unneeded code
3b4756e paaudio: wait until the playback stream is ready
9efa6c0 paaudio: wait for PA_STREAM_READY in qpa_write()
8408153 paaudio: avoid to clip samples multiple times
b12f285 audio: remove remaining unused plive code
df4b9c7 sdlaudio: enable (in|out).mixing-engine=off
0c9ff0d audio: break generic buffer dependency on mixing-engine
c25b215 sdlaudio: add recording functions
34d824d audio: split pcm_ops function get_buffer_in
278b4db sdlaudio: replace legacy functions with modern ones
b4c73f3 sdlaudio: fill remaining sample buffer with silence
d52cce6 sdlaudio: always clear the sample buffer
9acac2a sdlaudio: don't start playback in init routine
402f1bb sdlaudio: add -audiodev sdl,out.buffer-count option
d3a03cb audio: fix bit-rotted code
eb9b30a sdlaudio: remove leftover SDL1.2 code

=== OUTPUT BEGIN ===
1/30 Checking commit eb9b30a750bc (sdlaudio: remove leftover SDL1.2 code)
2/30 Checking commit d3a03cb7f82b (audio: fix bit-rotted code)
3/30 Checking commit 402f1bb02a33 (sdlaudio: add -audiodev sdl,out.buffer-count option)
4/30 Checking commit 9acac2ac79a3 (sdlaudio: don't start playback in init routine)
5/30 Checking commit d52cce6a394a (sdlaudio: always clear the sample buffer)
6/30 Checking commit b4c73f3196f8 (sdlaudio: fill remaining sample buffer with silence)
7/30 Checking commit 278b4db01c96 (sdlaudio: replace legacy functions with modern ones)
ERROR: spaces required around that '*' (ctx:WxV)
#137: FILE: audio/sdlaudio.c:247:
+        glue(SDLVoice, dir) *sdl = (glue(SDLVoice, dir) *)hw;  \
                             ^

ERROR: spaces required around that '*' (ctx:WxB)
#137: FILE: audio/sdlaudio.c:247:
+        glue(SDLVoice, dir) *sdl = (glue(SDLVoice, dir) *)hw;  \
                                                         ^

total: 2 errors, 0 warnings, 222 lines checked

Patch 7/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/30 Checking commit 34d824d723c9 (audio: split pcm_ops function get_buffer_in)
9/30 Checking commit c25b21570d2d (sdlaudio: add recording functions)
ERROR: spaces required around that '*' (ctx:WxV)
#89: FILE: audio/sdlaudio.c:306:
+        glue(SDLVoice, dir) *sdl = (glue(SDLVoice, dir) *)hw;  \
                             ^

ERROR: spaces required around that '*' (ctx:WxB)
#89: FILE: audio/sdlaudio.c:306:
+        glue(SDLVoice, dir) *sdl = (glue(SDLVoice, dir) *)hw;  \
                                                         ^

total: 2 errors, 0 warnings, 185 lines checked

Patch 9/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/30 Checking commit 0c9ff0d05558 (audio: break generic buffer dependency on mixing-engine)
11/30 Checking commit df4b9c7bc97a (sdlaudio: enable (in|out).mixing-engine=off)
12/30 Checking commit b12f2859ee02 (audio: remove remaining unused plive code)
13/30 Checking commit 84081537b4bf (paaudio: avoid to clip samples multiple times)
14/30 Checking commit 9efa6c036626 (paaudio: wait for PA_STREAM_READY in qpa_write())
15/30 Checking commit 3b4756e48f9d (paaudio: wait until the playback stream is ready)
16/30 Checking commit fc82ae0f7214 (paaudio: remove unneeded code)
17/30 Checking commit 7ad56244f8a0 (paaudio: comment bugs in functions qpa_init_*)
18/30 Checking commit 4799266d2ce7 (paaudio: limit minreq to 75% of audio timer_rate)
19/30 Checking commit 5c6d84ce19a3 (paaudio: send recorded data in smaller chunks)
20/30 Checking commit 62c5cae8b7ab (dsoundaudio: replace GetForegroundWindow())
21/30 Checking commit 0ab413dc7a17 (dsoundaudio: rename dsound_open())
22/30 Checking commit 4df2f7a26559 (dsoundaudio: enable f32 audio sample format)
23/30 Checking commit 7c87251cd059 (dsoundaudio: fix log message)
24/30 Checking commit 01dd5165938e (audio: Add braces for statements/fix braces' position)
25/30 Checking commit a90865a46c6c (audio: Add spaces around operator/delete redundant spaces)
ERROR: space prohibited between function name and open parenthesis '('
#27: FILE: audio/audio_template.h:211:
+        glue (audio_pcm_hw_free_resources_ , TYPE) (hw);

total: 1 errors, 0 warnings, 32 lines checked

Patch 25/30 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

26/30 Checking commit f66b15a8e97a (audio: foo* bar" should be "foo *bar".)
27/30 Checking commit fad4fe1d4ed3 (audio: Fix lines over 90 characters)
28/30 Checking commit 53a6160b07e9 (audio: Don't use '%#' in format strings)
29/30 Checking commit f6e4a582154a (audio: Suspect code indent for conditional statements)
30/30 Checking commit 1494b2f2386b (audio: space prohibited between function name and parenthesis'(')
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210115132146.1443592-1-kraxel@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com