Re: [PATCH v3 00/36] block: update graph permissions update

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20210317143529.615584-1-vsementsov@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210317143529.615584-1-vsementsov@virtuozzo.com
Subject: [PATCH v3 00/36] block: update graph permissions update

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210317143529.615584-1-vsementsov@virtuozzo.com -> patchew/20210317143529.615584-1-vsementsov@virtuozzo.com
Switched to a new branch 'test'
ac26c21 block: refactor bdrv_node_check_perm()
7171293 block: rename bdrv_replace_child_safe() to bdrv_replace_child()
9430fba block: refactor bdrv_child_set_perm_safe() transaction action
2386ee1 block: inline bdrv_replace_child()
41c9fc1 block: inline bdrv_check_perm_common()
0d06ade block: drop unused permission update functions
72e8fe6 block: bdrv_reopen_multiple: refresh permissions on updated graph
b7f3a63 block: bdrv_reopen_multiple(): move bdrv_flush to separate pre-prepare
b9278b8 block: add bdrv_set_backing_noperm() transaction action
44f6e69 block: make bdrv_refresh_limits() to be a transaction action
a671d58 block: make bdrv_unset_inherits_from to be a transaction action
aa9e316 block: drop ignore_children for permission update functions
6e17bb7 block/backup-top: drop .active
7292e37 block: introduce bdrv_drop_filter()
9e7ce4f block: add bdrv_remove_filter_or_cow transaction action
a5f3a81 block: adapt bdrv_append() for inserting filters
ba82bea block: split out bdrv_replace_node_noperm()
4c97817 block: add bdrv_attach_child_noperm() transaction action
4a4e038 block: add bdrv_attach_child_common() transaction action
a864516 block: fix bdrv_replace_node_common
ce2b5ee block: add bdrv_replace_child_safe() transaction action
0b5ce80 block: add bdrv_list_* permission update functions
5380bbb block: add bdrv_drv_set_perm transaction action
965e80a block: use topological sort for permission update
35d94b7 block: inline bdrv_child_*() permission functions calls
84f3087 block: rewrite bdrv_child_try_set_perm() using bdrv_refresh_perms()
9eb28b7 block: refactor bdrv_child* permission functions
0c068cb block: bdrv_refresh_perms: check for parents permissions conflict
23d55e7 util: add transactions.c
68189c0 block: make bdrv_reopen_{prepare, commit, abort} private
5780b80 block: drop ctx argument from bdrv_root_attach_child
34f4c11 block: BdrvChildClass: add .get_parent_aio_context handler
e79d608 block: bdrv_append(): don't consume reference
87c292c tests/test-bdrv-graph-mod: add test_append_greedy_filter
381fa0c tests/test-bdrv-graph-mod: add test_parallel_perm_update
6df2206 tests/test-bdrv-graph-mod: add test_parallel_exclusive_write

=== OUTPUT BEGIN ===
1/36 Checking commit 6df2206946ee (tests/test-bdrv-graph-mod: add test_parallel_exclusive_write)
2/36 Checking commit 381fa0c5db90 (tests/test-bdrv-graph-mod: add test_parallel_perm_update)
3/36 Checking commit 87c292ca6696 (tests/test-bdrv-graph-mod: add test_append_greedy_filter)
4/36 Checking commit e79d608e8fad (block: bdrv_append(): don't consume reference)
5/36 Checking commit 34f4c11ddd7e (block: BdrvChildClass: add .get_parent_aio_context handler)
6/36 Checking commit 5780b805277e (block: drop ctx argument from bdrv_root_attach_child)
7/36 Checking commit 68189c099a3a (block: make bdrv_reopen_{prepare, commit, abort} private)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Vladimir Sementsov-Ogievskiy via <qemu-devel@nongnu.org>

total: 1 errors, 0 warnings, 47 lines checked

Patch 7/36 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/36 Checking commit 23d55e73e0fa (util: add transactions.c)
9/36 Checking commit 0c068cb2d8be (block: bdrv_refresh_perms: check for parents permissions conflict)
10/36 Checking commit 9eb28b73ad7b (block: refactor bdrv_child* permission functions)
11/36 Checking commit 84f3087f8300 (block: rewrite bdrv_child_try_set_perm() using bdrv_refresh_perms())
12/36 Checking commit 35d94b79e054 (block: inline bdrv_child_*() permission functions calls)
13/36 Checking commit 965e80af7b29 (block: use topological sort for permission update)
14/36 Checking commit 5380bbbb08b6 (block: add bdrv_drv_set_perm transaction action)
15/36 Checking commit 0b5ce8030a8f (block: add bdrv_list_* permission update functions)
16/36 Checking commit ce2b5ee8b20f (block: add bdrv_replace_child_safe() transaction action)
17/36 Checking commit a864516ae0f0 (block: fix bdrv_replace_node_common)
18/36 Checking commit 4a4e0386113f (block: add bdrv_attach_child_common() transaction action)
19/36 Checking commit 4c97817d23f8 (block: add bdrv_attach_child_noperm() transaction action)
20/36 Checking commit ba82bea53db2 (block: split out bdrv_replace_node_noperm())
21/36 Checking commit a5f3a81b5ad0 (block: adapt bdrv_append() for inserting filters)
22/36 Checking commit 9e7ce4f4dea2 (block: add bdrv_remove_filter_or_cow transaction action)
23/36 Checking commit 7292e37fb647 (block: introduce bdrv_drop_filter())
24/36 Checking commit 6e17bb7b248a (block/backup-top: drop .active)
25/36 Checking commit aa9e316c665f (block: drop ignore_children for permission update functions)
26/36 Checking commit a671d58d46da (block: make bdrv_unset_inherits_from to be a transaction action)
27/36 Checking commit 44f6e69305b1 (block: make bdrv_refresh_limits() to be a transaction action)
28/36 Checking commit b9278b83c02b (block: add bdrv_set_backing_noperm() transaction action)
29/36 Checking commit b7f3a63e844d (block: bdrv_reopen_multiple(): move bdrv_flush to separate pre-prepare)
30/36 Checking commit 72e8fe6a54ba (block: bdrv_reopen_multiple: refresh permissions on updated graph)
31/36 Checking commit 0d06ade388bb (block: drop unused permission update functions)
32/36 Checking commit 41c9fc136083 (block: inline bdrv_check_perm_common())
33/36 Checking commit 2386ee1e39eb (block: inline bdrv_replace_child())
34/36 Checking commit 9430fba2337b (block: refactor bdrv_child_set_perm_safe() transaction action)
35/36 Checking commit 71712939d665 (block: rename bdrv_replace_child_safe() to bdrv_replace_child())
36/36 Checking commit ac26c210743e (block: refactor bdrv_node_check_perm())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20210317143529.615584-1-vsementsov@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com