From: leirao <lei.rao@intel.com>
To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com,
jasowang@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
pbonzini@redhat.com, lukasstraub2@web.de
Cc: "Rao, Lei" <lei.rao@intel.com>, qemu-devel@nongnu.org
Subject: [PATCH v6 05/10] Add a function named packet_new_nocopy for COLO.
Date: Thu, 8 Apr 2021 23:20:51 -0400 [thread overview]
Message-ID: <1617938456-315058-6-git-send-email-lei.rao@intel.com> (raw)
In-Reply-To: <1617938456-315058-1-git-send-email-lei.rao@intel.com>
From: "Rao, Lei" <lei.rao@intel.com>
Use the packet_new_nocopy instead of packet_new in the
filter-rewriter module. There will be one less memory
copy in the processing of each network packet.
Signed-off-by: Lei Rao <lei.rao@intel.com>
---
net/colo.c | 25 +++++++++++++++++--------
net/colo.h | 1 +
net/filter-rewriter.c | 3 +--
3 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/net/colo.c b/net/colo.c
index ef00609..3a3e6e8 100644
--- a/net/colo.c
+++ b/net/colo.c
@@ -157,19 +157,28 @@ void connection_destroy(void *opaque)
Packet *packet_new(const void *data, int size, int vnet_hdr_len)
{
- Packet *pkt = g_slice_new(Packet);
+ Packet *pkt = g_slice_new0(Packet);
pkt->data = g_memdup(data, size);
pkt->size = size;
pkt->creation_ms = qemu_clock_get_ms(QEMU_CLOCK_HOST);
pkt->vnet_hdr_len = vnet_hdr_len;
- pkt->tcp_seq = 0;
- pkt->tcp_ack = 0;
- pkt->seq_end = 0;
- pkt->header_size = 0;
- pkt->payload_size = 0;
- pkt->offset = 0;
- pkt->flags = 0;
+
+ return pkt;
+}
+
+/*
+ * packet_new_nocopy will not copy data, so the caller can't release
+ * the data. And it will be released in packet_destroy.
+ */
+Packet *packet_new_nocopy(void *data, int size, int vnet_hdr_len)
+{
+ Packet *pkt = g_slice_new0(Packet);
+
+ pkt->data = data;
+ pkt->size = size;
+ pkt->creation_ms = qemu_clock_get_ms(QEMU_CLOCK_HOST);
+ pkt->vnet_hdr_len = vnet_hdr_len;
return pkt;
}
diff --git a/net/colo.h b/net/colo.h
index 573ab91..d91cd24 100644
--- a/net/colo.h
+++ b/net/colo.h
@@ -101,6 +101,7 @@ bool connection_has_tracked(GHashTable *connection_track_table,
ConnectionKey *key);
void connection_hashtable_reset(GHashTable *connection_track_table);
Packet *packet_new(const void *data, int size, int vnet_hdr_len);
+Packet *packet_new_nocopy(void *data, int size, int vnet_hdr_len);
void packet_destroy(void *opaque, void *user_data);
void packet_destroy_partial(void *opaque, void *user_data);
diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c
index 10fe393..cb3a96c 100644
--- a/net/filter-rewriter.c
+++ b/net/filter-rewriter.c
@@ -270,8 +270,7 @@ static ssize_t colo_rewriter_receive_iov(NetFilterState *nf,
vnet_hdr_len = nf->netdev->vnet_hdr_len;
}
- pkt = packet_new(buf, size, vnet_hdr_len);
- g_free(buf);
+ pkt = packet_new_nocopy(buf, size, vnet_hdr_len);
/*
* if we get tcp packet
--
1.8.3.1
next prev parent reply other threads:[~2021-04-09 3:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 3:20 [PATCH v6 00/10] Fixed some bugs and optimized some codes for COLO leirao
2021-04-09 3:20 ` [PATCH v6 01/10] Remove some duplicate trace code leirao
2021-04-09 3:20 ` [PATCH v6 02/10] Fix the qemu crash when guest shutdown during checkpoint leirao
2021-04-09 3:20 ` [PATCH v6 03/10] Optimize the function of filter_send leirao
2021-04-09 3:20 ` [PATCH v6 04/10] Remove migrate_set_block_enabled in checkpoint leirao
2021-04-09 3:20 ` leirao [this message]
2021-05-18 1:45 ` [PATCH v6 05/10] Add a function named packet_new_nocopy for COLO Zhang, Chen
2021-04-09 3:20 ` [PATCH v6 06/10] Add the function of colo_compare_cleanup leirao
2021-04-09 3:20 ` [PATCH v6 07/10] Reset the auto-converge counter at every checkpoint leirao
2021-04-09 3:20 ` [PATCH v6 08/10] Reduce the PVM stop time during Checkpoint leirao
2021-04-09 3:20 ` [PATCH v6 09/10] Add the function of colo_bitmap_clear_dirty leirao
2021-04-16 7:56 ` Rao, Lei
2021-04-27 2:32 ` Rao, Lei
2021-04-09 3:20 ` [PATCH v6 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() leirao
2021-05-17 19:46 ` [PATCH v6 00/10] Fixed some bugs and optimized some codes for COLO Lukas Straub
2021-05-18 1:33 ` Zhang, Chen
2021-06-18 2:52 ` chen.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617938456-315058-6-git-send-email-lei.rao@intel.com \
--to=lei.rao@intel.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lukasstraub2@web.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).