Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

["Daniel P. Berrange" <berrange@redhat.com>]

On Wed, Nov 08, 2017 at 12:28:00AM -0300, Philippe Mathieu-Daudé wrote:
> Hi Alexey,
> 
> On 11/07/2017 11:48 PM, Alexey Kardashevskiy wrote:
> > On 08/11/17 13:28, Philippe Mathieu-Daudé wrote:
> >> Both are deprecated since 2.9.0
> > 
> > May be so but I could not find where this happened in git history:
> > 
> > [vpl1 qemu]$ git log -n1 --grep 'pc-0.10'
> > f6d5a0bad2 2 years, 5 months ago Eduardo Habkost piix: Define PC_COMPAT_0_10
> > 
> > Having some pointers in the commit log would be helpful imho, like [2/6].
> 
> Ok! If there is positive feedback on this series I'll respin trying to
> be more verbose.
> 
> I took "2.9.0" from the wiki history [1], which is the formal way to go
> as I understand:

No, the wiki page content was just an initial jumping off point for
discussions.  The formal list of what's deprecated is kept in the
qemu-doc.texi file in the "Deprecated features" appendix.

We really ought to remove most of the content from that wiki page
and just point to the formal docs,  to avoid continued confusion
like this.

> 
> Before an "interface" can be removed, there needs to be a clear
> transition plan for doing so. This means it should be added to this wiki
> page, and that there have to be at least two public releases of QEMU
> where the interface still works, but issues a warning when used. Two
> public releases are required so that the users have at least one
> development cycle to complain if they think that there is a good reason
> that the interface should not be removed. The warning should say that
> the interface is deprecated / going away soon, with a pointer to
> documentation or similar information about its replacement syntax.
> 
> [1]
> https://wiki.qemu.org/index.php?title=Features/LegacyRemoval&action=history
> 
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >>  hw/i386/pc_piix.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> >> index f79d5cb694..c462b702ff 100644
> >> --- a/hw/i386/pc_piix.c
> >> +++ b/hw/i386/pc_piix.c
> >> @@ -941,6 +941,7 @@ static void pc_i440fx_0_11_machine_options(MachineClass *m)
> >>      pc_i440fx_0_12_machine_options(m);
> >>      m->hw_version = "0.11";
> >>      SET_MACHINE_COMPAT(m, PC_COMPAT_0_11);
> >> +    m->deprecated_reason = "Too old";
> >>  }
> >>  
> >>  DEFINE_I440FX_MACHINE(v0_11, "pc-0.11", pc_compat_0_13,
> >> @@ -976,6 +977,7 @@ static void pc_i440fx_0_10_machine_options(MachineClass *m)
> >>      pc_i440fx_0_11_machine_options(m);
> >>      m->hw_version = "0.10";
> >>      SET_MACHINE_COMPAT(m, PC_COMPAT_0_10);
> >> +    m->deprecated_reason = "Too old";
> >>  }
> >>  
> >>  DEFINE_I440FX_MACHINE(v0_10, "pc-0.10", pc_compat_0_13,
> >>
> 
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|