From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0
Date: Tue, 14 May 2019 15:15:39 +0100 [thread overview]
Message-ID: <20190514141537.GF2753@work-vm> (raw)
In-Reply-To: <20190430034412.12935-2-richardw.yang@linux.intel.com>
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> We can eliminate to pass 0.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/ram.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 35bd6213e9..9948b2d021 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1643,10 +1643,10 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs,
> }
>
> static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb,
> - ram_addr_t start, ram_addr_t length)
> + ram_addr_t length)
> {
> rs->migration_dirty_pages +=
> - cpu_physical_memory_sync_dirty_bitmap(rb, start, length,
> + cpu_physical_memory_sync_dirty_bitmap(rb, 0, length,
> &rs->num_dirty_pages_period);
> }
>
> @@ -1735,7 +1735,7 @@ static void migration_bitmap_sync(RAMState *rs)
> qemu_mutex_lock(&rs->bitmap_mutex);
> rcu_read_lock();
> RAMBLOCK_FOREACH_NOT_IGNORED(block) {
> - migration_bitmap_sync_range(rs, block, 0, block->used_length);
> + migration_bitmap_sync_range(rs, block, block->used_length);
> }
> ram_counters.remaining = ram_bytes_remaining();
> rcu_read_unlock();
> @@ -4156,7 +4156,7 @@ static void colo_flush_ram_cache(void)
> memory_global_dirty_log_sync();
> rcu_read_lock();
> RAMBLOCK_FOREACH_NOT_IGNORED(block) {
> - migration_bitmap_sync_range(ram_state, block, 0, block->used_length);
> + migration_bitmap_sync_range(ram_state, block, block->used_length);
> }
> rcu_read_unlock();
>
> --
> 2.19.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-05-14 14:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 3:44 [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-04-30 3:44 ` [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0 Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-05-14 14:15 ` Dr. David Alan Gilbert [this message]
2019-05-14 14:27 ` Dr. David Alan Gilbert
2019-05-15 6:41 ` Wei Yang
2019-05-15 8:04 ` Dr. David Alan Gilbert
2019-05-15 8:54 ` Wei Yang
2019-04-30 3:44 ` [Qemu-devel] [PATCH 2/3] migration/ram.c: start of cpu_physical_memory_sync_dirty_bitmap " Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-05-14 14:21 ` Dr. David Alan Gilbert
2019-05-31 0:54 ` Wei Yang
2019-06-21 7:43 ` Wei Yang
2019-07-17 1:13 ` Wei Yang
2019-07-17 9:16 ` Paolo Bonzini
2019-07-18 1:07 ` Wei Yang
2019-04-30 3:44 ` [Qemu-devel] [PATCH 3/3] ram: RAMBlock->offset is always aligned to a word Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-07-17 9:17 ` Paolo Bonzini
2019-07-18 1:11 ` Wei Yang
2019-05-01 22:53 ` [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c no-reply
2019-05-01 22:53 ` no-reply
2019-05-02 0:10 ` Wei Yang
2019-05-02 0:10 ` Wei Yang
2019-05-02 4:24 ` no-reply
2019-05-02 4:24 ` no-reply
2019-05-02 5:32 ` Wei Yang
2019-05-02 5:32 ` Wei Yang
2019-05-02 8:35 ` Dr. David Alan Gilbert
2019-05-02 8:35 ` Dr. David Alan Gilbert
2019-05-02 22:34 ` Wei Yang
2019-05-02 22:34 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514141537.GF2753@work-vm \
--to=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).