From: Kevin Wolf <kwolf@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Cc: vsementsov@virtuozzo.com, berrange@redhat.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
rkagan@virtuozzo.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind
Date: Mon, 17 Jun 2019 13:15:04 +0200 [thread overview]
Message-ID: <20190617111504.GC7397@linux.fritz.box> (raw)
In-Reply-To: <1560276131-683243-3-git-send-email-andrey.shinkevich@virtuozzo.com>
Am 11.06.2019 um 20:02 hat Andrey Shinkevich geschrieben:
> The Valgrind tool fails to manage its termination when QEMU raises the
> signal SIGKILL. Lets exclude such test cases from running under the
> Valgrind because there is no sense to check memory issues that way.
>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
I don't fully understand the reasoning here. Most interesting memory
access errors happen before a process terminates. (I'm not talking about
leaks here, but use-after-free, buffer overflows, uninitialised memory
etc.)
However, I do see that running these test cases with -valgrind ends in a
hang because the valgrind process keeps hanging around as a zombie
process and the test case doesn't reap it. I'm not exactly sure why that
is, but it looks more like a problem with the parent process (i.e. the
bash script).
If we can't figure out how to fix this, we can disable valgrind in these
cases, but I think the explanation needs to be different.
> diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
> index 0d4e963..95115e2 100755
> --- a/tests/qemu-iotests/039
> +++ b/tests/qemu-iotests/039
> @@ -65,6 +65,7 @@ echo "== Creating a dirty image file =="
> IMGOPTS="compat=1.1,lazy_refcounts=on"
> _make_test_img $size
>
> +VALGRIND_QEMU="" \
> $QEMU_IO -c "write -P 0x5a 0 512" \
> -c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 \
> | _filter_qemu_io
I agree with Vladimir that setting VALGRIND_QEMU only once at the top of
the script is probably the better option.
Kevin
next prev parent reply other threads:[~2019-06-17 11:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 18:02 [Qemu-devel] [PATCH v2 0/7] Allow Valgrind checking all QEMU processes Andrey Shinkevich
2019-06-11 18:02 ` [Qemu-devel] [PATCH v2 1/7] iotests: allow " Andrey Shinkevich
2019-06-13 9:44 ` Vladimir Sementsov-Ogievskiy
2019-06-27 15:08 ` Andrey Shinkevich
2019-06-13 9:45 ` Vladimir Sementsov-Ogievskiy
2019-06-11 18:02 ` [Qemu-devel] [PATCH v2 2/7] iotests: exclude killed processes from running under Valgrind Andrey Shinkevich
2019-06-13 9:47 ` Vladimir Sementsov-Ogievskiy
2019-06-17 11:57 ` Roman Kagan
2019-06-17 11:15 ` Kevin Wolf [this message]
2019-06-17 12:18 ` Roman Kagan
2019-06-17 12:53 ` Kevin Wolf
2019-06-17 13:20 ` Roman Kagan
2019-06-17 14:51 ` Kevin Wolf
2019-06-24 16:55 ` Andrey Shinkevich
2019-06-11 18:02 ` [Qemu-devel] [PATCH v2 3/7] iotests: Valgrind fails to work with nonexistent directory Andrey Shinkevich
2019-06-13 9:52 ` Vladimir Sementsov-Ogievskiy
2019-06-17 11:22 ` Kevin Wolf
2019-06-11 18:02 ` [Qemu-devel] [PATCH v2 4/7] iotests: extended timeout under Valgrind Andrey Shinkevich
2019-06-13 9:54 ` Vladimir Sementsov-Ogievskiy
2019-06-11 18:02 ` [Qemu-devel] [PATCH v2 5/7] iotests: extend sleeping time " Andrey Shinkevich
2019-06-13 9:55 ` Vladimir Sementsov-Ogievskiy
2019-06-11 18:02 ` [Qemu-devel] [PATCH v2 6/7] iotests: amend QEMU NBD process synchronization Andrey Shinkevich
2019-06-13 9:59 ` Vladimir Sementsov-Ogievskiy
2019-06-17 12:45 ` Roman Kagan
2019-06-17 12:38 ` Roman Kagan
2019-06-11 18:02 ` [Qemu-devel] [PATCH v2 7/7] iotests: new file to suppress Valgrind errors Andrey Shinkevich
2019-06-13 10:06 ` Vladimir Sementsov-Ogievskiy
2019-06-24 16:55 ` Andrey Shinkevich
2019-06-24 17:09 ` Eric Blake
2019-06-24 17:23 ` Andrey Shinkevich
2019-06-17 11:45 ` Kevin Wolf
2019-06-24 16:55 ` Andrey Shinkevich
2019-06-25 8:13 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617111504.GC7397@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).