From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v5 0/3] virtio-scsi: restart DMA after iothread
Date: Thu, 20 Jun 2019 18:35:29 +0100 [thread overview]
Message-ID: <20190620173532.14468-1-stefanha@redhat.com> (raw)
v5:
* Plumbing vm change state handlers into DeviceClass/BusClass is a rather
large bug fix. Instead I've combined the previous priorities approach with
the observation from Kevin and Paolo that we really want to order by qdev
tree depth.
The new qdev_add_vm_change_state_handler() API lets DeviceStates register
callbacks that execute in qdev tree depth order. This solves the
virtio-scsi bug since the virtio-scsi device's callback must complete before
its child scsi-disk's callback runs.
Is this a good compromise for everyone?
Stefan Hajnoczi (3):
vl: add qemu_add_vm_change_state_handler_prio()
qdev: add qdev_add_vm_change_state_handler()
virtio-scsi: restart DMA after iothread
hw/core/Makefile.objs | 1 +
include/hw/qdev-core.h | 5 +++
include/sysemu/sysemu.h | 2 +
hw/core/vm-change-state-handler.c | 61 +++++++++++++++++++++++++++++++
hw/scsi/scsi-bus.c | 4 +-
hw/virtio/virtio.c | 4 +-
vl.c | 59 ++++++++++++++++++++++++------
7 files changed, 120 insertions(+), 16 deletions(-)
create mode 100644 hw/core/vm-change-state-handler.c
--
2.21.0
next reply other threads:[~2019-06-20 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 17:35 Stefan Hajnoczi [this message]
2019-06-20 17:35 ` [Qemu-devel] [PATCH v5 1/3] vl: add qemu_add_vm_change_state_handler_prio() Stefan Hajnoczi
2019-06-20 17:37 [Qemu-devel] [PATCH v5 0/3] virtio-scsi: restart DMA after iothread Stefan Hajnoczi
2019-06-20 18:07 ` Paolo Bonzini
2019-06-27 11:03 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620173532.14468-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).