From: Greg Kurz <groug@kaod.org>
To: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU-PPC] [PATCH] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter
Date: Mon, 24 Jun 2019 10:37:45 +0200 [thread overview]
Message-ID: <20190624103745.08a32221@bahia.lan> (raw)
In-Reply-To: <20190624013921.11944-1-sjitindarsingh@gmail.com>
On Mon, 24 Jun 2019 11:39:21 +1000
Suraj Jitindar Singh <sjitindarsingh@gmail.com> wrote:
> The ibm,get_system_parameter rtas call is used by the guest to retrieve
> data relating to certain parameters of the system. The SPLPAR
> characteristics option (token 20) is used to determin characteristics of
> the environment in which the lpar will run.
>
> It may be useful for a guest to know the number of physical host threads
> present on the underlying system where it is being run. Add the
> characteristic "HostThrs" to the SPLPAR Characteristics
> ibm,get_system_parameter rtas call to expose this information to a
> guest and provide an implementation which determines this information
> based on the number of interrupt servers present in the device tree.
>
Shouldn't this also take split core into account, ie. divide the
result by "/sys/devices/system/cpu/subcores_per_core" like the
ppc64_cpu command from powerpc-utils does ?
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
> ---
> hw/ppc/spapr_rtas.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
> index 5bc1a93271..a33d87794c 100644
> --- a/hw/ppc/spapr_rtas.c
> +++ b/hw/ppc/spapr_rtas.c
> @@ -229,6 +229,40 @@ static inline int sysparm_st(target_ulong addr, target_ulong len,
> return RTAS_OUT_SUCCESS;
> }
>
> +static int rtas_get_num_host_threads(void)
> +{
> + const char *entry, *name = "/proc/device-tree/cpus/";
> + int num_threads = -1;
> + GDir *dir;
> +
> + if (!kvm_enabled())
> + return 1;
> +
> + dir = g_dir_open(name, 0, NULL);
> + if (!dir)
> + return -1;
> +
> + while ((entry = g_dir_read_name(dir))) {
> + if (!strncmp(entry, "PowerPC,POWER", strlen("PowerPC,POWER"))) {
> + unsigned long len;
> + char *path, *buf;
> +
> + path = g_strconcat(name, entry, "/ibm,ppc-interrupt-server#s",
> + NULL);
> + if (g_file_get_contents(path, &buf, &len, NULL)) {
> + num_threads = len / sizeof(int);
> + g_free(buf);
> + }
> +
> + g_free(path);
> + break;
> + }
> + }
> +
> + g_dir_close(dir);
> + return num_threads;
> +}
> +
> static void rtas_ibm_get_system_parameter(PowerPCCPU *cpu,
> SpaprMachineState *spapr,
> uint32_t token, uint32_t nargs,
> @@ -250,6 +284,16 @@ static void rtas_ibm_get_system_parameter(PowerPCCPU *cpu,
> current_machine->ram_size / MiB,
> smp_cpus,
> max_cpus);
> + int num_host_threads = rtas_get_num_host_threads();
> +
> + if (num_host_threads > 0) {
> + char *hostthr_val, *old = param_val;
> +
> + hostthr_val = g_strdup_printf(",HostThrs=%d", num_host_threads);
> + param_val = g_strconcat(param_val, hostthr_val, NULL);
> + g_free(hostthr_val);
> + g_free(old);
> + }
> ret = sysparm_st(buffer, length, param_val, strlen(param_val) + 1);
> g_free(param_val);
> break;
next prev parent reply other threads:[~2019-06-24 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 1:39 [Qemu-devel] [QEMU-PPC] [PATCH] powerpc/spapr: Add host threads parameter to ibm, get_system_parameter Suraj Jitindar Singh
2019-06-24 1:45 ` no-reply
2019-06-24 8:37 ` Greg Kurz [this message]
2019-06-26 1:44 ` [Qemu-devel] [Qemu-ppc] " Suraj Jitindar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624103745.08a32221@bahia.lan \
--to=groug@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sjitindarsingh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).