qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com, corentincj@iksaif.net, pl@kamp.de,
	peterx@redhat.com, kraxel@redhat.com, pbonzini@redhat.com,
	Wei Yang <richardw.yang@linux.intel.com>
Subject: [Qemu-devel] [PATCH v2 2/2] test-bitmap: add test for bitmap_set
Date: Wed, 17 Jul 2019 15:11:14 +0800	[thread overview]
Message-ID: <20190717071114.14772-3-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190717071114.14772-1-richardw.yang@linux.intel.com>

Add a test for bitmap_set. There are three cases:

  * Both start and end is BITS_PER_LONG aligned
  * Only start is BITS_PER_LONG aligned
  * Only end is BITS_PER_LONG aligned

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 tests/test-bitmap.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/tests/test-bitmap.c b/tests/test-bitmap.c
index cb7c5e462d..1f0123f604 100644
--- a/tests/test-bitmap.c
+++ b/tests/test-bitmap.c
@@ -59,12 +59,45 @@ static void check_bitmap_copy_with_offset(void)
     g_free(bmap3);
 }
 
+static void check_bitmap_set(void)
+{
+    unsigned long *bmap;
+
+    bmap = bitmap_new(BMAP_SIZE);
+
+    /* Both Aligned, set bits [BITS_PER_LONG, 2*BITS_PER_LONG] */
+    bitmap_set(bmap, BITS_PER_LONG, BITS_PER_LONG);
+    g_assert_cmpint(find_first_bit(bmap, BITS_PER_LONG), ==, BITS_PER_LONG);
+    g_assert_cmpint(find_next_zero_bit(bmap, 2 * BITS_PER_LONG, BITS_PER_LONG),
+                    ==, 2 * BITS_PER_LONG);
+
+    bitmap_clear(bmap, 0, BMAP_SIZE);
+    /* End Aligned, set bits [BITS_PER_LONG - 5, 2*BITS_PER_LONG] */
+    bitmap_set(bmap, BITS_PER_LONG - 5, BITS_PER_LONG + 5);
+    g_assert_cmpint(find_first_bit(bmap, BITS_PER_LONG),
+                    ==, BITS_PER_LONG - 5);
+    g_assert_cmpint(find_next_zero_bit(bmap,
+                                       2 * BITS_PER_LONG, BITS_PER_LONG - 5),
+                    ==, 2 * BITS_PER_LONG);
+
+    bitmap_clear(bmap, 0, BMAP_SIZE);
+    /* Start Aligned, set bits [BITS_PER_LONG, 2*BITS_PER_LONG + 5] */
+    bitmap_set(bmap, BITS_PER_LONG, BITS_PER_LONG + 5);
+    g_assert_cmpint(find_first_bit(bmap, BITS_PER_LONG),
+                    ==, BITS_PER_LONG);
+    g_assert_cmpint(find_next_zero_bit(bmap,
+                                       2 * BITS_PER_LONG + 5, BITS_PER_LONG),
+                    ==, 2 * BITS_PER_LONG + 5);
+}
+
 int main(int argc, char **argv)
 {
     g_test_init(&argc, &argv, NULL);
 
     g_test_add_func("/bitmap/bitmap_copy_with_offset",
                     check_bitmap_copy_with_offset);
+    g_test_add_func("/bitmap/bitmap_set",
+                    check_bitmap_set);
 
     g_test_run();
 
-- 
2.17.1



  parent reply	other threads:[~2019-07-17  7:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17  7:11 [Qemu-devel] [PATCH v2 0/2] bitmap: refine bitmap_set Wei Yang
2019-07-17  7:11 ` [Qemu-devel] [PATCH v2 1/2] bitmap: get last word mask from nr directly Wei Yang
2019-07-17  7:11 ` Wei Yang [this message]
2019-07-17  7:43   ` [Qemu-devel] [PATCH v2 2/2] test-bitmap: add test for bitmap_set Peter Xu
2019-07-17  8:08     ` Wei Yang
2019-07-18  1:05 ` [Qemu-devel] [PATCH v2 0/2] bitmap: refine bitmap_set no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190717071114.14772-3-richardw.yang@linux.intel.com \
    --to=richardw.yang@linux.intel.com \
    --cc=corentincj@iksaif.net \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).