From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration/postcopy: use static PostcopyDiscardState instead of allocating it for each block
Date: Tue, 23 Jul 2019 16:42:12 +0100 [thread overview]
Message-ID: <20190723154212.GL2719@work-vm> (raw)
In-Reply-To: <20190722063941.GA2602@richard>
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> On Fri, Jul 19, 2019 at 06:41:28PM +0100, Dr. David Alan Gilbert wrote:
> >* Wei Yang (richardw.yang@linux.intel.com) wrote:
> >> Even we need to do discard for each RAMBlock, we still can leverage the
> >> same memory space to store the information.
> >>
> >> By doing so, we avoid memory allocation and deallocation to the system
> >> and also avoid potential failure of memory allocation which breaks the
> >> migration.
> >>
> >> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> >> ---
> >> migration/postcopy-ram.c | 16 +++++++---------
> >> 1 file changed, 7 insertions(+), 9 deletions(-)
> >>
> >> diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
> >> index 9faacacc9e..2e6b076bb7 100644
> >> --- a/migration/postcopy-ram.c
> >> +++ b/migration/postcopy-ram.c
> >> @@ -1377,8 +1377,7 @@ void postcopy_fault_thread_notify(MigrationIncomingState *mis)
> >> * asking to discard individual ranges.
> >> *
> >> * @ms: The current migration state.
> >> - * @offset: the bitmap offset of the named RAMBlock in the migration
> >> - * bitmap.
> >> + * @offset: the bitmap offset of the named RAMBlock in the migration bitmap.
> >> * @name: RAMBlock that discards will operate on.
> >> *
> >> * returns: a new PDS.
> >> @@ -1386,13 +1385,14 @@ void postcopy_fault_thread_notify(MigrationIncomingState *mis)
> >> PostcopyDiscardState *postcopy_discard_send_init(MigrationState *ms,
> >> const char *name)
> >> {
> >> - PostcopyDiscardState *res = g_malloc0(sizeof(PostcopyDiscardState));
> >> + static PostcopyDiscardState res = {0};
> >
> >Do you think it would be better to make this a static at the top of
> >migration/postcopy-ram.c and then we could remove the pds parameters
> >from postcopy_discard_send_range and friends?
>
> Just took a look into this one. One problem is not all its friends are in
> migration/postcopy-ram.c
>
> For example, postcopy_chunk_hostpages_pass() is in migration/ram.c.
But doesn't that just pass teh pds back to postcopy_discard_send_range
which is in postcopy-ram ?
Dave
> Which way do you prefer?
>
> >If there's only one pds then we don't need to pass the pointer around.
> >
> >Dave
> >
> >> - if (res) {
> >> - res->ramblock_name = name;
> >> - }
> >> + res.ramblock_name = name;
> >> + res.cur_entry = 0;
> >> + res.nsentwords = 0;
> >> + res.nsentcmds = 0;
> >>
> >> - return res;
> >> + return &res;
> >> }
> >>
> >> /**
> >> @@ -1449,8 +1449,6 @@ void postcopy_discard_send_finish(MigrationState *ms, PostcopyDiscardState *pds)
> >>
> >> trace_postcopy_discard_send_finish(pds->ramblock_name, pds->nsentwords,
> >> pds->nsentcmds);
> >> -
> >> - g_free(pds);
> >> }
> >>
> >> /*
> >> --
> >> 2.17.1
> >>
> >--
> >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
> --
> Wei Yang
> Help you, Help me
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-07-23 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 8:11 [Qemu-devel] [PATCH] migration/postcopy: use static PostcopyDiscardState instead of allocating it for each block Wei Yang
2019-07-19 17:41 ` Dr. David Alan Gilbert
2019-07-20 1:51 ` Wei Yang
2019-07-22 6:39 ` Wei Yang
2019-07-23 15:42 ` Dr. David Alan Gilbert [this message]
2019-07-24 1:02 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723154212.GL2719@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).