From: Wei Yang <richard.weiyang@gmail.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: pbonzini@redhat.com, quintela@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] migration: rename migration_bitmap_sync_range to ramblock_sync_dirty_bitmap
Date: Wed, 7 Aug 2019 22:06:22 +0000 [thread overview]
Message-ID: <20190807220622.er4n4mo2fdxtca4e@master> (raw)
In-Reply-To: <20190807174948.GK27871@work-vm>
On Wed, Aug 07, 2019 at 06:49:48PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.yang@linux.intel.com) wrote:
>> Rename for better understanding of the code.
>>
>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>
>this needs fixing after 'just pass RAMBlock is enough'
>
You mean rebase it? Hmm... let me take a look.
>Dave
>
>> ---
>> migration/ram.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/migration/ram.c b/migration/ram.c
>> index c5f9f4b0ef..66792568e2 100644
>> --- a/migration/ram.c
>> +++ b/migration/ram.c
>> @@ -1669,7 +1669,7 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs,
>> return ret;
>> }
>>
>> -static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb,
>> +static void ramblock_sync_dirty_bitmap(RAMState *rs, RAMBlock *rb,
>> ram_addr_t length)
>> {
>> rs->migration_dirty_pages +=
>> @@ -1762,7 +1762,7 @@ static void migration_bitmap_sync(RAMState *rs)
>> qemu_mutex_lock(&rs->bitmap_mutex);
>> rcu_read_lock();
>> RAMBLOCK_FOREACH_NOT_IGNORED(block) {
>> - migration_bitmap_sync_range(rs, block, block->used_length);
>> + ramblock_sync_dirty_bitmap(rs, block, block->used_length);
>> }
>> ram_counters.remaining = ram_bytes_remaining();
>> rcu_read_unlock();
>> @@ -4175,7 +4175,7 @@ static void colo_flush_ram_cache(void)
>> memory_global_dirty_log_sync();
>> rcu_read_lock();
>> RAMBLOCK_FOREACH_NOT_IGNORED(block) {
>> - migration_bitmap_sync_range(ram_state, block, block->used_length);
>> + ramblock_sync_dirty_bitmap(ram_state, block, block->used_length);
>> }
>> rcu_read_unlock();
>>
>> --
>> 2.17.1
>>
>>
>--
>Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-08-07 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 8:48 [Qemu-devel] [PATCH] migration: rename migration_bitmap_sync_range to ramblock_sync_dirty_bitmap Wei Yang
2019-08-07 17:49 ` Dr. David Alan Gilbert
2019-08-07 22:06 ` Wei Yang [this message]
2019-08-08 3:29 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807220622.er4n4mo2fdxtca4e@master \
--to=richard.weiyang@gmail.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).