From: sathnaga@linux.vnet.ibm.com
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, groug@kaod.org, qemu-ppc@nongnu.org,
clg@kaod.org, crosa@redhat.com,
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
david@gibson.dropbear.id.au
Subject: [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc
Date: Mon, 19 Aug 2019 13:58:20 +0530 [thread overview]
Message-ID: <20190819082820.14817-1-sathnaga@linux.vnet.ibm.com> (raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 1264 bytes --]
From: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Current acceptance test will not run properly in powerpc
environment due qemu target is different from arch, this
usually matches, except with bi-endian architectures like ppc64.
uname would return `ppc64` or `ppc64le` based `big` or `little`
endian but qemu `target` is always `ppc64`. Let's handle it.
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
---
tests/acceptance/avocado_qemu/__init__.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index aee5d820ed..bd41e0443c 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -39,6 +39,9 @@ def pick_default_qemu_bin(arch=None):
"""
if arch is None:
arch = os.uname()[4]
+ # qemu binary path does not match arch for powerpc, handle it
+ if 'ppc64le' in arch:
+ arch = 'ppc64'
qemu_bin_relative_path = os.path.join("%s-softmmu" % arch,
"qemu-system-%s" % arch)
if is_readable_executable_file(qemu_bin_relative_path):
--
2.21.0
next reply other threads:[~2019-08-19 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 8:28 sathnaga [this message]
2019-08-24 9:32 ` [Qemu-devel] [PATCH V2 1/2] tests.acceptance.avocado_qemu: Add support for powerpc David Gibson
2019-08-27 16:00 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819082820.14817-1-sathnaga@linux.vnet.ibm.com \
--to=sathnaga@linux.vnet.ibm.com \
--cc=clg@kaod.org \
--cc=crosa@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).