From: Stefan Hajnoczi <stefanha@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefan@redhat.com>,
Julia Suvorova <jusual@mail.ru>,
Aarushi Mehta <mehta.aaru20@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/3] block/io_uring: fix EINTR and resubmit short reads
Date: Thu, 22 Aug 2019 10:16:34 +0100 [thread overview]
Message-ID: <20190822091634.GC20491@stefanha-x1.localdomain> (raw)
In-Reply-To: <3ccd9e30-d6ec-c752-fb0d-08318091fc6b@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]
On Wed, Aug 21, 2019 at 06:20:39PM -0400, John Snow wrote:
>
>
> On 7/15/19 4:19 PM, Stefan Hajnoczi wrote:
> > Short reads are possible with cache=writeback (see Patch 3 for details).
> > Handle this by resubmitting requests until the read is completed.
> >
> > Patch 1 adds trace events useful for debugging io_uring.
> >
> > Patch 2 fixes EINTR. This lays the groundwork for resubmitting requests in
> > Patch 3.
> >
> > Aarushi: Feel free to squash this into your patch series if you are happy with
> > the code, I don't mind if the authorship information is lost. After applying
> > these patches I can successfully boot a Fedora 30 guest qcow2 file with
> > cache=writeback.
> >
> > Based-on: <20190610134905.22294-1-mehta.aaru20@gmail.com>
> >
> > Stefan Hajnoczi (3):
> > block/io_uring: add submission and completion trace events
> > block/io_uring: fix EINTR request resubmission
> > block/io_uring: resubmit short buffered reads
> >
> > block/io_uring.c | 136 ++++++++++++++++++++++++++++++++++-----------
> > block/trace-events | 6 +-
> > 2 files changed, 108 insertions(+), 34 deletions(-)
> >
>
> Since this is over the 30 days mark, I'm going to assume this WAS
> squashed into Aarushi's patchset, and it's safe to drop this from the
> review queue for now?
Yes, Aarushi included in the io_uring patch series.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-08-22 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 20:19 [Qemu-devel] [PATCH 0/3] block/io_uring: fix EINTR and resubmit short reads Stefan Hajnoczi
2019-07-15 20:19 ` [Qemu-devel] [PATCH 1/3] block/io_uring: add submission and completion trace events Stefan Hajnoczi
2019-07-16 7:04 ` Philippe Mathieu-Daudé
2019-07-15 20:19 ` [Qemu-devel] [PATCH 2/3] block/io_uring: fix EINTR request resubmission Stefan Hajnoczi
2019-07-15 20:19 ` [Qemu-devel] [PATCH 3/3] block/io_uring: resubmit short buffered reads Stefan Hajnoczi
2019-07-16 7:15 ` Philippe Mathieu-Daudé
2019-08-21 22:20 ` [Qemu-devel] [Qemu-block] [PATCH 0/3] block/io_uring: fix EINTR and resubmit short reads John Snow
2019-08-22 9:16 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822091634.GC20491@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=jsnow@redhat.com \
--cc=jusual@mail.ru \
--cc=kwolf@redhat.com \
--cc=mehta.aaru20@gmail.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).