From: Sam Eiderman via Qemu-devel <qemu-devel@nongnu.org>
To: Sam Eiderman <sameid@google.com>,
kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
seabios@seabios.org, kraxel@redhat.com, kevin@koconnor.net
Cc: liran.alon@oracle.com, karl.heubaum@oracle.com
Subject: Re: [Qemu-devel] [QEMU] [PATCH v5 3/8] bootdevice: Add interface to gather LCHS
Date: Thu, 22 Aug 2019 18:13:58 +0300 [thread overview]
Message-ID: <20190822151358.6094-1-sameid@google.com> (raw)
In-Reply-To: <a4e72a67-4107-4cbb-10e6-6a77011f34ce@redhat.com>
> I’ve got a couple of “undelivered mail returned to sender” mails for Sam
> recently, but anyway...
- shmuel.eiderman@oracle.com
+ sameid@google.com
> It doesn’t look like any caller actually passes a NULL @dev, so why not
> drop the @suffix part?
Just copied it from the bootindex implementation.
I think the suffix part there was implemented specifically for fdc since
the same device can have two suffixes (A and B).
This is not relavant here, but I think we still need the suffix to
create the device name for seabios to find.
Sam
next prev parent reply other threads:[~2019-08-22 15:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 12:39 [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 1/8] block: Refactor macros - fix tabbing Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 2/8] block: Support providing LCHS from user Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 3/8] bootdevice: Add interface to gather LCHS Sam Eiderman
2019-08-13 18:51 ` Max Reitz
2019-08-22 15:13 ` Sam Eiderman via Qemu-devel [this message]
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 4/8] scsi: Propagate unrealize() callback to scsi-hd Sam Eiderman
2019-08-13 19:06 ` Max Reitz
2019-08-25 13:35 ` Sam Eiderman via Qemu-devel
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 5/8] bootdevice: Gather LCHS from all relevant devices Sam Eiderman
2019-08-13 19:05 ` Max Reitz
2019-08-25 13:38 ` Sam Eiderman via Qemu-devel
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 6/8] bootdevice: Refactor get_boot_devices_list Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 7/8] bootdevice: FW_CFG interface for LCHS values Sam Eiderman
2019-06-26 12:39 ` [Qemu-devel] [QEMU] [PATCH v5 8/8] hd-geo-test: Add tests for lchs override Sam Eiderman
2019-07-01 7:41 ` [Qemu-devel] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface Gerd Hoffmann
2019-07-08 17:30 ` Sam Eiderman
2019-07-17 19:03 ` Sam Eiderman
2019-07-17 19:46 ` Kevin Wolf
2019-07-19 10:10 ` Sam Eiderman
2019-07-25 0:47 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-25 0:50 ` John Snow
2019-07-25 19:42 ` Laszlo Ersek
2019-07-30 11:35 ` Gerd Hoffmann
2019-08-13 19:35 ` [Qemu-devel] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822151358.6094-1-sameid@google.com \
--to=qemu-devel@nongnu.org \
--cc=karl.heubaum@oracle.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=liran.alon@oracle.com \
--cc=qemu-block@nongnu.org \
--cc=sameid@google.com \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).