qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: f4bug@amsat.org, cohuck@redhat.com, qemu-devel@nongnu.org,
	amarkovic@wavecomp.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] tests/acceptance: Add new test cases in linux_ssh_mips_malta.py
Date: Wed, 28 Aug 2019 17:27:40 -0400	[thread overview]
Message-ID: <20190828212726.GC11512@localhost.localdomain> (raw)
In-Reply-To: <1564760158-27536-3-git-send-email-aleksandar.markovic@rt-rk.com>

On Fri, Aug 02, 2019 at 05:35:58PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
> 
> Add 15 new tests cases. They all rely on simple commands used for
> detecting hardware configuration information.
> 
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
>  tests/acceptance/linux_ssh_mips_malta.py | 45 ++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptance/linux_ssh_mips_malta.py
> index 8368e1f..c153c41 100644
> --- a/tests/acceptance/linux_ssh_mips_malta.py
> +++ b/tests/acceptance/linux_ssh_mips_malta.py
> @@ -155,6 +155,51 @@ class LinuxSSH(Test):
>  
>      def run_common_commands(self):
>          self.ssh_command_output_contains(
> +            'cat /proc/cpuinfo',
> +            '24Kc')
> +        self.ssh_command_output_contains(
> +            'uname -m',
> +            'mips')
> +        self.ssh_command_output_contains(
> +            'uname -r',
> +            '3.2.0-4-4kc-malta')
> +        self.ssh_command_output_contains(
> +            'cat /proc/interrupts',
> +            'timer')
> +        self.ssh_command_output_contains(
> +            'cat /proc/interrupts',
> +            'i8042')
> +        self.ssh_command_output_contains(
> +            'cat /proc/interrupts',
> +            'serial')
> +        self.ssh_command_output_contains(
> +            'cat /proc/interrupts',
> +            'ata_piix')
> +        self.ssh_command_output_contains(
> +            'cat /proc/interrupts',
> +            'eth0')
> +        self.ssh_command_output_contains(
> +            'cat /proc/interrupts',
> +            'eth0')
> +        self.ssh_command_output_contains(
> +            'cat /proc/devices',
> +            'input')
> +        self.ssh_command_output_contains(
> +            'cat /proc/devices',
> +            'usb')
> +        self.ssh_command_output_contains(
> +            'cat /proc/devices',
> +            'fb')
> +        self.ssh_command_output_contains(
> +            'cat /proc/ioports',
> +            'serial')
> +        self.ssh_command_output_contains(
> +            'cat /proc/ioports',
> +            'ata_piix')
> +        self.ssh_command_output_contains(
> +            'cat /proc/ioports',
> +            'piix4_smbus')
> +        self.ssh_command_output_contains(
>              'lspci -d 11ab:4620',
>              'GT-64120')
>          self.ssh_command_output_contains(
> -- 
> 2.7.4
> 
> 

This is fine, although using a loop would probably result in better
readability.  Something like:

   for cmd, exp in [('cat /proc/cpuinfo', '24Kc'),
                    ('uname -m', 'mips'),
                    ...]
      self.ssh_command_output_contains(cmd, exp)

Either way:

Reviewed-by: Cleber Rosa <crosa@redhat.com>


  reply	other threads:[~2019-08-28 21:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-02 15:35 [Qemu-devel] [PATCH 0/2] tests/acceptance: Update MIPS Malta ssh test Aleksandar Markovic
2019-08-02 15:35 ` [Qemu-devel] [PATCH 1/2] tests/acceptance: Refactor and improve reporting in linux_ssh_mips_malta.py Aleksandar Markovic
2019-08-02 15:58   ` Philippe Mathieu-Daudé
2019-08-28 20:58   ` Cleber Rosa
2019-08-02 15:35 ` [Qemu-devel] [PATCH 2/2] tests/acceptance: Add new test cases " Aleksandar Markovic
2019-08-28 21:27   ` Cleber Rosa [this message]
2019-08-21 20:27 ` [Qemu-devel] [PATCH 0/2] tests/acceptance: Update MIPS Malta ssh test Aleksandar Markovic
2019-08-21 21:00   ` Eduardo Habkost
2019-08-22  3:15     ` Aleksandar Markovic
2019-08-22 17:59       ` Aleksandar Markovic
2019-08-26 19:52         ` Aleksandar Markovic
2019-08-28 21:24         ` Cleber Rosa
2019-08-29 18:20           ` Aleksandar Markovic
2019-08-29 17:55 ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828212726.GC11512@localhost.localdomain \
    --to=crosa@redhat.com \
    --cc=aleksandar.markovic@rt-rk.com \
    --cc=amarkovic@wavecomp.com \
    --cc=cohuck@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).