qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
	qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/7] Move qtests to a separate folder
Date: Wed, 11 Sep 2019 08:58:57 +0200	[thread overview]
Message-ID: <20190911065857.GB4907@localhost.localdomain> (raw)
In-Reply-To: <4ce671ea-452b-39ac-ea2e-83b9d75a3b84@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

Am 10.09.2019 um 21:07 hat Eric Blake geschrieben:
> On 9/10/19 1:58 PM, Thomas Huth wrote:
> > Our "tests" directory is very overcrowded - we store the qtests,
> > unit test and other files there. That makes it difficult to
> > determine which file belongs to each test subsystem, and the
> > wildcards in the MAINTAINERS file are inaccurate, too.
> > 
> > Let's clean up this mess. The first patches disentangle some
> > dependencies, and the last three patches then move the qtests
> > and libqos (which is a subsystem of the qtests) to a new folder
> > called "tests/qtest/".
> 
> I'd also welcome a rename of tests/qemu-iotests to tests/iotests.

I might prefer if the directory were named "iotests" rather than
"qemu-iotests" if we were only adding the code now.

However, I'm not so sure if I'd like a rename now because a rename
always comes with a cost and the benefits are rather limited in this
case.

Kevin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2019-09-11  7:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10 18:58 [Qemu-devel] [PATCH 0/7] Move qtests to a separate folder Thomas Huth
2019-09-10 18:58 ` [Qemu-devel] [PATCH 1/7] tests/Makefile: test-char does not need libqtest Thomas Huth
2019-09-10 18:58 ` [Qemu-devel] [PATCH 2/7] tests/ptimer: Remove unnecessary inclusion of libqtest.h Thomas Huth
2019-09-10 18:58 ` [Qemu-devel] [PATCH 3/7] tests/Makefile: Remove 'tests/' and '$(EXESUF)' from the check-qtest variables Thomas Huth
2019-12-03 19:24   ` Alex Bennée
2019-12-03 19:47     ` Thomas Huth
2019-09-10 18:58 ` [Qemu-devel] [PATCH 4/7] tests/Makefile: Separate unit test dependencies from qtest dependencies Thomas Huth
2019-09-10 18:58 ` [Qemu-devel] [PATCH 5/7] test: Move qtests to a separate directory Thomas Huth
2019-09-10 18:58 ` [Qemu-devel] [PATCH 6/7] tests/Makefile: Move qtest-related settings to a separate Makefile.include Thomas Huth
2019-09-10 18:58 ` [Qemu-devel] [PATCH 7/7] tests/libqos: Move the libqos files under tests/qtest/ Thomas Huth
2019-09-10 19:07 ` [Qemu-devel] [PATCH 0/7] Move qtests to a separate folder Eric Blake
2019-09-11  6:58   ` Kevin Wolf [this message]
2019-09-11  8:01     ` [Qemu-devel] [Qemu-block] " Thomas Huth
2019-09-11  8:54       ` Kevin Wolf
2019-09-11  9:17         ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190911065857.GB4907@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=eblake@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).