From: Peter Krempa <pkrempa@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: libvir-list@redhat.com, Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [libvirt] [PATCH 1/1] IDE: deprecate ide-drive
Date: Mon, 7 Oct 2019 08:45:58 +0200 [thread overview]
Message-ID: <20191007064558.GK6129@angien.pipo.sk> (raw)
In-Reply-To: <20191006203150.13054-2-jsnow@redhat.com>
On Sun, Oct 06, 2019 at 16:31:50 -0400, John Snow wrote:
> It's an old compatibility shim that just delegates to ide-cd or ide-hd.
> I'd like to refactor these some day, and getting rid of the super-object
> will make that easier.
>
> Either way, we don't need this.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> qemu-deprecated.texi | 5 +++++
> hw/ide/qdev.c | 3 +++
> tests/qemu-iotests/051.pc.out | 6 ++++--
> 3 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 01245e0b1c4..f802d83983e 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi
> @@ -247,6 +247,11 @@ quite a bit. It will be removed without replacement unless some users speaks
> up at the @email{qemu-devel@@nongnu.org} mailing list with information about
> their usecases.
>
> +@subsection ide-drive (since 4.2)
> +
> +The 'ide-drive' device is deprecated. Users should use 'ide-hd' or
> +'ide-cd' as appropriate to get an IDE hard disk or CDROM as needed.
In libvirt we don't use ide-drive any more for command line use since
libvirt-commit 'a4cda054e7' [0]
There is a capability named 'ide-drive.wwn', but this one is actually
probed from ide-hd along with other IDE-related capabilities since
libvirt-commit 'e67b6dcf361' [1].
There is also one test file that mentions ide-drive but that is actually
not referenced from any test code so I'll just delete it.
This means that libvirt is prepared for this deprecation so I guess you
can add a vanity-by:
Libvirt-checked-by: Peter Krempa <pkrempa@redhat.com>
[0] https://libvirt.org/git/?p=libvirt.git;a=commit;h=a4cda054e7
[1] https://libvirt.org/git/?p=libvirt.git;a=commit;h=e67b6dcf361
next prev parent reply other threads:[~2019-10-07 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-06 20:31 [PATCH 0/1] IDE: Deprecate ide-drive John Snow
2019-10-06 20:31 ` [PATCH 1/1] IDE: deprecate ide-drive John Snow
2019-10-07 6:45 ` Peter Krempa [this message]
2019-10-07 9:49 ` Markus Armbruster
2019-10-07 19:23 ` John Snow
2019-10-08 6:51 ` Markus Armbruster
2019-10-09 22:42 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007064558.GK6129@angien.pipo.sk \
--to=pkrempa@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).