From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 1/3] virtio-input: fix memory leak on unrealize
Date: Fri, 8 Nov 2019 04:53:33 -0500 [thread overview]
Message-ID: <20191108045328-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20191107192731.17330-2-marcandre.lureau@redhat.com>
On Thu, Nov 07, 2019 at 11:27:29PM +0400, Marc-André Lureau wrote:
> Spotted by ASAN + minor stylistic change.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/input/virtio-input.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c
> index 51617a5885..ec54e46ad6 100644
> --- a/hw/input/virtio-input.c
> +++ b/hw/input/virtio-input.c
> @@ -275,6 +275,7 @@ static void virtio_input_finalize(Object *obj)
>
> g_free(vinput->queue);
> }
> +
> static void virtio_input_device_unrealize(DeviceState *dev, Error **errp)
> {
> VirtIOInputClass *vic = VIRTIO_INPUT_GET_CLASS(dev);
> @@ -288,6 +289,8 @@ static void virtio_input_device_unrealize(DeviceState *dev, Error **errp)
> return;
> }
> }
> + virtio_del_queue(vdev, 0);
> + virtio_del_queue(vdev, 1);
> virtio_cleanup(vdev);
> }
>
> --
> 2.24.0.rc0.20.gd81542e6f3
next prev parent reply other threads:[~2019-11-08 9:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 19:27 [PATCH 0/3] Some memory leak fixes Marc-André Lureau
2019-11-07 19:27 ` [PATCH 1/3] virtio-input: fix memory leak on unrealize Marc-André Lureau
2019-11-08 9:53 ` Michael S. Tsirkin [this message]
2019-11-07 19:27 ` [PATCH 2/3] qtest: fix qtest_qmp_device_add leak Marc-André Lureau
2019-11-07 20:31 ` Laurent Vivier
2019-11-07 20:41 ` Marc-André Lureau
2019-11-08 9:54 ` Thomas Huth
2019-11-07 19:27 ` [PATCH 3/3] cpu-plug-test: fix leaks Marc-André Lureau
2019-11-08 10:56 ` Thomas Huth
2019-11-07 21:57 ` [PATCH 0/3] Some memory leak fixes no-reply
2019-11-08 9:57 ` Thomas Huth
2019-11-08 10:17 ` Laurent Vivier
2019-11-08 9:53 ` Michael S. Tsirkin
2019-11-20 14:50 ` Marc-André Lureau
2019-11-20 14:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108045328-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).