From: Stefan Hajnoczi <stefanha@redhat.com>
To: Denis Plotnikov <dplotnikov@virtuozzo.com>
Cc: kwolf@redhat.com, fam@euphon.net, ehabkost@redhat.com,
qemu-block@nongnu.org, mst@redhat.com, qemu-devel@nongnu.org,
mreitz@redhat.com, pbonzini@redhat.com
Subject: Re: [PATCH v3] virtio: increase virtqueue size for virtio-scsi and virtio-blk
Date: Wed, 19 Feb 2020 15:14:16 +0000 [thread overview]
Message-ID: <20200219151416.GJ1078625@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200214074648.958-1-dplotnikov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]
On Fri, Feb 14, 2020 at 10:46:48AM +0300, Denis Plotnikov wrote:
> The goal is to reduce the amount of requests issued by a guest on
> 1M reads/writes. This rises the performance up to 4% on that kind of
> disk access pattern.
>
> The maximum chunk size to be used for the guest disk accessing is
> limited with seg_max parameter, which represents the max amount of
> pices in the scatter-geather list in one guest disk request.
>
> Since seg_max is virqueue_size dependent, increasing the virtqueue
> size increases seg_max, which, in turn, increases the maximum size
> of data to be read/write from a guest disk.
>
> More details in the original problem statment:
> https://lists.gnu.org/archive/html/qemu-devel/2017-12/msg03721.html
>
> Suggested-by: Denis V. Lunev <den@openvz.org>
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
>
> ---
>
> v3:
> * typos fixed
>
> v2:
> * seg_max default value changing removed
> ---
> hw/block/virtio-blk.c | 2 +-
> hw/core/machine.c | 2 ++
> hw/scsi/virtio-scsi.c | 2 +-
> 3 files changed, 4 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-02-19 17:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 7:46 [PATCH v3] virtio: increase virtqueue size for virtio-scsi and virtio-blk Denis Plotnikov
2020-02-19 15:14 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219151416.GJ1078625@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=dplotnikov@virtuozzo.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).