From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Oksana Voshchana" <ovoshcha@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Wainer Moschetta" <wainersm@redhat.com>,
"Cleber Rosa Junior" <crosa@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH-for-5.0 v3] Acceptance test: Fix to EXEC migration
Date: Wed, 25 Mar 2020 15:15:42 +0000 [thread overview]
Message-ID: <20200325151542.GB2589@work-vm> (raw)
In-Reply-To: <f644f1f2-90ab-0d6f-99c6-bae34f76df1f@redhat.com>
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> On 3/25/20 3:10 PM, Oksana Voshchana wrote:
> > Hi Philippe
> > Thanks for the review
> > I have some comments
> >
> > On Wed, Mar 25, 2020 at 2:30 PM Philippe Mathieu-Daudé
> > <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
> >
> > Hi Oksana,
> >
> > v2 was
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg682899.html, so
> > this is v3. Please increment the version in the patch subject.
> >
> > You could also send a simple "ping" to the specific patch, instead of
> > resending it.
> >
> > On 3/25/20 12:31 PM, Oksana Vohchana wrote:
> > > The exec migration test isn't run a whole test scenario.
> > > This patch fixes it
> > >
> > > Signed-off-by: Oksana Vohchana <ovoshcha@redhat.com
> > <mailto:ovoshcha@redhat.com>>
> >
> > v1 of this patch has already received reviewers tags
> > (https://www.mail-archive.com/qemu-devel@nongnu.org/msg679629.html),
> > please collect them and keep them when you resend the same patch:
> >
> > I have reposted patch without this fix because this change isn't related
> > to the series:
> > https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg06919.html
> > Is it make sense to keep this fix as a separate patch?
> >
> > Fixes: 2e768cb682bf
> > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com
> > <mailto:philmd@redhat.com>>
> > Tested-by: Wainer dos Santos Moschetta <wainersm@redhat.com
> > <mailto:wainersm@redhat.com>>
> >
> > > ---
> > > tests/acceptance/migration.py | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/tests/acceptance/migration.py
> > b/tests/acceptance/migration.py
> > > index a8367ca023..0365289cda 100644
> > > --- a/tests/acceptance/migration.py
> > > +++ b/tests/acceptance/migration.py
> > > @@ -70,8 +70,8 @@ class Migration(Test):
> > >
> > > @skipUnless(find_command('nc', default=False), "'nc'
> > command not found")
> > > def test_migration_with_exec(self):
> > > - """
> > > - The test works for both netcat-traditional and
> > netcat-openbsd packages
> > > - """
> > > + """The test works for both netcat-traditional and
> > netcat-openbsd packages."""
> >
> > Btw why are you changing the comment style?
> >
> > I got failure in PEP257
>
> OK, next time please add comment in the patch description too.
>
> >
> >
> > > free_port = self._get_free_port()
> > > dest_uri = 'exec:nc -l localhost %u' % free_port
> > > + src_uri = 'exec:nc localhost %u' % free_port
> > > + self.do_migrate(dest_uri, src_uri)
> > >
> >
> > Alex, if there is no Python testing pullreq, can you take this patch
> > via
> > your testing tree?
>
> Cc'ing David since it is migration related.
I tend to leave the tests/acceptance to someone other than the migration
tree; so feel free to take them via testing or trivial given the size.
Dave
> >
> > Thanks,
> >
> > Phil.
> >
> > Thanks
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-03-25 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 11:31 [PATCH] Acceptance test: Fix to EXEC migration Oksana Vohchana
2020-03-25 12:30 ` [PATCH-for-5.0 v3] " Philippe Mathieu-Daudé
2020-03-25 14:10 ` Oksana Voshchana
2020-03-25 14:14 ` Philippe Mathieu-Daudé
2020-03-25 15:15 ` Dr. David Alan Gilbert [this message]
2020-03-30 11:29 ` Philippe Mathieu-Daudé
2020-03-25 14:42 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325151542.GB2589@work-vm \
--to=dgilbert@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=ovoshcha@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).