From: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
To: qemu-devel@nongnu.org, rth@twiddle.net, ysato@users.sourceforge.jp
Cc: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>,
aleksandar.qemu.devel@gmail.com, alex.bennee@linaro.org,
stefanha@redhat.com
Subject: [PATCH 2/2] target/rx: Check for page crossings in use_goto_tb()
Date: Tue, 19 May 2020 18:21:44 +0200 [thread overview]
Message-ID: <20200519162144.10831-3-ahmedkhaledkaraman@gmail.com> (raw)
In-Reply-To: <20200519162144.10831-1-ahmedkhaledkaraman@gmail.com>
Add the page crossings check when using system mode. If this
fix is not applied, a number of bugs may occasionally occur during
target rx system mode emulation.
Rename parameter dc of type DisasContext* to the more common
name ctx, to keep consistency with other targets.
Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
---
target/rx/translate.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/target/rx/translate.c b/target/rx/translate.c
index 61e86653a4..77497ddbfb 100644
--- a/target/rx/translate.c
+++ b/target/rx/translate.c
@@ -143,13 +143,17 @@ void rx_cpu_dump_state(CPUState *cs, FILE *f, int flags)
}
}
-static bool use_goto_tb(DisasContext *dc, target_ulong dest)
+static bool use_goto_tb(DisasContext *ctx, target_ulong dest)
{
- if (unlikely(dc->base.singlestep_enabled)) {
+ if (unlikely(ctx->base.singlestep_enabled)) {
return false;
- } else {
- return true;
}
+
+#ifndef CONFIG_USER_ONLY
+ return (ctx->base.tb->pc & TARGET_PAGE_MASK) == (dest & TARGET_PAGE_MASK);
+#else
+ return true;
+#endif
}
static void gen_goto_tb(DisasContext *dc, int n, target_ulong dest)
--
2.17.1
next prev parent reply other threads:[~2020-05-19 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 16:21 [PATCH 0/2] Update use_goto_tb() in hppa and rx targets Ahmed Karaman
2020-05-19 16:21 ` [PATCH 1/2] target/hppa: Check page crossings in use_goto_tb() only in system mode Ahmed Karaman
2020-05-19 16:21 ` Ahmed Karaman [this message]
2020-05-19 18:01 ` [PATCH 0/2] Update use_goto_tb() in hppa and rx targets Richard Henderson
2020-05-19 18:38 ` Alex Bennée
2020-05-19 18:51 ` Richard Henderson
2020-05-21 11:32 ` Ahmed Karaman
2020-05-22 3:12 ` Richard Henderson
2020-05-25 18:39 ` Aleksandar Markovic
2020-05-26 14:14 ` Aleksandar Markovic
2020-05-26 16:08 ` Ahmed Karaman
2020-05-26 16:29 ` Aleksandar Markovic
2020-05-26 16:45 ` Aleksandar Markovic
2020-05-26 17:38 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519162144.10831-3-ahmedkhaledkaraman@gmail.com \
--to=ahmedkhaledkaraman@gmail.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).