From: David Gibson <david@gibson.dropbear.id.au>
To: Reza Arbab <arbab@linux.ibm.com>
Cc: Daniel Henrique Barboza <danielhb@linux.ibm.com>,
Leonardo Augusto Guimaraes Garcia <lagarcia@linux.ibm.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH v3] spapr: Add a new level of NUMA for GPUs
Date: Mon, 25 May 2020 15:06:07 +1000 [thread overview]
Message-ID: <20200525050607.GB23110@umbus.fritz.box> (raw)
In-Reply-To: <20200522200856.d26ilw5zcswoggj4@arbab-vm>
[-- Attachment #1: Type: text/plain, Size: 1252 bytes --]
On Fri, May 22, 2020 at 03:08:56PM -0500, Reza Arbab wrote:
> On Fri, May 22, 2020 at 02:53:33PM -0500, Reza Arbab wrote:
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -889,10 +889,16 @@ static int spapr_dt_rng(void *fdt)
> > static void spapr_dt_rtas(SpaprMachineState *spapr, void *fdt)
> > {
> > MachineState *ms = MACHINE(spapr);
> > + SpaprMachineClass *smc = SPAPR_MACHINE_GET_CLASS(ms);
> > int rtas;
> > GString *hypertas = g_string_sized_new(256);
> > GString *qemu_hypertas = g_string_sized_new(256);
> > - uint32_t refpoints[] = { cpu_to_be32(0x4), cpu_to_be32(0x4) };
> > + uint32_t refpoints[] = {
> > + cpu_to_be32(0x4),
> > + cpu_to_be32(0x4),
> > + cpu_to_be32(0x2),
> > + };
> > + uint32_t nr_refpoints = 3;
>
> Gah, I soon as I hit send I realize this should be
>
> uint32_t nr_refpoints = ARRAY_SIZE(refpoints);
>
> Can you fixup or should I send a v4?
I had one other comment that needs addressing, so you might as well
send a v4.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-05-25 5:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 19:53 [PATCH v3] spapr: Add a new level of NUMA for GPUs Reza Arbab
2020-05-22 20:08 ` Reza Arbab
2020-05-25 5:06 ` David Gibson [this message]
2020-05-25 5:05 ` David Gibson
2020-05-25 17:49 ` Reza Arbab
2020-07-16 5:04 ` David Gibson
2020-07-16 9:42 ` Daniel Henrique Barboza
2020-07-16 16:00 ` Reza Arbab
2020-07-16 16:40 ` Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525050607.GB23110@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=arbab@linux.ibm.com \
--cc=danielhb@linux.ibm.com \
--cc=groug@kaod.org \
--cc=lagarcia@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).