From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Julia Suvorova <jusual@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Peter Xu <peterx@redhat.com>,
qemu-devel@nongnu.org,
Alex Williamson <alex.williamson@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] pci: Display PCI IRQ pin in "info pci"
Date: Tue, 9 Jun 2020 11:49:49 -0400 [thread overview]
Message-ID: <20200609114913-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <2847e5da-4cc3-8273-f51f-86b0995943de@redhat.com>
On Wed, Mar 18, 2020 at 06:06:02PM +0100, Philippe Mathieu-Daudé wrote:
> On 3/17/20 9:11 PM, Peter Xu wrote:
> > On Tue, Mar 17, 2020 at 03:02:57PM -0500, Eric Blake wrote:
> > > On 3/17/20 2:59 PM, Peter Xu wrote:
> > > > Sometimes it would be good to be able to read the pin number along
> > > > with the IRQ number allocated. Since we'll dump the IRQ number, no
> > > > reason to not dump the pin information. For example, the vfio-pci
> > > > device will overwrite the pin with the hardware pin number. It would
> > > > be nice to know the pin number of one assigned device from QMP/HMP.
> > > >
> > > > CC: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > > > CC: Alex Williamson <alex.williamson@redhat.com>
> > > > CC: Michael S. Tsirkin <mst@redhat.com>
> > > > CC: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > > > CC: Julia Suvorova <jusual@redhat.com>
> > > > CC: Markus Armbruster <armbru@redhat.com>
> > > > Signed-off-by: Peter Xu <peterx@redhat.com>
> > > > ---
> > > >
> > > > This helped me to debug an IRQ sharing issue, so may good to have it
> > > > in master too.
> > >
> > > We're right at soft freeze.
> > >
> > >
> > > > +++ b/qapi/misc.json
> > > > @@ -403,6 +403,8 @@
> > > > #
> > > > # @irq: if an IRQ is assigned to the device, the IRQ number
> > > > #
> > > > +# @irq_pin: the IRQ pin, zero means no IRQ (since 5.1)
> > > > +#
> > >
> > > But if we really do want it in 5.0, this needs a tweak. Does the delay
> > > hurt?
> >
> > No it won't; it's something good to have only. I'll let the
> > maintainers to decide...
> >
> > >
> > > Naming convention: We prefer unless there is a consistency
> > > issue....
> > >
> > > > # @qdev_id: the device name of the PCI device
> > > > #
> > > > # @pci_bridge: if the device is a PCI bridge, the bridge information
> > > > @@ -417,8 +419,8 @@
> > > > { 'struct': 'PciDeviceInfo',
> > > > 'data': {'bus': 'int', 'slot': 'int', 'function': 'int',
> > > > 'class_info': 'PciDeviceClass', 'id': 'PciDeviceId',
> > > > - '*irq': 'int', 'qdev_id': 'str', '*pci_bridge': 'PciBridgeInfo',
> > > > - 'regions': ['PciMemoryRegion']} }
> > > > + '*irq': 'int', 'irq_pin': 'int', 'qdev_id': 'str',
> > > > + '*pci_bridge': 'PciBridgeInfo', 'regions': ['PciMemoryRegion'] }}
> > >
> > > and the pre-existing pci_bridge is indeed the consistency issue.
> >
> > Yeh, actually every key in this struct. :)
>
> Using 'irq-pin':
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Peter can you fix and repost pls?
> >
> > Thanks,
> >
next prev parent reply other threads:[~2020-06-09 15:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 19:59 [PATCH] pci: Display PCI IRQ pin in "info pci" Peter Xu
2020-03-17 20:02 ` Eric Blake
2020-03-17 20:11 ` Peter Xu
2020-03-18 17:06 ` Philippe Mathieu-Daudé
2020-06-09 15:49 ` Michael S. Tsirkin [this message]
2020-06-09 16:13 ` Peter Xu
2020-06-09 16:18 ` Philippe Mathieu-Daudé
2020-06-09 17:53 ` Peter Xu
2020-06-09 18:09 ` Michael S. Tsirkin
2020-03-17 20:21 ` Dr. David Alan Gilbert
2020-03-17 20:36 ` Peter Xu
2020-03-18 9:23 ` Dr. David Alan Gilbert
2020-05-23 20:34 ` Peter Xu
2020-05-25 8:19 ` Markus Armbruster
2020-05-25 14:14 ` Peter Xu
2020-05-26 8:27 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200609114913-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jusual@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).