From: Robert Foley <robert.foley@linaro.org>
To: qemu-devel@nongnu.org
Cc: robert.foley@linaro.org, cota@braap.org, pbonzini@redhat.com,
peter.puhov@linaro.org, alex.bennee@linaro.org, rth@twiddle.net
Subject: [PATCH 0/2] accel/tcg: remove implied BQL from cpu_handle_interrupt/exception path
Date: Fri, 31 Jul 2020 08:51:25 -0400 [thread overview]
Message-ID: <20200731125127.30866-1-robert.foley@linaro.org> (raw)
The purpose of this change is to set the groundwork
so that an arch could move towards removing
the BQL from the cpu_handle_interrupt/exception paths.
The BQL is a bottlneck in scaling to more cores.
And this cpu_handle_interrupt/exception path is one of
the key BQL users as measured by the QEMU sync profiling (qsp).
We have chosen to break up the process of removing
BQL from this path into two pieces:
1) Changes to the core/common functions
of cpu_handle_interrupt/exception
allowing a per-arch decision to hold BQL.
The common case and the default is for the core code
to hold the BQL (bql=true).
This set of changes is handled in this patch.
2) Removing the BQL from the per-arch functions.
1) makes it possible for an arch to set bql=false
so that the common code does not hold the BQL
across the cpu_handle_interrupt/exception call.
This allows the arch to handle locking in this path
We leave it up to the arch to make the change
at the time that makes sense.
It is worth mentioning that we are working on per-arch changes
in line with 2), and plan to submit these.
In other words, we plan to set the groundwork with this
patch series and then will take advantage of it in later series.
This patch series is based on the per-CPU locks patch:
https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg05314.html
Robert Foley (2):
hw/core: Add bql_interrupt flag to CPUClass
accel/tcg: interrupt/exception handling uses bql_interrupt flag
accel/tcg/cpu-exec.c | 34 ++++++++++++++++++++++++++--------
hw/core/cpu.c | 1 +
include/hw/core/cpu.h | 8 ++++++++
3 files changed, 35 insertions(+), 8 deletions(-)
--
2.17.1
next reply other threads:[~2020-07-31 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 12:51 Robert Foley [this message]
2020-07-31 12:51 ` [PATCH 1/2] hw/core: Add bql_interrupt flag to CPUClass Robert Foley
2020-07-31 17:43 ` Eduardo Habkost
2020-07-31 19:14 ` Robert Foley
2020-07-31 19:24 ` Eduardo Habkost
2020-08-02 16:05 ` Alex Bennée
2020-08-04 20:36 ` Eduardo Habkost
2020-07-31 12:51 ` [PATCH 2/2] accel/tcg: interrupt/exception handling uses bql_interrupt flag Robert Foley
2020-07-31 18:02 ` Paolo Bonzini
2020-07-31 20:09 ` Robert Foley
2020-07-31 20:21 ` Paolo Bonzini
2020-08-02 16:09 ` Alex Bennée
2020-08-03 7:11 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731125127.30866-1-robert.foley@linaro.org \
--to=robert.foley@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=pbonzini@redhat.com \
--cc=peter.puhov@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).