From: Lukas Straub <lukasstraub2@web.de>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-block <qemu-block@nongnu.org>,
"Juan Quintela" <quintela@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v6 8/9] chardev/char.c: Check for duplicate id before creating chardev
Date: Fri, 31 Jul 2020 15:29:52 +0200 [thread overview]
Message-ID: <20200731152952.5d9ec9b3@luklap> (raw)
In-Reply-To: <20200731093734.GE3518939@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
On Fri, 31 Jul 2020 10:37:34 +0100
Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Fri, Jul 31, 2020 at 11:27:04AM +0200, Lukas Straub wrote:
> > yank_register_instance (called when creating the new chardev object)
> > aborts if the instance already exists. So check for duplicate id before
> > creating the new chardev to prevent this.
>
> I feel the right answer here is for yank_register_instance to not
> use abort().
>
> Instead have it take a 'Error **errp' and report the error normally.
> The caller can then propagate the errors in the same way it does
> for the duplicate ID errors. If a particular caller can't handle
> errors gracefully, then it can pass "&error_abort" to the
> yank_register_instance() to get the same abort semantics as now.
>
> Regards,
> Daniel
Yes, makes sense for yank_register_instance not to kill qemu. Although (with this fix in) it always indicates a bug due to a leaked yank instance.
Regards,
Lukas Straub
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-31 13:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 9:26 [PATCH v6 0/9] Introduce 'yank' oob qmp command to recover from hanging qemu Lukas Straub
2020-07-31 9:26 ` [PATCH v6 1/9] Introduce yank feature Lukas Straub
2020-07-31 9:26 ` [PATCH v6 2/9] block/nbd.c: Add " Lukas Straub
2020-07-31 9:26 ` [PATCH v6 3/9] chardev/char-socket.c: " Lukas Straub
2020-07-31 9:26 ` [PATCH v6 4/9] migration: " Lukas Straub
2020-07-31 9:26 ` [PATCH v6 5/9] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe Lukas Straub
2020-07-31 9:26 ` [PATCH v6 6/9] io: Document thread-safety of qio_channel_shutdown Lukas Straub
2020-07-31 9:27 ` [PATCH v6 7/9] MAINTAINERS: Add myself as maintainer for yank feature Lukas Straub
2020-07-31 9:27 ` [PATCH v6 8/9] chardev/char.c: Check for duplicate id before creating chardev Lukas Straub
2020-07-31 9:37 ` Daniel P. Berrangé
2020-07-31 13:29 ` Lukas Straub [this message]
2020-07-31 9:27 ` [PATCH v6 9/9] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731152952.5d9ec9b3@luklap \
--to=lukasstraub2@web.de \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).