From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: dinechin@redhat.com, virtio-fs@redhat.com, qemu-devel@nongnu.org,
vgoyal@redhat.com
Subject: Re: [PATCH v3 5/5] tools/virtiofsd: xattr name mappings: Simple 'map'
Date: Tue, 20 Oct 2020 12:35:30 +0100 [thread overview]
Message-ID: <20201020113530.GC2962@work-vm> (raw)
In-Reply-To: <20201020100922.GF140014@stefanha-x1.localdomain>
* Stefan Hajnoczi (stefanha@redhat.com) wrote:
> On Wed, Oct 14, 2020 at 07:02:09PM +0100, Dr. David Alan Gilbert (git) wrote:
> > +static XattrMapEntry *parse_xattrmap_map(const char *rule,
> > + XattrMapEntry *map,
> > + size_t *nentries)
> > +{
> > + char sep = *rule++;
> > + const char *tmp;
> > + char *key;
> > + char *prefix;
> > + XattrMapEntry tmp_entry;
> > +
> > + /* At start of 'key' field */
> > + tmp = strchr(rule, sep);
>
> Missing sep == '\0' check. The strchr(3) man page says:
>
> The terminating null byte is considered part of the string, so that if
> c is specified as '\0', these functions return a pointer to the
> terminator.
>
> So the code in this patch will eventually access beyond the end of the
> string:
>
> rule = tmp + 1; <-- tmp is already at the NUL terminator
Ah yes, I've got the check in the main routine but not in the _map case;
OK I'll fix that up.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-10-20 11:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 18:02 [PATCH v3 0/5] virtiofsd xattr name mappings Dr. David Alan Gilbert (git)
2020-10-14 18:02 ` [PATCH v3 1/5] tools/virtiofsd: xattr name mappings: Add option Dr. David Alan Gilbert (git)
2020-10-20 9:07 ` Stefan Hajnoczi
2020-10-21 17:13 ` Dr. David Alan Gilbert
2020-10-20 14:04 ` Vivek Goyal
2020-10-22 14:52 ` Vivek Goyal
2020-10-23 15:46 ` Dr. David Alan Gilbert
2020-10-14 18:02 ` [PATCH v3 2/5] tools/virtiofsd: xattr name mappings: Map client xattr names Dr. David Alan Gilbert (git)
2020-10-20 9:16 ` Stefan Hajnoczi
2020-10-22 15:28 ` Vivek Goyal
2020-10-23 15:04 ` Dr. David Alan Gilbert
2020-10-14 18:02 ` [PATCH v3 3/5] tools/virtiofsd: xattr name mappings: Map server " Dr. David Alan Gilbert (git)
2020-10-20 9:52 ` Stefan Hajnoczi
2020-10-22 16:16 ` Vivek Goyal
2020-10-23 14:49 ` Dr. David Alan Gilbert
2020-10-14 18:02 ` [PATCH v3 4/5] tools/virtiofsd: xattr name mapping examples Dr. David Alan Gilbert (git)
2020-10-20 9:56 ` Stefan Hajnoczi
2020-10-20 14:40 ` Vivek Goyal
2020-10-20 15:34 ` Dr. David Alan Gilbert
2020-10-20 17:56 ` Vivek Goyal
2020-10-20 19:02 ` Dr. David Alan Gilbert
2020-10-21 13:44 ` Vivek Goyal
2020-10-21 17:39 ` Dr. David Alan Gilbert
2020-10-14 18:02 ` [PATCH v3 5/5] tools/virtiofsd: xattr name mappings: Simple 'map' Dr. David Alan Gilbert (git)
2020-10-20 10:09 ` Stefan Hajnoczi
2020-10-20 11:35 ` Dr. David Alan Gilbert [this message]
2020-10-22 13:42 ` Vivek Goyal
2020-10-23 13:05 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020113530.GC2962@work-vm \
--to=dgilbert@redhat.com \
--cc=dinechin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).