On Mon, Mar 22, 2021 at 02:54:30PM +0100, Paolo Bonzini wrote: > On 22/03/21 11:47, Keqian Zhu wrote: > > > + qemu_mutex_init(&kml_slots_lock); > > As you said, x86 has two address spaces, is it a problem that we may have multi initialization for kml_slots_lock? > > Agreed, the lock can be initialized (if only for cleanliness) in kvm_init. Definitely, I'm surprised why I didn't see this... :) Paolo, do you want me to add another patch (as attached)? -- Peter Xu