From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, den@openvz.org, vsementsov@virtuozzo.com,
mreitz@redhat.com, John Snow <jsnow@redhat.com>
Subject: [PATCH v3 5/9] simplebench/bench_block_job: handle error in BLOCK_JOB_COMPLETED
Date: Tue, 23 Mar 2021 16:47:30 +0300 [thread overview]
Message-ID: <20210323134734.72930-6-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210323134734.72930-1-vsementsov@virtuozzo.com>
We should not report success if there is an error in final event.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
---
scripts/simplebench/bench_block_job.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py
index 8f8385ccce..71d2e489c8 100755
--- a/scripts/simplebench/bench_block_job.py
+++ b/scripts/simplebench/bench_block_job.py
@@ -70,6 +70,10 @@ def bench_block_job(cmd, cmd_args, qemu_args):
vm.shutdown()
return {'error': 'block-job failed: ' + str(e),
'vm-log': vm.get_log()}
+ if 'error' in e['data']:
+ vm.shutdown()
+ return {'error': 'block-job failed: ' + e['data']['error'],
+ 'vm-log': vm.get_log()}
end_ms = e['timestamp']['seconds'] * 1000000 + \
e['timestamp']['microseconds']
finally:
--
2.29.2
next prev parent reply other threads:[~2021-03-23 13:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 13:47 [PATCH v3 0/9] simplebench improvements Vladimir Sementsov-Ogievskiy
2021-03-23 13:47 ` [PATCH v3 1/9] simplebench: bench_one(): add slow_limit argument Vladimir Sementsov-Ogievskiy
2021-03-23 13:47 ` [PATCH v3 2/9] simplebench: bench_one(): support count=1 Vladimir Sementsov-Ogievskiy
2021-03-23 13:47 ` [PATCH v3 3/9] simplebench/bench-backup: add --compressed option Vladimir Sementsov-Ogievskiy
2021-03-23 13:47 ` [PATCH v3 4/9] simplebench/bench-backup: add target-cache argument Vladimir Sementsov-Ogievskiy
2021-03-23 13:47 ` Vladimir Sementsov-Ogievskiy [this message]
2021-03-23 13:47 ` [PATCH v3 6/9] simplebench/bench-backup: support qcow2 source files Vladimir Sementsov-Ogievskiy
2021-03-23 13:47 ` [PATCH v3 7/9] simplebench/bench-backup: add --count and --no-initial-run Vladimir Sementsov-Ogievskiy
2021-03-23 13:47 ` [PATCH v3 8/9] simplebench/bench-backup: add --drop-caches argument Vladimir Sementsov-Ogievskiy
2021-03-23 13:47 ` [PATCH v3 9/9] MAINTAINERS: update Benchmark util: add git tree Vladimir Sementsov-Ogievskiy
2021-04-27 8:58 ` [PATCH v3 0/9] simplebench improvements Vladimir Sementsov-Ogievskiy
2021-05-04 8:59 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323134734.72930-6-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).