From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v2 2/7] ui/vdagent: core infrastructure
Date: Wed, 24 Mar 2021 10:46:58 +0100 [thread overview]
Message-ID: <20210324094658.nfnuufvqm7cqseww@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210322102717.xakx5rfg3gdekjfk@sirius.home.kraxel.org>
On Mon, Mar 22, 2021 at 11:27:17AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > + if (vd->msgsize != msg->size + sizeof(*msg)) {
> > > + /* FIXME: handle parse messages splitted into multiple chunks */
> > > + fprintf(stderr, "%s: size mismatch: chunk %d, msg %d (+%zd)\n",
> > > + __func__, vd->msgsize, msg->size, sizeof(*msg));
> > >
> >
> > Not fixing? You handle chunking on sending but not on receiving?
>
> linux vdagent doesn't do chunking on send, so no need (and also no
> testcase) so far.
>
> Didn't try windows guests (yet), but that is next on my clipboard
> todo list.
Hmm, windows guest agent doesn't has VD_AGENT_CAP_CLIPBOARD_SELECTION,
so I have to deal with that.
Windows guests do actually send large messages in chunks, so I have
something to test with, good.
What are VD_AGENT_CAP_GUEST_LINEEND_LF + VD_AGENT_CAP_GUEST_LINEEND_CRLF
are good for btw? Are linefeeds converted automatically between dos and
unix conventions? If so, who is supposed to handle that?
take care,
Gerd
next prev parent reply other threads:[~2021-03-24 9:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 9:16 [PATCH v2 0/7] ui: add vdagent implementation and clipboard support Gerd Hoffmann
2021-03-18 9:16 ` [PATCH v2 1/7] ui: add clipboard infrastructure Gerd Hoffmann
2021-03-18 9:16 ` [PATCH v2 2/7] ui/vdagent: core infrastructure Gerd Hoffmann
2021-03-18 10:32 ` Marc-André Lureau
2021-03-22 10:27 ` Gerd Hoffmann
2021-03-24 9:46 ` Gerd Hoffmann [this message]
2021-03-24 10:31 ` Marc-André Lureau
2021-03-18 9:16 ` [PATCH v2 3/7] ui/vdagent: add mouse support Gerd Hoffmann
2021-03-18 10:24 ` Marc-André Lureau
2021-03-18 9:16 ` [PATCH v2 4/7] ui/vdagent: add clipboard support Gerd Hoffmann
2021-03-18 9:16 ` [PATCH v2 5/7] ui/vnc: " Gerd Hoffmann
2021-03-18 9:16 ` [PATCH v2 6/7] ui/gtk: move struct GtkDisplayState to ui/gtk.h Gerd Hoffmann
2021-03-18 9:16 ` [PATCH v2 7/7] ui/gtk: add clipboard support Gerd Hoffmann
2021-03-18 10:55 ` Marc-André Lureau
2021-03-24 10:16 ` Gerd Hoffmann
2021-03-24 10:26 ` Marc-André Lureau
2021-03-24 12:57 ` Gerd Hoffmann
2021-03-24 13:26 ` Marc-André Lureau
2021-03-24 14:47 ` Gerd Hoffmann
2021-03-18 9:30 ` [PATCH v2 0/7] ui: add vdagent implementation and " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324094658.nfnuufvqm7cqseww@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).