From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E9D6C433DB for ; Wed, 24 Mar 2021 22:43:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A08061A0A for ; Wed, 24 Mar 2021 22:43:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A08061A0A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPCDL-0004j2-Ag for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 18:42:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPC9v-0001a4-4C; Wed, 24 Mar 2021 18:39:27 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:50812 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPC9r-0002jw-83; Wed, 24 Mar 2021 18:39:26 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 12OMYNFM014427; Wed, 24 Mar 2021 18:39:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=NYoNUd7YDsykkYHf2aml8u42BPG48iPwlx9Nkz7ImNY=; b=RnDojjOluwV6KCY6bpFPhBEew/absfzwYr7czq63iNAdVRxE3McW15zCk1aK7XaZz1BW AkAsjwiswJ2XlVoePfs4tkwXFfuMvUKtG02joa77dutjDwPRbQr1I1PJNki/R0NG4HG4 eXo92xr9RsJLB5gz4pAT7PKST4GU+BKkkm+qXGvC0VcEfVpJIGADURj6RSuktjpXKOGK O7Zpc5SlThebwiXK66eRUGj7qEE4U4caHSTcw2nF1L0oC2g8oTYM1haq8QLvCEWVl/qA 5SJSB/CmG3usekjoJx1LrMPtv0tfE9pk7TLnANlJ1MUjhgFfGTne8HN8jz89sWd8lHQn fA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 37g8m0h89r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Mar 2021 18:39:16 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 12OMZ5aw016224; Wed, 24 Mar 2021 18:39:15 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 37g8m0h89h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Mar 2021 18:39:15 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 12OMcPIk006193; Wed, 24 Mar 2021 22:39:15 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma03dal.us.ibm.com with ESMTP id 37d9bf9d76-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 24 Mar 2021 22:39:15 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 12OMdEUC31130018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Mar 2021 22:39:14 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F08CCC605D; Wed, 24 Mar 2021 22:39:13 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4511FC605F; Wed, 24 Mar 2021 22:39:11 +0000 (GMT) Received: from T480-KlausKiwi.localdomain (unknown [9.85.133.239]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 24 Mar 2021 22:39:10 +0000 (GMT) From: Klaus Heinrich Kiwi To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 1/3] aspeed: Coding Style cleanups on do_hash_operation Date: Wed, 24 Mar 2021 19:38:44 -0300 Message-Id: <20210324223846.17407-2-klaus@linux.vnet.ibm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210324223846.17407-1-klaus@linux.vnet.ibm.com> References: <20210324223846.17407-1-klaus@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-24_13:2021-03-24, 2021-03-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103240161 Received-SPF: none client-ip=148.163.158.5; envelope-from=klaus@linux.vnet.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Peter Maydell , Thomas Huth , Andrew Jeffery , Klaus Heinrich Kiwi , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Paolo Bonzini , Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Basically using camelCase for some variables... Signed-off-by: Klaus Heinrich Kiwi --- hw/misc/aspeed_hace.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 6e5b447a48..93313d2b80 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -86,24 +86,24 @@ static int hash_algo_lookup(uint32_t mask) static int do_hash_operation(AspeedHACEState *s, int algo) { - hwaddr src, len, dest; - uint8_t *digest_buf = NULL; - size_t digest_len = 0; - char *src_buf; + uint32_t src, len, dest; + uint8_t *digestBuf = NULL; + size_t digestLen = 0; + char *srcBuf; int rc; src = s->regs[R_HASH_SRC]; len = s->regs[R_HASH_SRC_LEN]; dest = s->regs[R_HASH_DEST]; - src_buf = address_space_map(&s->dram_as, src, &len, false, - MEMTXATTRS_UNSPECIFIED); - if (!src_buf) { + srcBuf = address_space_map(&s->dram_as, src, (hwaddr *) &len, + false, MEMTXATTRS_UNSPECIFIED); + if (!srcBuf) { qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to map dram\n", __func__); return -EACCES; } - rc = qcrypto_hash_bytes(algo, src_buf, len, &digest_buf, &digest_len, + rc = qcrypto_hash_bytes(algo, srcBuf, len, &digestBuf, &digestLen, &error_fatal); if (rc < 0) { qemu_log_mask(LOG_GUEST_ERROR, "%s: qcrypto failed\n", __func__); @@ -111,14 +111,14 @@ static int do_hash_operation(AspeedHACEState *s, int algo) } rc = address_space_write(&s->dram_as, dest, MEMTXATTRS_UNSPECIFIED, - digest_buf, digest_len); + digestBuf, digestLen); if (rc) { qemu_log_mask(LOG_GUEST_ERROR, "%s: address space write failed\n", __func__); } - g_free(digest_buf); + g_free(digestBuf); - address_space_unmap(&s->dram_as, src_buf, len, false, len); + address_space_unmap(&s->dram_as, srcBuf, len, false, len); /* * Set status bits to indicate completion. Testing shows hardware sets -- 2.25.1