From: Vincent Bernat <vincent@bernat.ch>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
qemu-devel@nongnu.org,
"Daniel P . Berrangé" <berrange@redhat.com>
Cc: Vincent Bernat <vincent@bernat.ch>
Subject: [PATCH v2 2/2] hw/smbios: retrieve PCI address from specified device for Type 41
Date: Thu, 1 Apr 2021 10:25:44 +0200 [thread overview]
Message-ID: <20210401082544.16522-2-vincent@bernat.ch> (raw)
In-Reply-To: <20210401082544.16522-1-vincent@bernat.ch>
Instead of specifying the PCI address manually, the device can be
specified by ID:
$QEMU -netdev user,id=internet
-device virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \
-smbios type=41,designation='Onboard LAN',instance=1,kind=ethernet,pcidev=internet-dev
The PCI segment is assumed to be 0. This should hold true for most
cases.
$ dmidecode -t 41
# dmidecode 3.3
Getting SMBIOS data from sysfs.
SMBIOS 2.8 present.
Handle 0x2900, DMI type 41, 11 bytes
Onboard Device
Reference Designation: Onboard LAN
Type: Ethernet
Status: Enabled
Type Instance: 1
Bus Address: 0000:00:09.0
$ ip -brief a
lo UNKNOWN 127.0.0.1/8 ::1/128
eno1 UP 10.0.2.14/24 fec0::5254:ff:fe00:42/64 fe80::5254:ff:fe00:42/64
Signed-off-by: Vincent Bernat <vincent@bernat.ch>
---
hw/smbios/smbios.c | 47 +++++++++++++++++++++-------------------------
qemu-options.hx | 2 +-
2 files changed, 22 insertions(+), 27 deletions(-)
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c
index 46a08652dff4..0f390e03453c 100644
--- a/hw/smbios/smbios.c
+++ b/hw/smbios/smbios.c
@@ -27,6 +27,7 @@
#include "hw/firmware/smbios.h"
#include "hw/loader.h"
#include "hw/boards.h"
+#include "hw/pci/pci.h"
#include "smbios_build.h"
/* legacy structures and constants for <= 2.0 machines */
@@ -134,12 +135,8 @@ static QEnumLookup type41_kind_lookup = {
.size = 10
};
struct type41_instance {
- const char *designation;
+ const char *designation, *pcidev;
uint8_t instance, kind;
- struct {
- uint16_t segment;
- uint8_t bus, device;
- } pci;
QTAILQ_ENTRY(type41_instance) next;
};
static QTAILQ_HEAD(, type41_instance) type41 = QTAILQ_HEAD_INITIALIZER(type41);
@@ -403,10 +400,9 @@ static const QemuOptDesc qemu_smbios_type41_opts[] = {
.type = QEMU_OPT_NUMBER,
.help = "device type instance",
},{
- .name = "pci",
+ .name = "pcidev",
.type = QEMU_OPT_STRING,
.help = "PCI device",
- .def_value_str = "0:0.0",
},
{ /* end of list */ }
};
@@ -837,9 +833,23 @@ static void smbios_build_type_41_table(void)
SMBIOS_TABLE_SET_STR(41, reference_designation_str, t41->designation);
t->device_type = t41->kind;
t->device_type_instance = t41->instance;
- t->segment_group_number = cpu_to_le16(t41->pci.segment);
- t->bus_number = t41->pci.bus;
- t->device_number = t41->pci.device;
+
+ if (t41->pcidev) {
+ PCIDevice *pdev = NULL;
+ int rc = pci_qdev_find_device(t41->pcidev, &pdev);
+ if (rc == 0) {
+ /*
+ * TODO: Extract the appropriate value. Most of the
+ * time, this will be 0.
+ */
+ t->segment_group_number = cpu_to_le16(0);
+ t->bus_number = pci_dev_bus_num(pdev);
+ t->device_number = pdev->devfn;
+ } else {
+ fprintf(stderr, "%s: cannot find PCI device %s\n",
+ __func__, t41->pcidev);
+ }
+ }
SMBIOS_BUILD_TABLE_POST;
instance++;
@@ -1301,7 +1311,6 @@ void smbios_entry_add(QemuOpts *opts, Error **errp)
case 41: {
struct type41_instance *t;
Error *local_err = NULL;
- int pseg, pbus, pdevice, pfunction;
if (!qemu_opts_validate(opts, qemu_smbios_type41_opts, errp)) {
return;
@@ -1324,21 +1333,7 @@ void smbios_entry_add(QemuOpts *opts, Error **errp)
return;
}
t->instance = qemu_opt_get_number(opts, "instance", 1);
- if (sscanf(qemu_opt_get(opts, "pci"), "%x:%x:%x.%x",
- &pseg,
- &pbus,
- &pdevice,
- &pfunction) != 4) {
- error_setg(errp, "unable to parse %s: %s",
- qemu_opt_get(opts, "pci"),
- g_strerror(errno));
- free(t);
- return;
- }
- t->pci.segment = pseg;
- t->pci.bus = pbus;
- t->pci.device = ((uint8_t)pdevice << 3) +
- ((uint8_t)pfunction & 0x7);
+ save_opt(&t->pcidev, opts, "pcidev");
QTAILQ_INSERT_TAIL(&type41, t, next);
return;
diff --git a/qemu-options.hx b/qemu-options.hx
index eb2de7c372c7..e6e54f9bd1f3 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2371,7 +2371,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
"-smbios type=17[,loc_pfx=str][,bank=str][,manufacturer=str][,serial=str]\n"
" [,asset=str][,part=str][,speed=%d]\n"
" specify SMBIOS type 17 fields\n"
- "-smbios type=41[,designation=str][,kind=str][,instance=%d][,pci=%x:%x:%x.%x]\n"
+ "-smbios type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
" specify SMBIOS type 41 fields\n",
QEMU_ARCH_I386 | QEMU_ARCH_ARM)
SRST
--
2.31.0
next prev parent reply other threads:[~2021-04-01 8:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 8:25 [PATCH v2 1/2] hw/smbios: support for type 41 (onboard devices extended information) Vincent Bernat
2021-04-01 8:25 ` Vincent Bernat [this message]
2021-04-01 9:38 ` [PATCH v2 2/2] hw/smbios: retrieve PCI address from specified device for Type 41 Daniel P. Berrangé
2021-04-01 10:07 ` Vincent Bernat
2021-04-01 10:19 ` Daniel P. Berrangé
2021-04-01 12:27 ` Vincent Bernat
2021-04-01 13:59 ` Michael S. Tsirkin
2021-04-01 14:26 ` Vincent Bernat
2021-04-01 16:32 ` Michael S. Tsirkin
2021-04-01 8:41 ` [PATCH v2 1/2] hw/smbios: support for type 41 (onboard devices extended information) Daniel P. Berrangé
2021-04-01 8:46 ` Vincent Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401082544.16522-2-vincent@bernat.ch \
--to=vincent@bernat.ch \
--cc=berrange@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).