qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com,
	pbonzini@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
	aurelien@aurel32.net
Subject: [PATCH  v1 11/25] tests/tcg: Add docker_as and docker_ld cmds
Date: Mon, 19 Apr 2021 15:54:21 +0100	[thread overview]
Message-ID: <20210419145435.14083-12-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210419145435.14083-1-alex.bennee@linaro.org>

From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

At least for the TriCore target no easily available c compiler exists.
Thus we need to rely on "as" and "ld". This allows us to run them
through the docker image. We don't test the generation capabilities of
docker images as they are assumed to work.

Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
[AJB: fix quoting, only handle docker & clear, test -n, tweak commit msg]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/tcg/Makefile.qemu | 15 +++++++++++++++
 tests/tcg/configure.sh  | 17 ++++++++++++++++-
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/tests/tcg/Makefile.qemu b/tests/tcg/Makefile.qemu
index a56564660c..2c4617516b 100644
--- a/tests/tcg/Makefile.qemu
+++ b/tests/tcg/Makefile.qemu
@@ -22,6 +22,8 @@ quiet-@ = $(if $(V),,@)
 quiet-command = $(quiet-@)$(call quiet-command-run,$1,$2,$3)
 
 CROSS_CC_GUEST:=
+CROSS_AS_GUEST:=
+CROSS_LD_GUEST:=
 DOCKER_IMAGE:=
 
 -include tests/tcg/config-$(TARGET).mak
@@ -42,6 +44,7 @@ cross-build-guest-tests:
 	$(call quiet-command, \
 	   (mkdir -p tests/tcg/$(TARGET) && cd tests/tcg/$(TARGET) && \
 	    $(MAKE) -f $(TCG_MAKE) TARGET="$(TARGET)" CC="$(CROSS_CC_GUEST)" \
+			AS="$(CROSS_AS_GUEST)" LD="$(CROSS_LD_GUEST)" \
 			SRC_PATH="$(SRC_PATH)" BUILD_STATIC=$(CROSS_CC_GUEST_STATIC) \
 			EXTRA_CFLAGS="$(CROSS_CC_GUEST_CFLAGS)"), \
 	"BUILD","$(TARGET) guest-tests with $(CROSS_CC_GUEST)")
@@ -59,11 +62,23 @@ DOCKER_COMPILE_CMD="$(DOCKER_SCRIPT) cc \
 		-i qemu/$(DOCKER_IMAGE) \
 		-s $(SRC_PATH) -- "
 
+DOCKER_AS_CMD="$(DOCKER_SCRIPT) cc \
+		--cc $(DOCKER_CROSS_AS_GUEST) \
+		-i qemu/$(DOCKER_IMAGE) \
+		-s $(SRC_PATH) -- "
+
+DOCKER_LD_CMD="$(DOCKER_SCRIPT) cc \
+		--cc $(DOCKER_CROSS_LD_GUEST) \
+		-i qemu/$(DOCKER_IMAGE) \
+		-s $(SRC_PATH) -- "
+
+
 .PHONY: docker-build-guest-tests
 docker-build-guest-tests: docker-image-$(DOCKER_IMAGE)
 	$(call quiet-command, \
 	  (mkdir -p tests/tcg/$(TARGET) && cd tests/tcg/$(TARGET) && \
 	   $(MAKE) -f $(TCG_MAKE) TARGET="$(TARGET)" CC=$(DOCKER_COMPILE_CMD) \
+			AS=$(DOCKER_AS_CMD) LD=$(DOCKER_LD_CMD) \
 			SRC_PATH="$(SRC_PATH)" BUILD_STATIC=y \
 			EXTRA_CFLAGS="$(CROSS_CC_GUEST_CFLAGS)"), \
 	"BUILD","$(TARGET) guest-tests with docker qemu/$(DOCKER_IMAGE)")
diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
index bfe9619217..9f304b6c5a 100755
--- a/tests/tcg/configure.sh
+++ b/tests/tcg/configure.sh
@@ -75,7 +75,13 @@ fi
 for target in $target_list; do
   arch=${target%%-*}
 
+  # reset all container fields
   container_image=
+  container_hosts=
+  container_cross_cc=
+  container_cross_as=
+  container_cross_ld=
+
   case $target in
     aarch64-*)
       # We don't have any bigendian build tools so we only use this for AArch64
@@ -272,7 +278,16 @@ for target in $target_list; do
       for host in $container_hosts; do
           if test "$host" = "$ARCH"; then
               echo "DOCKER_IMAGE=$container_image" >> $config_target_mak
-              echo "DOCKER_CROSS_CC_GUEST=$container_cross_cc" >> $config_target_mak
+              echo "DOCKER_CROSS_CC_GUEST=$container_cross_cc" >> \
+                   $config_target_mak
+              if test -n "$container_cross_as"; then
+                  echo "DOCKER_CROSS_AS_GUEST=$container_cross_as" >> \
+                      $config_target_mak
+              fi
+              if test -n "$container_cross_ld"; then
+                  echo "DOCKER_CROSS_LD_GUEST=$container_cross_ld" >> \
+                      $config_target_mak
+              fi
           fi
       done
   fi
-- 
2.20.1



  parent reply	other threads:[~2021-04-19 15:02 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 14:54 [PATCH for post 6.0 v1 00/25] testing/next (hexagon/tricore/test cc) Alex Bennée
2021-04-19 14:54 ` [PATCH v1 01/25] checkpatch: Fix use of uninitialized value Alex Bennée
2021-04-19 14:54 ` [PATCH v1 02/25] tests/docker: fix copying of executable in "update" Alex Bennée
2021-04-23 17:35   ` Willian Rampazzo
2021-04-19 14:54 ` [PATCH v1 03/25] tests/docker: make executable an optional argument to "update" Alex Bennée
2021-04-23 17:37   ` Willian Rampazzo
2021-04-19 14:54 ` [PATCH v1 04/25] tests/docker: allow "update" to add the current user Alex Bennée
2021-04-23 18:35   ` Willian Rampazzo
2021-04-19 14:54 ` [PATCH v1 05/25] tests/docker: add "fetch" sub-command Alex Bennée
2021-04-23 18:37   ` Willian Rampazzo
2021-04-19 14:54 ` [PATCH v1 06/25] docker: Add Hexagon image Alex Bennée
2021-04-23 18:41   ` Willian Rampazzo
2021-04-23 22:25   ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 07/25] tests/tcg: Use Hexagon Docker image Alex Bennée
2021-04-23 22:23   ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 08/25] gitlab: add build-user-hexagon test Alex Bennée
2021-04-23 18:38   ` Willian Rampazzo
2021-04-23 22:23   ` Philippe Mathieu-Daudé
2021-05-11 14:41   ` Alex Bennée
2021-05-11 14:53     ` Brian Cain
2021-05-11 15:08       ` Brian Cain
2021-05-12  7:34         ` Alex Bennée
2021-04-19 14:54 ` [PATCH v1 09/25] tests/tcg: don't iterate through other arch compilers Alex Bennée
2021-04-19 14:54 ` [PATCH v1 10/25] tests/docker: Added libbpf library to the docker files Alex Bennée
2021-04-23 18:39   ` Willian Rampazzo
2021-04-23 22:30   ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` Alex Bennée [this message]
2021-04-23 22:31   ` [PATCH v1 11/25] tests/tcg: Add docker_as and docker_ld cmds Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 12/25] tests/tcg: Run timeout cmds using --foreground Alex Bennée
2021-04-19 14:54 ` [PATCH v1 13/25] hw/tricore: Add testdevice for tests in tests/tcg/ Alex Bennée
2021-04-26  9:37   ` Philippe Mathieu-Daudé
2021-04-26 10:15     ` Alex Bennée
2021-04-26 12:03       ` Philippe Mathieu-Daudé
2021-04-19 14:54 ` [PATCH v1 14/25] tests/tcg/tricore: Add build infrastructure Alex Bennée
2021-04-19 14:54 ` [PATCH v1 15/25] configure: Emit HOST_CC to config-host.mak Alex Bennée
2021-04-19 14:54 ` [PATCH v1 16/25] tests/tcg/tricore: Add macros to create tests and first test 'abs' Alex Bennée
2021-04-19 14:54 ` [PATCH v1 17/25] tests/tcg/tricore: Add bmerge test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 18/25] tests/tcg/tricore: Add clz test Alex Bennée
2021-04-29 13:53   ` Bastian Koppelmann
2021-04-19 14:54 ` [PATCH v1 19/25] tests/tcg/tricore: Add dvstep test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 20/25] tests/tcg/tricore: Add fadd test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 21/25] tests/tcg/tricore: Add fmul test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 22/25] tests/tcg/tricore: Add ftoi test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 23/25] tests/tcg/tricore: Add madd test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 24/25] tests/tcg/tricore: Add msub test Alex Bennée
2021-04-19 14:54 ` [PATCH v1 25/25] tests/tcg/tricore: Add muls test Alex Bennée
2021-04-19 15:51 ` [PATCH for post 6.0 v1 00/25] testing/next (hexagon/tricore/test cc) no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210419145435.14083-12-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).